Andre Miller
96e3d8b451
Replaced print with log.info
2015-01-21 19:31:02 +02:00
David Logie
8ccd385d85
Add a note to the docs and changelog about the new -f/--format option for mbsync.
2015-01-21 08:08:34 +00:00
David Logie
f458549e4e
mbsync: Set default album/item format for tests.
2015-01-21 08:05:27 +00:00
David Logie
28f616f75d
mbsync: Remove unnecessary decorators.
2015-01-21 08:05:27 +00:00
David Logie
99e89a29e2
mbsync: Don't overwrite the format built-in.
2015-01-21 08:05:27 +00:00
David Logie
11a21e149e
mbsync: Improve tests.
...
* Move the "skipped item" tests to their own method.
* Add a test for the default format
2015-01-21 08:05:27 +00:00
David Logie
7db3e1d80c
mbsync: Fix bug where singletons always used the album format.
2015-01-21 08:05:27 +00:00
David Logie
3e9f716b68
Remove unused variable.
2015-01-21 08:05:27 +00:00
David Logie
1380ee79dc
Add basic test for custom mbsync formats.
2015-01-21 08:05:27 +00:00
David Logie
2fae94a93a
Make the Template object an attribute.
2015-01-21 08:05:26 +00:00
David Logie
3317580296
mbsync: Support custom output format.
2015-01-21 08:05:26 +00:00
Adrian Sampson
7e21c68487
Logging: pass through non-problematic values
...
9b83cef was a little too aggressive; we need most objects to go through
unconverted so '{0.title}' and such still work in format strings. This is now
just a targeted workaround for the case I encountered.
2015-01-20 16:28:42 -08:00
Adrian Sampson
9b83cef0de
Handle encoding misfortunes in logging ( #1248 )
...
The beets loggers now, as proposed in #1044 , do their utmost to avoid crashing
when logged values are not valid Unicode or Unicode-convertible. This came up
urgently when a `CalledProcessError` could not be logged with `'u{}'.format()`
(!!!) so we needed to some manner of conversion, but it should be possible to
log paths without `displayable_path`. In fact, it may be time to retire
`displayable_path` for the most part.
2015-01-20 16:17:59 -08:00
Adrian Sampson
770ffad638
Require mutagen 1.27
...
Avoid incorrect reporting of audio properties for MPEG-4 on earlier versions,
as in #1243 .
2015-01-20 15:30:28 -08:00
Adrian Sampson
1a151c2272
Remove redundant config rest in tests
...
teardown_beets resets the configuration already.
2015-01-20 15:22:59 -08:00
Adrian Sampson
f617d162cf
keyfinder: Better output parsing ( #1248 )
...
We were being sloppy about bytes output from the process. Also, it seems like
the tools outputs the path also, so it's necessary to break on whitespace to
actually get the key name.
2015-01-20 15:17:21 -08:00
Adrian Sampson
dae1776165
Reasonable logging for keyfinder command
...
Previously the command was completely silent.
2015-01-20 15:12:26 -08:00
Adrian Sampson
5586fcee67
keyfinder: Only write on import when asked to
...
This should really be standard machinery.
2015-01-20 15:11:13 -08:00
Adrian Sampson
b737102008
One-byte typo fix
2015-01-20 15:02:13 -08:00
Adrian Sampson
899365c4a9
Finish changing plugin name in docs ( #1186 )
2015-01-20 15:00:28 -08:00
Adrian Sampson
ea2474277a
Changelog/typo fix for filefilter ( #1186 )
2015-01-20 14:55:50 -08:00
Adrian Sampson
07f99e6ab7
Fix up tests for import_task_created ( #1186 )
2015-01-20 14:51:26 -08:00
Adrian Sampson
8e94419c2a
Fix filefilter ( #1186 ) tests for consistent colons
...
I added this to the pretend output a few commits ago.
2015-01-20 14:34:42 -08:00
Adrian Sampson
0a8dcadb75
Rename regexfilefilter to filefilter ( #1186 )
2015-01-20 14:32:22 -08:00
Adrian Sampson
ebc065ecec
Merge branch 'mried-import-filefilter'
...
Merge of PR #1186 .
2015-01-20 14:22:55 -08:00
Adrian Sampson
ec21fb8af1
Revert #1186 changes to beets core
...
The changes were:
- Return values from events.
- A new `import_task_created` event.
Both were added preemptively to master.
2015-01-20 14:22:43 -08:00
Adrian Sampson
a82f6c2d76
Docs tweaks and changelog for #1237 , fix #1236
2015-01-20 14:10:33 -08:00
Adrian Sampson
38eecb93c9
Merge pull request #1237 from andremiller/master
...
Support for CORS
2015-01-20 14:02:27 -08:00
Andre Miller
5cf869e0f8
Updated web documentation for CORS
2015-01-20 20:52:24 +02:00
Malte Ried
a62a152010
Moved the regular expression file filter into a separate plugin.
2015-01-20 19:50:00 +01:00
Adrian Sampson
293e2512ed
Imported count: sensitive to plugin skips
...
Regression from b7125e4343 pointed out by
@mried.
2015-01-20 09:55:56 -08:00
Andre Miller
f815138758
Combined cors and cors_origin config options into one
2015-01-20 19:53:04 +02:00
Bruno Cauet
d6a4046245
Avoid stacking logger prefixes
2015-01-20 17:34:01 +01:00
Andre Miller
47ea4b7d8b
flake8 formatting updates
2015-01-20 16:06:16 +02:00
Andre Miller
f47be23658
CORS support now uses flask-cor extension
2015-01-20 15:33:33 +02:00
Andre Miller
c8880de52c
Fixes for flake8 validation
2015-01-20 00:38:26 +02:00
Andre Miller
bd63e1e386
Made CORS configurable and changed host default to 127.0.0.1
2015-01-20 00:20:26 +02:00
Frederik “Freso” S. Olesen
4d904e20cf
changelog: Combine the two lastgenre genre addition entries.
...
See https://botbot.me/freenode/beets/msg/29935738/
2015-01-19 18:44:31 +01:00
Frederik “Freso” S. Olesen
cd1564f584
changelog: Move lastgenre genre additions to "Features".
...
See https://botbot.me/freenode/beets/msg/29935738/
2015-01-19 18:42:40 +01:00
Bruno Cauet
b436e75a9e
embedart: fix behaviour on IM unparseable output, add tests
...
Test all EmbedCoverArtPlugin.check_art_similarity() code paths.
Improve #1241 .
2015-01-19 11:50:51 +01:00
Frederik “Freso” S. Olesen
29739dbe04
Move autotag.mb.SEARCH_LIMIT to configuration.
...
Merge branch 'search-limit-in-config'
From pull request #1245 by @Freso.
2015-01-19 11:46:05 +01:00
Frederik “Freso” S. Olesen
20213c8916
Add changelog entry for new musicbrainz.searchlimit option.
2015-01-19 11:44:16 +01:00
Bruno Cauet
d5e3ff2f48
Improve repr(ConfigView): fix class name displayed
...
Use config.__class__.__name__ instead of "ConfigView" in __repr__().
Before:
>>> from beets import ui
>>> c
<ConfigView: root>
>>> c['foo']
<ConfigView: foo>
After:
>>> from beets import ui
>>> c
<LazyConfig: root>
>>> c['foo']
<Subview: foo>
2015-01-19 10:42:00 +01:00
Bruno Cauet
70ef96d565
Make list(ui.config) raise a TypeError
...
As per PEP234 (https://www.python.org/dev/peps/pep-0234/ ) if an object
has __getitem__() but not __iter__() then the former will be used to
build an iterable, invoking it with 0, then 1, ... until a KeyError is
raised. Lazy configuration makes it never happen, and list(config) runs
indefinitely, hogging all memory.
Implement __iter__(), which raises a TypeError, to solve that problem.
2015-01-19 10:35:32 +01:00
Frederik “Freso” S. Olesen
ad00c5dc7b
docs: Fix hyperlink targets.
...
I inserted musicbrainz.searchlimit at the wrong place, breaking the
hyperlink target `match-config` - and I also forgot to add a hyperlink
target for `searchlimit`.
2015-01-19 02:24:32 +01:00
Frederik “Freso” S. Olesen
7c429e8c58
docs: New entry for musicbrainz.searchlimit config option.
2015-01-19 02:19:43 +01:00
Frederik “Freso” S. Olesen
cef0d2cfd7
autotag: Move mb.SEARCH_LIMIT to configuration.
2015-01-19 02:15:27 +01:00
Adrian Sampson
f346853710
embedart: Do not use shell for subprocess
...
This avoids bugs when the filename contains spaces, etc.
Pinging @Kraymer: I gave this a brief test, but can you check whether I messed
anything up more subtly?
Came up when looking at #1241 .
2015-01-18 16:25:23 -08:00
Adrian Sampson
909c96b060
embedart: Handle unparseable IM output ( #1241 )
2015-01-18 16:18:22 -08:00
Adrian Sampson
dc5a79e35c
New import_task_created event
...
Part of #1186 .
2015-01-18 15:37:48 -08:00