Benedikt
87cd387ecc
Merge pull request #4851 from wisp3rwind/pr_rg_refactor_2
...
replaygain: Assorted refactoring
2023-07-23 20:10:16 +02:00
wisp3rwind
3965858ac1
replaygain: apply review feedback: fixup previous refactor, improve tests
...
by adding files which are not completely silent, thus hitting a different
code path in some calculations
The sample files were generated using
> sox -n whitenoise.flac synth 00:00:02 whitenoise
> ffmpeg -i whitenoise.flac whitenoise.opus
> ffmpeg -i whitenoise.flac whitenoise.mp3
2023-07-22 12:47:19 +02:00
wisp3rwind
b8be2af11d
replaygain: in Gst backend, pass paths instead of items around
...
This is a preparation for moving the Gst calculation to multiprocessing
worker threads. Passing only the file paths to the worker threads instead of
synchronizing the entire `Item`s (i.e. minimizing the data that is
shared between the processes) hopefully helps to prevent any issues with
this approach.
2023-07-22 12:47:19 +02:00
wisp3rwind
fa37085493
replaygain: in ffmpeg backend refactor album gain calculation
...
now that we have the `track_results` upfront, some simplifications are
possible
2023-07-22 12:47:19 +02:00
wisp3rwind
76f6c86291
replaygain: in ffmpeg backend, analyse items upfront, then summarize...
...
...album gains. This is in preparation for parallelizing the track
analysis, and computing the album values in the plugin's "main thread"
once all items are done.
2023-07-22 12:47:19 +02:00
wisp3rwind
545ed6f385
replaygain: log album name for album tasks
...
doesn't seem to be very useful to log the _list of items_ here
2023-07-22 12:47:19 +02:00
wisp3rwind
7ec7a0d362
replaygain: avoid hasattr in favor of None values
...
to check for an optional ThreadPool. Seems more idiomatic and readable.
2023-07-22 12:47:19 +02:00
Benedikt
69ce0c7c0a
Merge pull request #4857 from Decad/patch-1
...
Fix link format in README
2023-07-22 00:54:33 +02:00
Declan Cook
ea66725c4a
Fix link
2023-07-21 22:41:57 +01:00
J0J0 Todos
70cbe3c8ff
Quickfix format in ref docs external_ids chapter
2023-07-21 06:59:36 +02:00
Adrian Sampson
efebd72ca9
Merge pull request #4849 from wisp3rwind/pr_add_syspath_3
...
Always use syspath conversions (#3690 split up, part 3)
2023-07-18 13:14:35 -07:00
Benedikt
fc05a85c3b
Merge pull request #4850 from wisp3rwind/pr_add_syspath_4
...
tests: make use of our custom filesystem assertions for conciseness
2023-07-18 22:02:48 +02:00
Adrian Sampson
6c741d5991
Merge pull request #4848 from wisp3rwind/pr_add_syspath_2
...
Always use syspath conversions (#3690 split up, part 2)
2023-07-18 11:27:28 -07:00
Adrian Sampson
7b86f61a56
Merge pull request #4847 from wisp3rwind/dbcore_typing_3
...
typings: Fixes and improvements for dbcore.query
2023-07-18 11:22:36 -07:00
wisp3rwind
9af9eb9b31
tests: make use of our custom filesystem assertions for conciseness
...
this replaces assertions of the form
self.assertTrue(os.path.exists(syspath(path)))
by
self.assertExists(path)
which includes the syspath conversion and is much easier to read.
Occurences where located using
git grep -E 'assert(True|False).*(isdir|isfile|exist)'
2023-07-16 10:42:47 +02:00
wisp3rwind
b58ab909da
add missing syspath conversions (3/3, beets)
2023-07-16 10:42:14 +02:00
wisp3rwind
29c21860a9
add missing syspath conversions (2/3, beetsplug)
2023-07-16 10:17:40 +02:00
wisp3rwind
bffeb9816c
dbcore/query: improve/fix typing
2023-07-15 23:58:05 +02:00
wisp3rwind
7fbf562d24
dbcore: Actually normalize RegexpQuery pattern
...
unintentionally, the pattern normalization added in
1c3a053ce5 was a no-op, and only value
normalization was actually applied (since self.pattern was left
unchanged)
This also helps with typing by ensuring that variables have fixed types
2023-07-15 23:46:51 +02:00
Adrian Sampson
b19b961035
Merge pull request #4842 from arsaboo/deezer
...
Import additional fields from Deezer and add function to update rank
2023-07-14 14:29:44 -07:00
Alok Saboo
ef8a780e1c
Add error handling for invalid Deezer track_id
2023-07-13 09:53:41 -04:00
Alok Saboo
a4bde2af8b
Add changelog entry for bugfix
2023-07-12 20:13:10 -04:00
Alok Saboo
272d01103c
Update docs/changelog.rst
...
Co-authored-by: Adrian Sampson <adrian@radbox.org>
2023-07-12 16:15:08 -04:00
Alok Saboo
63122da24d
remove unused imports
2023-07-10 15:55:42 -04:00
Alok Saboo
c00cdd3cc7
Error handling
2023-07-10 15:52:36 -04:00
Alok Saboo
acd604f102
Update deezer.py
2023-07-10 15:39:28 -04:00
Alok Saboo
a027612216
error handling
2023-07-10 15:34:06 -04:00
Alok Saboo
014d41f208
Error handling
2023-07-10 15:30:20 -04:00
Alok Saboo
edda4a588d
Add changelog and docs
2023-07-10 08:32:29 -04:00
Alok Saboo
6460e4d829
added deezer_updated to keep track of update time
2023-07-09 19:06:04 -04:00
Alok Saboo
a291ec3f0b
convert urs to f-string format
2023-07-09 18:43:35 -04:00
Alok Saboo
783ea2a444
Add function to update Deezer rank
2023-07-09 18:39:15 -04:00
Alok Saboo
cdfebdba8e
Update deezer.py
2023-07-09 18:02:11 -04:00
Alok Saboo
5419a78bd2
Added additional fields to be imported from Deezer
2023-07-09 17:59:50 -04:00
Adrian Sampson
9481402b3c
Merge pull request #4839 from Scrumplex/fix-compare-colorspaces
...
Define colorspaces for imagemagick comparison
2023-07-05 09:57:13 -07:00
Adrian Sampson
17b341abea
Wrap a long line
2023-07-05 09:46:17 -07:00
Sefa Eyeoglu
11c13a8ea0
Add imagick 7.1.1-12 support to changelog
...
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-07-05 18:33:08 +02:00
Sefa Eyeoglu
a873a191b9
Define colorspaces for imagemagick comparison
...
ImageMagick 7.1.1-12 changed the default colorspaces used by the PHASH
compare function from sRGB,HCLp to xyY,HSB. This breaks the current code
for comparisons, so let's define the colorspaces ourselves.
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2023-07-05 18:32:34 +02:00
J0J0 Todos
dac9712240
Merge pull request #4812 from arsaboo/comment
2023-07-03 22:16:00 +02:00
Alok Saboo
4c8b13560f
Updated comment
2023-07-03 16:03:38 -04:00
Adrian Sampson
5bc0786f51
Merge pull request #4834 from Bobo1239/master
...
Handle missing release-relation-list field during pseudo-release lookup
2023-07-03 10:32:59 -07:00
Boris-Chengbiao Zhou
dcaac12860
Handle missing release-relation-list field during pseudo-release lookup
...
Some pseudo-releases (erroneously) lack the relation to the actual
release which previously would've caused a crash.
2023-06-29 23:39:19 +02:00
Adrian Sampson
99f641c3bb
Merge pull request #4833 from jamesharding/jamesharding-pseudo-release-patch
...
Fixed check for pseudo-release.
2023-06-29 08:37:53 -07:00
James Harding
ed2d4fd9c8
Fixed check for pseudo-release.
...
The 'status' field is potentially null, and in this case the dictionary key it is not returned by the API. Using get will return null in this case. Tested locally and this solves the issue!
2023-06-29 05:11:57 +01:00
Adrian Sampson
ade730d331
Merge pull request #4831 from TheLastZombie/add-more-plugin
...
Add beets-more to community plugins
2023-06-28 08:07:17 -07:00
Sunny
edd4f9a4f5
Point URL to specific plugin
2023-06-27 15:33:11 +02:00
Sunny
76932962f8
Add beets-more to community plugins
2023-06-27 10:25:26 +02:00
Adrian Sampson
16a30f4d74
Merge pull request #4714 from TypicalFence/gh-654
...
resolve transl-tracklisting relations for pseudo releases
2023-06-26 14:40:28 -07:00
fence
3f31876b33
add change log entry
2023-06-26 21:21:48 +02:00
fence
260aff7e48
fix lint
2023-06-26 21:17:48 +02:00