Commit graph

3099 commits

Author SHA1 Message Date
Thomas Scholtes
81f53fb0d2 Add basic cli tests for replaygain 2014-04-04 19:44:16 +02:00
Yevgeny Bezman
cf49d88156 replaygain: clarified the need to strange thread initialization| 2014-04-04 20:20:14 +03:00
Yevgeny Bezman
d8c37d6ca3 replaygain: Added a FatalReplayGainError class to signal the plugin that the backend failed completely 2014-04-04 19:17:41 +02:00
Thomas Scholtes
a5bdbdcf7f Move available backends to class level
See also https://github.com/sampsyo/beets/issues/650
2014-04-04 19:17:41 +02:00
Thomas Scholtes
439fc1938f Remove debug print statements 2014-04-04 19:17:41 +02:00
Thomas Scholtes
89680d835a Refine docstrings and fix style issues (flake8) 2014-04-04 19:17:41 +02:00
Yevgeny Bezman
6aa1cc95cb replaygain: Improved error handling 2014-04-04 19:17:41 +02:00
Yevgeny Bezman
2d9f40d62d replaygain: fixed small errors introduced by previous refactor. Commented the code in key parts. 2014-04-04 19:17:41 +02:00
Yevgeny Bezman
71a447fac1 replaygain: Update documentation to include some info regarding the GStreamer backend 2014-04-04 19:17:41 +02:00
Adrian Sampson
08b2bff28d eliminate GStreamer globals and initialize_config 2014-04-04 19:17:41 +02:00
Adrian Sampson
2369122075 minor Python style; move namedtuples to module 2014-04-04 19:17:41 +02:00
Yevgeny Bezman
d2c6d00b7b replaygain: Added some informative prints, removed hardcoded debug print 2014-04-04 19:17:40 +02:00
Yevgeny Bezman
9581b91e10 replaygain: Added gstreamer support, fixed some small bugs 2014-04-04 19:17:40 +02:00
Yevgeny Bezman
86ee30df0d replaygain: modified current implementation to fit a backend framework in anticipation of other implementations 2014-04-04 19:17:40 +02:00
Thomas Scholtes
ee2cf0df8e Plugins can't extend MediaFile anymore
Backported from #607.
See https://github.com/sampsyo/beets/pull/607#issuecomment-38387100

This will be return in #644.
2014-04-04 14:28:47 +02:00
geigerzaehler
1d815b3734 Merge pull request #651 from sahandKashani/patch-1
bash completion documentation fix for GNU Bash-4.2
2014-04-04 11:45:51 +02:00
sahandKashani
3d675b2339 bash completion documentation fix for GNU Bash-4.2
In GNU Bash-4.2, I have to put quotes around the eval statement for the shell to correctly interpret the output of the beet completion command.
2014-04-04 09:28:53 +02:00
Adrian Sampson
b1ae7cb692 whitespace fixes in util 2014-04-03 19:56:59 -07:00
Adrian Sampson
4e2b35f372 avoid use of deprecated os.popen 2014-04-03 19:54:15 -07:00
Adrian Sampson
c5174b3881 use command_output utility in echonest
That's the last direct use of the subprocess calls.
2014-04-03 19:51:50 -07:00
Adrian Sampson
d407db725f convert: catch OSErrors and display error message
This also adds close_fds (only available on Unixes) to the common subprocess
invocation utility.
2014-04-03 19:47:21 -07:00
Adrian Sampson
ac99622ec7 Merge branch 'single-files'
Conflicts:
	docs/changelog.rst
2014-04-03 13:20:53 -07:00
Adrian Sampson
7f9e301428 fix tests for cached weights loading 2014-04-03 13:17:38 -07:00
Thomas Scholtes
2011156f8b Add test case for single file import 2014-04-03 22:13:31 +02:00
Adrian Sampson
b814168fb6 Merge branch 'master' of github.com:sampsyo/beets 2014-04-03 13:01:05 -07:00
Adrian Sampson
729e001432 benchmark: customizable album ID 2014-04-03 13:00:20 -07:00
Thomas Scholtes
eaab0bcc6e Enable coverage with tox -e py27 2014-04-03 21:46:54 +02:00
Adrian Sampson
3372fd3066 avoid unnecessarily reloading weights (#609)
In my profiling runs, this was taking 80% of the matching time to recompute
exactly the same dict over and over. Worth optimizing.

`beet bench_match` went from 80 seconds to 17 seconds on my machine with this
change.
2014-04-03 12:13:29 -07:00
Adrian Sampson
9285f669e9 style fixes in match.py 2014-04-03 11:58:00 -07:00
Adrian Sampson
cd57c8da7f benchmarking for slow matches
Investigating #609. The culprit seems to be repeated reading of the config's
weight settings.
2014-04-03 11:56:26 -07:00
Adrian Sampson
d116e03bed ensure lists of paths are passed to ImportTask
Also change the variable name from `path` to `paths` to reflect this.
2014-04-02 21:57:30 -07:00
Adrian Sampson
c6abfa57c7 docs: link to beets-check plugin 2014-04-02 21:20:03 -07:00
Adrian Sampson
b683f239f0 some style tweaks for #638 2014-04-02 21:18:41 -07:00
Adrian Sampson
0c049f2e5c tox: restore pypy/py26 configs, sphinx -q (#643) 2014-04-02 20:47:04 -07:00
Adrian Sampson
c4be9c273f Merge pull request #643 from geigerzaehler/tox-flake8-travis
Use tox to test on travis and add docs and flake8
2014-04-02 20:39:22 -07:00
Adrian Sampson
c9141a6adf import single files and one-track albums
An alternate proposal for what's being discussed in #640.
2014-04-02 17:14:48 -07:00
Thomas Scholtes
9fab6e7ca3 Use coverage only with py27 2014-04-03 01:52:21 +02:00
Thomas Scholtes
8488f665fc Add sphinx dependency to tox virtual environment 2014-04-03 01:41:18 +02:00
Thomas Scholtes
7927146f12 We need sphinx before installing the tox environment 2014-04-03 00:58:57 +02:00
Thomas Scholtes
2ff7735f89 Sphinx is required to build the package 2014-04-02 23:49:35 +02:00
Thomas Scholtes
fdd2849fec Ignore generated man pages 2014-04-02 22:56:24 +02:00
Thomas Scholtes
bee80c4c49 Use tox to test on travis and add docs and flake8
Travis CI now also confirm that the docs build correctly and the flake8 runs
succesfully. Tox also has the advantage that it tests that beets installs
correctly.

Currently flake8 does not run succesfully so it is configured to not fail the
build on Travis.
2014-04-02 22:48:53 +02:00
Thomas Scholtes
100b3d4d65 Make mediafile tests independent of image order
For MP3s mutagen stores image tags in a hash with the `APIC:...` key. The order
of the images is therefore not well defined. A similar issue occurs with WMAs.
2014-04-02 22:15:00 +02:00
brilnius
d02e02fe20 Merge pull request #638 from brilnius/ui_del_attr2
Modify command: ability to delete/reset an attribute (beet modify field!)
2014-04-01 22:47:03 +02:00
Bruno Tournay
cd70e92b7f Modify command: ability to delete/reset an attribute (beet modify field!) 2014-04-01 22:38:33 +02:00
Adrian Sampson
0118ef336d Merge pull request #636 from skeuomorf/notifications
Add irc notifications by travis
2014-04-01 11:01:01 -07:00
Adrian Sampson
1f5717ca97 Merge pull request #635 from skeuomorf/badges
Add badges of travis and coverage to README
2014-04-01 11:00:27 -07:00
Mohammed Attia
0ef5ce2847 Add irc notifications by travis 2014-04-01 08:18:05 +02:00
Mohammed Attia
975e010e18 Add badges of travis and coverage to README 2014-04-01 08:12:08 +02:00
Adrian Sampson
8d196a8c01 changelog for #632 2014-03-26 13:39:12 -07:00