Adrian Sampson
80bfd186ae
Use should_write for modify, update, and mbsync
...
This should address the surprising situation in #1697 , where `import` went
fine but then `update` unexpectedly changed filenames.
2015-11-07 13:34:47 -08:00
Adrian Sampson
d78ee1cf28
Add a corresponding should_move wrapper
2015-11-07 13:26:21 -08:00
Adrian Sampson
9f7aa866bd
Use ui.should_write everywhere
...
There sure are a lot of plugins that want to write metadata!
2015-11-07 13:20:09 -08:00
Adrian Sampson
5b761f029e
A new should_write configuration wrapper
...
The idea is that it is so common to check whether we need to write tags (or
move files), and we're constantly re-implementing the same logic everywhere.
It's not even the prettiest logic, as it commingles the importer settings with
general settings. So it's important that we encapsulate the decision so we can
make it better in the future.
2015-11-07 13:14:33 -08:00
Adrian Sampson
cb6edb46ef
Use ` instead of * for plugin event names
2015-11-07 12:12:48 -08:00
Adrian Sampson
4e20ddcef9
Doc refinements for #1499
2015-11-07 12:11:05 -08:00
Adrian Sampson
4baf9eba56
Move changelog entry for #1499
2015-11-07 12:07:17 -08:00
Adrian Sampson
b2512b3271
Merge pull request #1499 from m-urban/tag-change-hook
...
#872 : Tag change hooks
2015-11-07 12:06:17 -08:00
Manfred Urban
6e980a977e
Reverted to original approach
2015-11-07 19:28:34 +01:00
Manfred Urban
d8851b97b8
Fixed Travis errors
2015-11-07 17:59:25 +01:00
Manfred Urban
b2efd60162
Needed to find new spot to emit events because hooks.*_for_id -methods are only called when searching for explicit IDs
2015-11-07 17:51:44 +01:00
Manfred Urban
e9ddb92c2d
- Simplified code
...
- Fixed wrong event being emitted
2015-11-07 15:37:12 +01:00
Adrian Sampson
1f6a26d2b4
Spruce up the docs for #1692
2015-11-06 13:04:06 -08:00
Adrian Sampson
7413e17782
Merge pull request #1692 from kooimens/patch-2
...
Discogs: change album artist to musicbrainz naming
2015-11-06 13:01:23 -08:00
kooimens
1150f65ee3
Update changelog.rst
2015-11-06 20:01:56 +01:00
kooimens
7d02d7da29
Update changelog.rst
2015-11-06 20:00:36 +01:00
kooimens
c204795153
Update changelog
2015-11-06 19:56:19 +01:00
kooimens
b11533b98f
Update discogs docs
2015-11-06 19:45:05 +01:00
kooimens
414ae131a5
Fix style error
2015-11-06 19:27:36 +01:00
Fabrice Laporte
d84c776dc1
list options in alphabetic order
2015-11-06 13:44:38 +01:00
Adrian Sampson
33d3ebf53f
Link to a 3rd-party plugin: beets-usertag ( #1694 )
2015-11-05 18:31:16 -08:00
Manfred Urban
17b38a6be8
Minor layout fixes to documentation
2015-11-05 16:43:28 +01:00
Manfred Urban
5e4c41ffe8
Clarified documentation
2015-11-05 16:37:35 +01:00
Manfred Urban
ae0babb17e
Less duplicated text in documentation
2015-11-05 16:17:19 +01:00
Manfred Urban
1708939f99
- Added hooks to manipulate fetched album and track info
...
- Integrated support for plugins
- Added documentation
- Updated changelog
2015-11-05 15:17:58 +01:00
kooimens
da0360bd90
Update discogs.py
2015-11-05 14:50:40 +01:00
Adrian Sampson
7d52fa72ae
Fix #1699 : Outdated API call
...
get_fields() was removed in 5420599839
2015-11-04 20:25:17 -08:00
Adrian Sampson
19cf37263d
Fix #1700 : Tolerate missing Location in iTunes
2015-11-04 20:11:58 -08:00
Adrian Sampson
be49955884
metasync: More precise exception catching ( #1700 )
2015-11-04 20:07:49 -08:00
reiv
a7952b1b1d
Merge pull request #1681 from sampsyo/314-reimport-art
...
Fix #314 : Delete old album art during re-import
2015-11-04 18:46:45 +01:00
reiv
81a72f74c9
Merge branch 'master' into 314-reimport-art
2015-11-04 18:37:06 +01:00
reiv
e32dda78b8
Changelog for #1681
2015-11-04 18:33:52 +01:00
reiv
0ebc4c799d
fetchart: in auto, ignore albums with art
...
When re-importing an album, we don't want fetchart to interfere
with any existing album art.
2015-11-04 15:08:42 +01:00
Adrian Sampson
a735a6b4a2
discogs: Better exception logging
...
Might have helped diagnose #1669 more easily.
2015-11-03 22:38:31 -08:00
Adrian Sampson
023a33ca31
Revert "Fix #1656 , maybe: encode Discogs token strings"
...
This reverts commit f784cd1a22
2015-11-03 22:29:33 -08:00
reiv
314dd0e6bc
Update re-import test to leave no orphaned art
...
Make sure that when an album is re-imported and its files are
moved, the artwork isn't left behind in the old folder.
2015-11-03 23:10:01 +01:00
reiv
32934bd16a
Preserve album art on re-import ( fixes #314 )
...
Copy the replaced album's artpath attribute to the new album. This
causes the image file to be moved along with the music files.
2015-11-03 22:43:05 +01:00
reiv
21f926fb89
Add test for #314
...
Ensure that album art is preserved when an album is re-imported.
2015-11-03 22:38:13 +01:00
kooimens
2293e1e09d
Discogs: option to change 'various' album artist to 'Various Artists' (Musicbrainz naming)
...
Just a simple config option to change 'various' album artist to the one that MusicBrainz uses: Various Artists.
2015-11-03 20:03:24 +01:00
reiv
33ea9f1c10
Revert all changes on this branch thus far
...
Revert "PEP8 amendments"
This reverts commit 413fe6bbfd629a80a1d1
2015-11-03 11:33:35 +01:00
Adrian Sampson
38edb18a74
Merge pull request #1683 from sampsyo/1264-unnecessary-resize
...
Fix #1264 : Avoid unnecessary art resizes
2015-11-02 22:39:06 -08:00
reiv
1625dfc17e
Merge branch 'master' into 1264-unnecessary-resize
2015-11-03 02:46:33 +01:00
reiv
5d0048c03d
Changelog for #1683
2015-11-03 02:38:02 +01:00
reiv
19dcc25a93
fetchart: Improve validation of image dimensions
...
This avoids images being resized unnecessarily if the dimensions
are correct.
2015-11-03 02:19:47 +01:00
reiv
93009911e0
fetchart: Add test for image resizing
...
This test ensures that images are resized if and only if they are
wider than the maxwidth setting.
2015-11-03 02:17:21 +01:00
Adrian Sampson
bfa2fbf6af
Changelog for #1675
2015-11-02 16:46:32 -08:00
Adrian Sampson
d79d11fb15
Docstring and rewrap for #1675
2015-11-02 16:45:45 -08:00
Adrian Sampson
e84414c822
Fix syntax (and unused variable) in #1675
2015-11-02 16:44:02 -08:00
Adrian Sampson
efcea9a57f
Merge pull request #1675 from kooimens/patch-1
...
Embedart: remove_art_file on import
2015-11-02 16:42:59 -08:00
kooimens
bcef3a7123
Create function remove_artfile
...
Damn it, that was really hard for me:D. First time seriously using python. Please review it carefuly.
2015-11-02 23:56:38 +01:00
