Commit graph

3971 commits

Author SHA1 Message Date
Stig Inge Lea Bjørnsen
6f9abf4340 Merge pull request #925 from silb/bug-911-importadded-reimport
Fixes bug #911
2014-10-11 15:53:03 +02:00
Stig Inge Lea Bjørnsen
79a9593cb9 Add quoting and use displayable paths in log messages 2014-10-10 22:52:54 +02:00
Adrian Sampson
67b7b87d82 Fix #1001: plugin conflict error message printing 2014-10-10 10:55:40 -07:00
Adrian Sampson
dfb7cc25f5 Merge pull request #996 from benlumley/patch-1
Trivial typo fix
2014-10-10 09:32:59 -07:00
Ben Lumley
10d05a32be Trivial typo fix 2014-10-10 09:57:32 +01:00
Fabrice L.
e6bf8c21d8 Merge pull request #992 from KraYmer/lyrics-coverage
Improve lyrics coverage
2014-10-09 22:11:28 +02:00
Adrian Sampson
c5293df963 replaygain: More descriptive backend errors
This avoids a bare `except:` to catch specific errors and give better messages
when they fail. Should provide more insight to this trouble:
https://groups.google.com/d/msg/beets-users/6d-TOg0SuPY/iL39tmo3rqUJ

Also related to #874.

Feedback from @yevgenybezman or others more familiar with the backend would be
welcome.
2014-10-09 12:26:53 -07:00
Adrian Sampson
983aac287b Add a displayable_path call in embedart (fix #995) 2014-10-09 11:13:39 -07:00
Fabrice Laporte
4386d9d4df skip test involving bs4 if python version too low 2014-10-09 08:23:20 +02:00
Fabrice Laporte
a6f0649c40 return no lyrics when HtmlParseError occured 2014-10-09 08:22:51 +02:00
Fabrice L.
18ee57085d Merge pull request #993 from KraYmer/lastgenre_coverage
Lastgenre coverage (mocking galore)
2014-10-09 06:54:26 +02:00
Fabrice Laporte
b32838b519 fix flake8 2014-10-09 06:47:23 +02:00
Fabrice Laporte
2b908b48bc lastgenre: use an ordinary Item instead of a Mock 2014-10-09 06:38:40 +02:00
Fabrice Laporte
b95990ee9c lastgenre: add unit tests 2014-10-09 00:00:26 +02:00
Fabrice Laporte
546d17f52f fix flake8 2014-10-08 20:55:00 +02:00
Fabrice Laporte
4600727e17 fix building of lyrics file paths 2014-10-08 20:32:30 +02:00
Fabrice Laporte
edbbadaf4f add test to check lyrics title match in url title 2014-10-08 14:49:59 +02:00
Fabrice Laporte
c0c474b20f lyrics: strip title excerpt before matching
improve the extraction of lyrics title from url title and increase the
matching threshold as a consequence.
2014-10-08 14:49:09 +02:00
Fabrice Laporte
9992d65366 test_lyrics: add onelyrics.net source 2014-10-08 14:44:43 +02:00
Fabrice Laporte
f122e2a966 add bs4 dependency
and reorder reps list alphabetically for readability
2014-10-08 14:43:55 +02:00
Fabrice L.
cf6a15df95 revert 0f5c2a4 2014-10-08 14:27:13 +02:00
Fabrice L.
0f5c2a41b2 tox: add bs4 dependency
bs4 is required by few test_lyrics.py tests
2014-10-08 13:34:05 +02:00
Stig Inge Lea Bjørnsen
3bd3a817de Comply with PEP8. 2014-10-07 22:05:44 +02:00
Stig Inge Lea Bjørnsen
125f6422d7 Bug #911 reimport detection for the importadded plugin
Reimports are now detected by inspecting the fields for reimported items
and replaced albums in ImportTask.

Reimported albums and items are skipped.
2014-10-07 21:05:43 +02:00
Fabrice L.
abe7a2cd20 Update embedart.rst 2014-10-05 21:22:22 +02:00
Adrian Sampson
2b1353a4f1 Malformed date queries no longer crash 2014-10-04 16:50:50 -07:00
Adrian Sampson
44ff3f782a Remove prefix diff highlighting
This was well-intentioned but ended up being more confusing than it was worth.
It's always confused me when one digit gets un-highlighted in one of these
displays. The straw that broke the camel's back was when I got a "#1 -> #16"
change where the numeral "1" was un-highlighted. To fix this right would be
way more trouble than it's worth; I'm glad to be rid of this detail.

Conflicts:
	docs/changelog.rst
2014-10-04 16:47:00 -07:00
Lucas Duailibe
9b03c46702 play: removing tmp file (changelog) 2014-10-04 14:50:17 -03:00
Lucas Duailibe
17dbf2a22d play: remove temporary m3u file 2014-10-03 12:49:06 -03:00
Adrian Sampson
ae09f14615 Changelog for #985 2014-09-30 11:30:45 -07:00
Adrian Sampson
5c2ca2ba59 Merge pull request #985 from IndiGit/master
added bpd option for initial volume setting
2014-09-30 11:28:01 -07:00
Ralf Sieger
2ead4d352a Added documentation about the new volume option 2014-09-30 19:14:33 +02:00
Ralf Sieger
ab5c5dcfd5 added option for initial volume setting 2014-09-30 09:34:04 +02:00
Adrian Sampson
6348164e9a Merge pull request #984 from sampsyo/reimport-metadata
Re-imports: preserve added dates and flexible attributes
2014-09-29 10:32:18 -07:00
Adrian Sampson
f88a960a63 Changelog for #984
[ci skip]
2014-09-28 11:50:05 -07:00
Adrian Sampson
06b4730105 Re-import tests: stub out *_for_id functions
Currently, these just return no results. (For our testing purposes, the
matches we get from the ordinary metadata search suffice just fine.)
2014-09-28 11:39:04 -07:00
Adrian Sampson
e69ee5136a Fix "X of Y items replaced" log message
This was erroneous before: it always said "N of N" due to the presence of
empty lists.
2014-09-28 11:22:27 -07:00
Adrian Sampson
a3eef35ba8 Test singleton re-imports 2014-09-28 11:16:38 -07:00
Adrian Sampson
f367a0971c Re-import test: check item-level data preserved 2014-09-28 11:04:25 -07:00
Adrian Sampson
e8d2ade167 Basic re-import tests 2014-09-28 10:58:43 -07:00
Adrian Sampson
d13d6ed1c1 Modernize logging
Unicode strings, .format() templating, and displayable_path sanitation. Really
makes me wish for automatic formatting stuff in the logger...
2014-09-28 10:31:23 -07:00
Adrian Sampson
0bbf027a4d Standardize docstring style 2014-09-28 10:22:31 -07:00
Adrian Sampson
1ce3b9b064 Merge branch 'master' into reimport-metadata
Conflicts:
	beets/importer.py
2014-09-28 10:21:44 -07:00
Adrian Sampson
582dbf6b34 Fix ArtResizer.local property (fix #983) 2014-09-27 11:29:38 -07:00
Adrian Sampson
a29b5fd750 Slight docs rewording 2014-09-27 11:24:52 -07:00
Stig Inge Lea Bjørnsen
62f63e5c32 Comply with PEP8. 2014-09-27 18:47:42 +02:00
Stig Inge Lea Bjørnsen
020e8e27d8 Fix for import and reimport of singleton items. 2014-09-27 18:19:04 +02:00
Stig Inge Lea Bjørnsen
6eb4afb35f Remove unnecessary database queries during reimport. 2014-09-27 18:11:49 +02:00
Fabrice L.
54c9761135 Merge pull request #981 from KraYmer/lyrics-enh
Lyrics scraping code refactored
2014-09-27 11:25:06 +02:00
Fabrice L.
d2db6ae88b Update embedart.rst
add info about threshold for similarity
2014-09-27 11:23:46 +02:00