Adrian Sampson
6ab7ad22de
Improve changelog for #2549 , which fixes #2548
2017-05-04 09:35:19 -04:00
Adrian Sampson
faf8be089b
Merge pull request #2549 from Kraymer/drop-lyrics-com
...
Drop lyrics.com backend
2017-05-04 09:34:48 -04:00
Adrian Sampson
376c31a2a4
Changelog for #2542 , which fixes #2532
2017-05-04 09:30:54 -04:00
Adrian Sampson
b57c49d738
Add a period to a comment, simplify one expression
...
w.r.t. #2542
2017-05-04 09:29:27 -04:00
Adrian Sampson
908b8dca97
Merge pull request #2542 from ocelotsloth/2532-web-serializer-bytes
...
web: #2532 - Decode bytes values to strings
2017-05-04 09:20:38 -04:00
Fabrice Laporte
6fa1651d99
Update changelog
2017-05-03 23:06:43 +02:00
Fabrice Laporte
409f070970
Remove lyrics.com source
2017-05-03 22:54:09 +02:00
Mark Stenglein
22f07b91e9
web: __init__: _rep: Make the looping more pythonic
...
As suggested, changes around the for loop to make it a bit more
pythonic by using an if loop inside a normal for loop.
Signed-off-by: Mark Stenglein <mark@stengle.in>
2017-05-03 16:36:40 -04:00
Mark Stenglein
9394e0ac63
web: __init__: _rep: change to base64 encoding
...
As suggested, this commit adds base64 encoding for the bytes
encoding.
Signed-off-by: Mark Stenglein <mark@stengle.in>
2017-05-03 16:34:30 -04:00
Fabrice Laporte
e7ea7ab5f2
Update fetchart.rst
2017-05-03 20:04:02 +02:00
Fabrice Laporte
ce485781f3
Merge pull request #2540 from owcz/patch-1
...
Remove mention of python-itunes
2017-05-03 20:02:49 +02:00
Fabrice Laporte
fc6b65d592
Merge pull request #2538 from Kraymer/lyrics-test
...
Tests to track whether lyrics websites are correctly fetched
2017-05-03 20:02:03 +02:00
Fabrice Laporte
8f32bfed82
Reactivate test of LyricsCom and MusiXmatch sources
2017-05-03 07:42:50 +02:00
Wolf
8b4b64d734
Changelog for #2540
2017-05-03 00:48:52 -04:00
Mark Stenglein
471d46d67e
web: __init__: _rep: Filter all bytes for serializer
...
This commit fixes issue #2532 by filtering out any byte values
added by any other extensions and decoding them to strings for the
JSON serializer.
It does not remove any of the keys, instead opting to just convert
them.
Signed-off-by: Mark Stenglein <mark@stengle.in>
2017-05-03 00:03:05 -04:00
Wolf
49e548bdbc
Remove mention of python-itunes
...
The plugin is inactive and has been broken for months: https://github.com/beetbox/beets/issues/2371
Fixes https://github.com/beetbox/beets/issues/1610
2017-05-02 22:36:26 -04:00
Fabrice Laporte
f53ab801b8
Add indent
2017-05-03 00:11:26 +02:00
Fabrice Laporte
b3fbdbae5a
Fix flake8
2017-05-03 00:02:09 +02:00
Fabrice Laporte
7dab9f339e
Restore beets module import
2017-05-02 23:48:20 +02:00
Fabrice Laporte
07af27e44b
Lyrics are last paragraph with class 'mxm-lyrics__content'
...
Remove ‘data-reactid’ from marker.
2017-05-02 23:40:25 +02:00
Fabrice Laporte
3e38a33c4a
Fix PEP8
2017-05-02 23:37:20 +02:00
Fabrice Laporte
11eb90c758
Fix PEP8
2017-05-02 07:46:51 +02:00
Fabrice Laporte
3e3ad6974c
Fix PEP8
2017-05-02 07:30:40 +02:00
Fabrice Laporte
fa9262d61b
Disable tests that do real requests to lyrics sites by default.
...
Set BEETS_TEST_LYRICS_SOURCES environment variable to '1' to not skip the
tests.
2017-05-02 01:05:18 +02:00
Fabrice Laporte
d88cabc846
Divide LyricsGooglePluginTest into two classes.
...
Move existing tests into LyricsGooglePluginMachineryTest.
Create LyricsPluginSourcesTest class to check fetching of each source.
Some code was supposed to do that until now but was never executed as we
exited early at the "if not check_lyrics_fetched():" check.
2017-05-02 01:03:26 +02:00
Fabrice Laporte
a85dcd88c4
Store whole expected lyrics, not just keywords, but randomized
2017-05-02 00:56:56 +02:00
Fabrice Laporte
4e0527f07d
Docstrings style
2017-05-02 00:54:58 +02:00
Fabrice Laporte
f8862ac0ea
Sort imports
2017-05-02 00:52:07 +02:00
Fabrice Laporte
a165d6c00b
Fix MusiXmatch text extraction markers
2017-05-01 23:40:09 +02:00
Adrian Sampson
84febb13c1
Merge pull request #2523 from discopatrick/rename-error
...
Rename error
2017-05-01 15:29:21 -04:00
Fabrice Laporte
2bf58a61c3
Decode string with Unicode escape
2017-04-30 23:14:23 +02:00
Adrian Sampson
8e78cfdac7
Always pass unicode to print_
...
Introduced in #2495 .
2017-04-29 21:13:34 -04:00
Adrian Sampson
dd7b129e21
Turn off unnecessary execute bit
2017-04-29 18:29:47 -04:00
Adrian Sampson
e9c3d69e59
Fix a typo
2017-04-29 18:29:36 -04:00
Jack Wilsdon
f622e42a88
Replace blind excepts with generic Exception excepts in tests
2017-04-29 00:12:14 +02:00
wordofglass
287e077709
Remove blind excepts from bluelet.py
2017-04-29 00:05:28 +02:00
wordofglass
bb5629ea1d
Remove untyped except statements
2017-04-29 00:05:20 +02:00
Jack Wilsdon
ac06be1a5a
Add flake8 check for blind excepts
...
Add flake8 check for blind excepts using flake8-blind-except (B901).
2017-04-29 00:03:45 +02:00
Nathan Dwek
68089ac8e9
Merge pull request #2524 from beetbox/command-output-close-stdin
...
Close stdin when performing `command_output()`
2017-04-24 20:31:04 +02:00
Adrian Sampson
2c71092eaa
Merge pull request #2526 from jwilk/errno
...
Don't hardcode errno constant
2017-04-23 23:14:34 -04:00
Jakub Wilk
95a868bb50
Don't hardcode errno constant
...
The value of ENOENT is architecture-dependent, so don't assume
it's always 2.
2017-04-23 23:28:32 +02:00
discopatrick
d24b373c87
Adjust indentation to pass flake8 tests
2017-04-22 18:23:33 +01:00
discopatrick
63cd799e8d
Raise the correct error type
...
The incorrect error type was reintroduced in the previous merge commit.
2017-04-22 18:13:26 +01:00
discopatrick
bd48559b0a
Merge branch 'master' into rename-error
...
# Conflicts:
# beets/dbcore/query.py
2017-04-22 18:13:03 +01:00
discopatrick
58417526cb
Rename InvalidQueryArgumentTypeError to InvalidQueryArgumentValueError
...
The way we use `InvalidQueryArgumentTypeError` is more akin to a `ValueError` than a `TypeError`. For example, we try to parse a string as an int, float, or date, but the parsing fails - there was nothing wrong with the type of the variable (string), but its contents were not parseable into the type we wanted - there was a problem with the value of the string.
2017-04-22 18:07:30 +01:00
nath@home
b38f34b2c0
command_output: insure py2/3 compat
...
This should make #2524 pass
2017-04-22 15:52:09 +02:00
nath@home
7a08e4a978
Changelog for 2524
2017-04-22 15:07:28 +02:00
nath@home
7a3c786215
command-output: Wire subproc stdin to /dev/null
...
This should fix 2488, where beet convert would prevent further
inputs.
2017-04-22 15:01:31 +02:00
Adrian Sampson
80f77aea4d
Merge pull request #2522 from discopatrick/date-value-field-validation-method
...
Date value field validation method
2017-04-21 08:48:52 -04:00
discopatrick
4dbc4134b3
consolidates the declaration and incrementing of ordinal into one line
2017-04-21 12:55:44 +01:00
