Commit graph

6487 commits

Author SHA1 Message Date
Adrian Sampson
5a94cfe5d6 Merge pull request #209 from duailibe/convert
Adding functionality to convert plugin: keep newly converted files
2013-03-06 17:33:25 -08:00
Lucas Duailibe
a338b95bb7 Changing behavior in "keep new files" 2013-03-06 22:04:05 -03:00
Lucas Duailibe
28522376be Adding "keep new files" option to convert plugin 2013-03-06 21:41:40 -03:00
Adrian Sampson
b0ae4d2fbd Merge pull request #205 from duailibe/patch-2
Correcting typo in writing.rst
2013-03-06 15:41:27 -08:00
steini
410bdf6ddd Code for reading attributes from concatenated flex columns into dicts moved to an outside methods to make it usable for both BaseAlbum and Item objects. 2013-03-06 23:25:31 +00:00
Lucas Duailibe
5a8880e86f Correcting typo in writing.rst
Simple typo: "fishes" -> "finishes"
2013-03-06 19:59:08 -03:00
steini
7d1f67881e ironing out some kinks 2013-03-06 18:29:22 +00:00
steini
8e342a16a1 Fixed up a couple of query classes for flex attr support. 2013-03-06 14:38:17 +00:00
steini
fbd85ef6ba Started hacking CollectionQuery to search flexible attribute fields. 2013-03-05 05:20:03 +00:00
Fabrice Laporte
72a06e96d0 Merge branch 'master' of https://github.com/sampsyo/beets 2013-03-04 08:38:09 +01:00
steini
f5d658c58f An attempt at flexible attributes with plugin namespaces.
Mostly untested.
2013-03-04 05:55:43 +00:00
Adrian Sampson
1a7ec6dc79 mbsync: fix redundant album art movement
Since we explicitly move album art later in the process, implicitly moving it
with items can cause a double-move (and thus a "file not found" error).
2013-03-03 17:46:16 -08:00
Adrian Sampson
18688008a4 mbsync: avoid spurious stores/moves
As _print_and_apply_changes itself does for items, we now shortcut
modifications (metadata and filesystem) for albums when no changes are
required for a given album. This avoids effectively doing a "beet move" on an
album even when nothing has changed.
2013-03-03 17:19:05 -08:00
Adrian Sampson
5f68d03793 mbsync: don't write tags if import.write is off
This will avoid surprising users with import.write turned off.
2013-03-03 17:13:54 -08:00
Adrian Sampson
72263a1cf7 mbsync: use ID lookups instead of full match logic
This change uses _album_for_id and _track_for_id instead of the full
autotag.match.* functions. This should be faster (requiring fewer calls to the
MusicBrainz API) while also being more predictable. It also won't, for
example, use acoustic fingerprinting even if the chroma plugin is installed.

Finally, this change catches the error case in which MBIDs are erroneous. This
can happen, for example, if the user has some track MBIDs left over from
before the NGS transition.
2013-03-03 17:08:07 -08:00
Adrian Sampson
a8d999a101 mbsync: split album/item functions; shorter txns
The main change here is to use shorter transactions -- one per matching entity
-- rather than one large one. This avoids very long transactions when the
network happens to move slowly.
2013-03-03 16:52:14 -08:00
Adrian Sampson
5f3ebde6bb mbsync: docs/changelog
As discussed on #115, this has the "reimport" docs refer to the mbsync plugin.
2013-03-03 16:41:48 -08:00
Adrian Sampson
54e070d06b mbsync: use SingletonQuery for item updates 2013-03-03 16:29:31 -08:00
Jakob Schnitzer
d647ea0f0d mbsync: a little refactoring 2013-03-03 23:39:14 +01:00
Jakob Schnitzer
49d3ca4f02 mbsync: update docs 2013-03-03 23:39:13 +01:00
Jakob Schnitzer
3a9c9d53da mbsync: add support for singletons
I can't really guarantee this works right now since I have no singletons
in my collection to test it
2013-03-03 23:39:13 +01:00
Jakob Schnitzer
78a99c23fa mbsync: documentation 2013-03-03 23:39:13 +01:00
Jakob Schnitzer
cd7305d487 mbsync: write metadata to files... 2013-03-03 23:39:13 +01:00
Jakob Schnitzer
2fd3ad5362 initial version of the mbsync plugin
this plugin provides a faster way to query new metadata from
musicbrainz. (instead of having to 're-import' the files)
Currently it lacks all forms of documentation and will only work for
album queries. not really tested so far so be careful
2013-03-03 23:39:13 +01:00
Jakob Schnitzer
ef22ea5183 convert: add missing util.displayable_path 2013-03-01 16:16:28 +01:00
Fabrice Laporte
91255c5ae1 Merge branch 'master' of https://github.com/sampsyo/beets 2013-03-01 08:25:39 +01:00
Adrian Sampson
1fbbe61546 mbcollection: human-readable MB exceptions
Fixes #107 by wrapping the API invocation function with exception handlers.
2013-02-28 10:43:02 -08:00
Adrian Sampson
698e54edbc fix bytes literals causing a Unidecode warning
This would trigger a warning in Unidecode when metadata was missing (which is
the only case when those empty-string literals are used). Closes #109, which
is a different fix for the same problem.
2013-02-28 10:14:21 -08:00
Adrian Sampson
d71737114a format None values as the empty string
Fix due to @pscn. Includes test. Closes #108.
2013-02-28 10:00:26 -08:00
Adrian Sampson
c31eabe95c convert: add missing syspath call (closes #106) 2013-02-27 10:30:24 -08:00
Adrian Sampson
3cd57e6e36 Merge pull request #105 from samdoshi/aliases
Unit tests and bug fix for aliases (#102)
2013-02-27 10:24:23 -08:00
Adrian Sampson
c2e6150af5 changelog/thanks for #104 2013-02-27 10:21:14 -08:00
Adrian Sampson
7f0da0d75c Merge pull request #104 from samdoshi/initial_lookup_fix
tag_album does not take timid as an argument
2013-02-27 10:17:39 -08:00
Sam Doshi
8394619b99 add unit tests for aliases (#102) 2013-02-27 09:17:42 +00:00
Sam Doshi
70b5b3ad44 go to next locale if no match in _preferred_alias
we should continue here rather than return so that we continue to search
for matches
2013-02-27 08:58:06 +00:00
Sam Doshi
e7b5275538 tag_album does not take timid as an argument
see SHA: 75d43270e8
2013-02-27 08:43:32 +00:00
Adrian Sampson
f268aae17f add --flat option to import command (GC-202) 2013-02-26 20:59:52 -08:00
Adrian Sampson
706c4fb7f6 import.detail config option (GC-263) 2013-02-26 20:36:29 -08:00
Adrian Sampson
6ab9b55845 link to GitHub Issues 2013-02-26 16:40:37 -08:00
Adrian Sampson
0045880f58 change option name to "languages"; docs (#102) 2013-02-26 14:38:34 -08:00
Adrian Sampson
9f5926a026 refactor alias discovery into function (#102) 2013-02-26 14:29:55 -08:00
Adrian Sampson
c12302547a Merge pull request #102 from samdoshi/aliases
Add support for artist aliases (fixes GC-354)
2013-02-26 14:12:16 -08:00
Adrian Sampson
0d762cd269 first half-attempt at a flexible attribute schema
This uses two tables, item_attributes and album_attributes, as key/value
tables for the respective entities. Plugins register fields, at which point
they are magically materialized as properties on Items (Albums are not done).
This currently supports adding and modifying these fields but not retrieving
them (which will need some sort of join).
2013-02-26 13:35:26 -08:00
Adrian Sampson
4a35be5724 fix crash when RG fields set to null
In general, we convert None values to type-based nulls in packed fields just
as we do for normal fields.
2013-02-24 16:10:18 -08:00
Adrian Sampson
fa9d326d39 ignore "System Volume Information" directory
This is a control directory on Windows whose permissions are always set very
restrictively:
http://blogs.msdn.com/b/oldnewthing/archive/2003/11/20/55764.aspx
2013-02-24 15:53:47 -08:00
Adrian Sampson
c19fd0e0e6 proceed past os.listdir errors in sorted_walk 2013-02-24 15:47:09 -08:00
Adrian Sampson
d3a00ec443 don't crash when config file is empty 2013-02-21 11:03:22 -08:00
Adrian Sampson
6c1b49aadb use gst-python from stock Homebrew 2013-02-21 11:03:08 -08:00
Adrian Sampson
d50fc378bb Sound Check parsing: fix odd-length strings 2013-02-20 22:56:12 -08:00
Adrian Sampson
c2a746562a fix Sound Check decode (GC-521)
Fixes the case when the gain number is negative.
2013-02-20 22:54:57 -08:00