Commit graph

6487 commits

Author SHA1 Message Date
Johnny Robeson
69c9fb8b07 check dirname result against b'' in fetchart 2016-06-10 02:52:58 -04:00
Johnny Robeson
5e62b39f75 replace TEMPORARY with FIXME in discogs plugin
We're more likely to search for this later by FIXME.

NOTE: the bug is fixed, but the versions with the fix may not be widely
distributed yet
2016-06-10 02:30:00 -04:00
Johnny Robeson
5485bdb706 add missing b' in discogs query regex 2016-06-10 02:23:14 -04:00
Johnny Robeson
78139e60e8 add missing b's in _unpack_asf_image 2016-06-10 02:18:54 -04:00
Johnny Robeson
a274b4e737 read and write the pickled statefile as binary
Pickle files should be treated as binary files
2016-06-10 02:02:28 -04:00
Johnny Robeson
ab67727283 wrap the cover_names map with a list in fetchart
most `cover_names` users expect to operate on a list
2016-06-10 00:09:15 -04:00
Johnny Robeson
02165fc3a9 open lastgenre whitelist in binary mode 2016-06-09 23:53:40 -04:00
Jack Wilsdon
26a17a3703 Remove trailing whitespace added in a45dcdc 2016-06-09 19:23:54 +01:00
Adrian Sampson
0f8fc33952 Fix inverted assertion sense
I broke this in 2fefd24 by using the wrong assertion.
2016-06-09 10:23:24 -07:00
Adrian Sampson
a45dcdc674 Fix Windows env vars for config test 2016-06-09 09:58:10 -07:00
Adrian Sampson
e508daea63 Use syspath for existence checks 2016-06-09 09:43:24 -07:00
Adrian Sampson
2fefd2471a Use our higher-level assertions for files 2016-06-09 09:39:44 -07:00
Adrian Sampson
9717940c9b Cross-platform relative path in test 2016-06-08 23:03:45 -07:00
Adrian Sampson
2c7e7d7727 Portable paths in mpdstats tests 2016-06-08 12:59:45 -07:00
Adrian Sampson
080c7e6360 Merge pull request #2044 from jackwilsdon/remove-force
Add --force option to remove.
2016-06-08 11:53:48 -07:00
Jack Wilsdon
d1714ce114 Add reference to bug for beet remove --force 2016-06-08 19:34:09 +01:00
Jack Wilsdon
bcb19c4b56 Add beet remove --force option to changelog 2016-06-08 19:29:56 +01:00
Jack Wilsdon
3f8a85c825 Add tests for force deletion (without input) 2016-06-08 19:26:42 +01:00
Jack Wilsdon
0d2923e4ea Add documentation for beet remove --force 2016-06-08 19:26:19 +01:00
Jack Wilsdon
34b3cf36b7 Add --force option to beet remove 2016-06-08 19:22:24 +01:00
Adrian Sampson
847c3bbfef Don't test absolute paths as queries on Windows 2016-06-08 10:41:32 -07:00
Adrian Sampson
bea77370c4 Simpler absolute path detection test 2016-06-08 10:34:21 -07:00
Adrian Sampson
416593fbf8 Split path detection tests 2016-06-08 10:31:05 -07:00
Adrian Sampson
f79daacb7b Fix a hard-coded path separator in a test 2016-06-08 10:23:35 -07:00
Adrian Sampson
f400a2431e fetchart: Fix path types on Windows 2016-06-08 10:20:25 -07:00
Adrian Sampson
27bd4c5570 Fix #2041: encoding detection when stdin is a pipe 2016-06-08 09:52:16 -07:00
Adrian Sampson
93e614c739 Tests for _{in,out}_encoding (#2041) 2016-06-08 09:47:45 -07:00
Adrian Sampson
9898cb1678 Changelog/thanks for #2038 2016-06-08 09:37:26 -07:00
Adrian Sampson
1dc61491c6 Remove a bogus bash-completion path (#2038) 2016-06-08 09:36:00 -07:00
Adrian Sampson
77b0c17448 Merge pull request #2038 from bismark/patch-1
Support Homebrew's bash-completion2
2016-06-08 09:35:07 -07:00
Johnny Robeson
7c39462ae6 add a __bool__ to Results in db.py 2016-06-08 00:58:57 -04:00
Johnny Robeson
790b1b5153 replace some filter/map calls with list comps
These are places where the surrounding/calling code needs a list, not an iter.
2016-06-08 00:17:18 -04:00
Johnny Robeson
be474b3f52 wrap a call to filter in a list()
There are other filters like this in the master branch, but
2to3 converts them into list comprehensions. We'll deal with those
later
2016-06-06 17:26:06 -04:00
Johnny Robeson
f7f249f6c6 wrap map() in a list() where necessary for py3
It's slightly more inefficient during the py3 transition, but
I still think it's worth minimizing the diff for.
2016-06-06 17:10:21 -04:00
Adrian Sampson
8b62aa828c Fix KeyFinder test assertion 2016-06-06 12:17:17 -07:00
Adrian Sampson
94372e87a8 Merge branch 'master' of github.com:sampsyo/beets 2016-06-06 11:54:33 -07:00
Adrian Sampson
90f4c77ea0 Skip permissions tests on Windows 2016-06-06 11:54:23 -07:00
Adrian Sampson
2322962cf8 Fix another sys.platform check 2016-06-06 11:51:32 -07:00
Adrian Sampson
8bf1f868fa Fix comparison in a library type test 2016-06-06 11:46:51 -07:00
Adrian Sampson
a5b7489dd1 Use new assertion in config tests 2016-06-06 11:40:04 -07:00
Adrian Sampson
8359b9e90f Tests: path equality assertion 2016-06-06 11:30:38 -07:00
Adrian Sampson
00dece4dc2 Shorter default envlist for tox (#2035)
Now just typing `tox` or `detox` runs some sensible defaults. (This excludes
Python 3 and coverage.) You can request other environments explicitly with
`-e`.
2016-06-06 11:22:53 -07:00
Adrian Sampson
b9845f29db Capture convert's stderr
We were leaking errors to the console without this.
2016-06-06 11:16:50 -07:00
Adrian Sampson
1c1c73b062 Check for convert failures 2016-06-06 11:01:10 -07:00
Adrian Sampson
ad74da1149 Refactor similarity tests
The upshot is we can now compare the two Popen invocations
independently.
2016-06-06 10:58:25 -07:00
Adrian Sampson
a9573cea0c Avoid Windows path prefix for ImageMagick 2016-06-06 10:21:30 -07:00
Adrian Sampson
bfa56b1d8d Tests: fix mocking of art.extract 2016-06-06 10:08:30 -07:00
Ryan Johnson
2fed1cf3f2 formatting 2016-06-06 17:11:09 +01:00
Ryan Johnson
cf397277d2 Support Homebrew's bash-completion2 2016-06-06 12:23:42 +01:00
Adrian Sampson
5db8f69bc1 Fix invocation signature for check_art_similarity
The second argument is an Item, not a filename.
2016-06-05 12:37:05 -07:00