Commit graph

6487 commits

Author SHA1 Message Date
Adrian Sampson
746aecad2b Fix a sys.platform check in hidden test 2016-06-05 12:28:47 -07:00
Adrian Sampson
60b4172a59 Tests: don't use None as a path stand-in
This triggered a crash in `syspath` on Windows.
2016-06-05 12:26:51 -07:00
Adrian Sampson
2021c82a8b Remove an unused variable
That's what I get for coding on Windows without my flake8 plugin!
2016-06-05 12:23:40 -07:00
Adrian Sampson
b752a58ed6 Improve a couple of docstrings 2016-06-05 12:16:41 -07:00
Adrian Sampson
f1b81bc60c Close all threads' connections 2016-06-05 12:14:50 -07:00
Adrian Sampson
574f3bc732 Main function closes its library 2016-06-05 12:03:30 -07:00
Adrian Sampson
2f9aa41614 Clean up SQLite connections in test harness
Windows complains that we can't remove the test database file if open
connections remain.
2016-06-05 11:56:09 -07:00
Johnny Robeson
42d642f1f6 use codecs module to decode to hex in _sc_decode
'hex' doesn't exist as a decoder for bytes in py3
2016-06-03 16:18:58 -04:00
Johnny Robeson
7ab0964826 add C901 (function complexity)to flake8 ignore list
I'm adding this both as a TODO item and to work around flake8 preferring
global ($HOME) configuration over project
2016-06-03 16:10:31 -04:00
Jack Wilsdon
96dfa37e40 Merge pull request #2035 from jackwilsdon/improve-tox-configuration
Update tox configuration
2016-06-03 14:02:07 +01:00
Adrian Sampson
a1030195f7 Expand changelog to cover 581fba6 2016-06-02 22:16:29 -07:00
Adrian Sampson
0051bdb506 lyrics: Avoid a spurious warning 2016-06-02 21:33:33 -07:00
Jack Wilsdon
fa7afba327 Remove basepython so any version can be used 2016-06-03 02:47:19 +01:00
Jack Wilsdon
10ce4fa8c5 Re-add min-version for flake8 in setup.cfg 2016-06-03 02:44:37 +01:00
Jack Wilsdon
bd93d66c47 Remove unneeded environment variables in tests 2016-06-03 02:42:50 +01:00
Johnny Robeson
e7f70c896d check imagemagick output with bytes regex too 2016-06-02 21:34:35 -04:00
Jack Wilsdon
85864eb747 Add specific versions for environments in tox 2016-06-03 02:32:09 +01:00
Johnny Robeson
7467ebaaca check for imagemagick in command_output with b\' 2016-06-02 21:27:09 -04:00
Adrian Sampson
d5f4c80894 Merge pull request #2034 from jrobeson/replace-__cmp__-with-rich-comparisons
Replace __cmp__ with rich comparisons for Distance
2016-06-02 17:17:37 -07:00
Jack Wilsdon
89088ad750 Remove unused pypy3 test ignore 2016-06-03 00:51:53 +01:00
Jack Wilsdon
82df8d18df Update tox configuration
- Add support for Python 3 testing.
 - Add Python 3.3, 3.4 and 3.5 tests to Travis and AppVeyor.
 - Allow arguments to be passed to tox from test matrix.
 - Simplify tox configuration so that we now only have `test`, `flake8`
   and `docs` tasks.
2016-06-03 00:46:02 +01:00
Johnny Robeson
6c661c4327 Replace __cmp__ with rich comparisons for Distance 2016-06-02 19:27:22 -04:00
Adrian Sampson
ae7990322a Merge pull request #2032 from pszxzsd/bs1770
make bs1770gain calculate sample peak instead of true peak
2016-06-02 16:17:04 -07:00
Johnny Robeson
9ed9faf246 add some b' to paths in sort tests 2016-06-02 18:52:32 -04:00
Adrian Sampson
581fba6288 lyrics: Avoid crash when enabling google
If you *both* haven't set an API key *and* BeautifulSoup wasn't
installed, the list.remove() call would crash. (This came up when
running the tests on a fresh machine without many dependencies.)
2016-06-02 11:58:14 -07:00
Adrian Sampson
2228e0e8e1 More binary-mode open in tests 2016-06-02 11:52:56 -07:00
Adrian Sampson
82640260c2 Tests: don't unload the beetsplug module
This was added in 1666f883e3 back in 2013. I'm
not sure why this *ever* worked to get beetsplug to point to the right
directory, but I believe it was superseded by the path manipulation in
aa07eb9551, added in 2014. And now, it's causing
problems on Windows, where for some reason it's causing `import beetsplug.x`
to silently succeed but yield an empty `beetsplug`, without `x` in the
namespace.
2016-06-02 11:41:25 -07:00
Adrian Sampson
07c95a1bf1 Require an imaging backend for fuzzy ratio tests
These fail outright if we don't have a way to get image sizes (e.g.,
ImageMagick).
2016-06-02 11:39:05 -07:00
Adrian Sampson
23f39982bc Remove accidentally-added log file 2016-06-02 11:33:52 -07:00
Adrian Sampson
e71e17d924 Open image file as binary in tests 2016-06-02 10:17:02 -07:00
pszxzsd
7744c6bd90 add changelog entry for bs1770gain peak fix 2016-06-02 11:03:59 +02:00
pszxzsd
8dcd50b18f make bs1770gain calculate sample peak instead of true peak 2016-06-01 20:00:08 +02:00
Adrian Sampson
9f8b81a5ad Fix variable reference in stub 2016-05-31 18:13:50 -07:00
Adrian Sampson
e8c8f9fb14 Possibly make the convert stub work on Windows 2016-05-31 18:08:26 -07:00
Adrian Sampson
f96aa24a79 Convert stub: use __future__ imports
Even tiny stubs can't escape the wrath of flake8!
2016-05-31 17:55:12 -07:00
Adrian Sampson
fc3f64de95 Convert stub: Python 3 compatibility
Important for systems where `python` is 3.x, like Arch, even when beets itself
is running on Python 2.
2016-05-31 17:52:32 -07:00
Adrian Sampson
40369c6ab2 Move convert stub script to its own file 2016-05-31 17:50:54 -07:00
Adrian Sampson
2a9be12503 Fix partial commit of change 2016-05-31 15:35:59 -07:00
Adrian Sampson
075cc10d1c Fix encoding for Windows path resolution 2016-05-31 15:34:17 -07:00
Adrian Sampson
469aee9848 Correctly encode arguments in tests 2016-05-31 15:32:09 -07:00
Adrian Sampson
9e27c9e5ac Fix duplicated argument in test 2016-05-31 15:19:34 -07:00
Adrian Sampson
17681145c2 Fix a too-long line 2016-05-31 13:52:27 -07:00
Adrian Sampson
6ff7271ea0 Refactor convert command tests
This lets us force the use of explicit path: queries on the command line
instead of implicit path queries. This is more robust and works on
Windows, which currently gets confused when path components start with
`c:`.
2016-05-31 13:46:44 -07:00
Adrian Sampson
5b2fb8dcdc Queries with \ are path queries on Windows 2016-05-31 13:29:00 -07:00
Adrian Sampson
1eb03a0de5 Query tests: use normalized paths
Match ordinary beets behavior by storing normalized paths in the
database. This matters on Windows, where normalization adds backslashes
and drive letters.
2016-05-31 13:12:32 -07:00
Adrian Sampson
33a4767eaf Portable mock command for testing convert plugin 2016-05-31 11:48:29 -07:00
Adrian Sampson
2b9f4773a9 Version bump: 1.3.19 2016-05-31 10:43:36 -07:00
Adrian Sampson
9bb6f1e893 Add date for 1.3.18 release 2016-05-31 10:42:56 -07:00
Adrian Sampson
dfe0730e22 Reorganize changelog for release 2016-05-31 10:41:37 -07:00
Adrian Sampson
a440e44abd Proofread the changelog 2016-05-31 10:33:56 -07:00