ybnd
63ea17365a
Modify patched stdout in test_malformed_output
2020-02-05 09:04:24 +01:00
ybnd
7005691410
Add comment to clarify unexpected AttributeError handling
2020-02-05 08:52:50 +01:00
ybnd
1ab46c69be
Merge remote-tracking branch 'origin/master' into bs1770gain-v0.6.0-parsing
...
# Conflicts:
# docs/changelog.rst
2020-02-05 08:45:30 +01:00
ybnd
9465e933ba
Add to changelog
2020-02-05 08:36:44 +01:00
Adrian Sampson
95e0f54d7c
Fix too-long lines ( #3448 )
2020-02-02 21:04:55 -05:00
Adrian Sampson
d4d04c61aa
Merge pull request #3448 from xhocquet/genius-lowercase-artist-fix
...
Genius lyrics fix for API capitalization behaviors
2020-02-02 20:46:24 -05:00
Xavier Hocquet
9f43408f1b
Changelog and cleanup
2020-02-02 15:57:43 -07:00
ybnd
bef473c8e8
Remove spliced progress regex and add --suppress-progress flag
2020-01-31 07:42:50 +01:00
ybnd
506be02597
Remove packaging dependency
2020-01-30 20:11:09 +01:00
ybnd
c3817a4c06
Implement review comments
...
* safer version comparison
* regex bytes directly
* handle b'\x08 ...' case
* test_replaygain.py: injected command output should match the type of the actual output
2020-01-30 19:21:53 +01:00
ybnd
c1cb78c908
Small fixes in replaygain.Bs1770gainBackend and test_replaygain.py
...
* Fix unspecified `gain_adjustment` when method defined in config
* Fix difference between dB and LUFS values in case of mismatched `target_level`/`method`:
```
db_to_lufs( target_level <dB> ) - lufs_to_dB( -23 <LUFS> )
```
* Ignore single assertion in case of bs1770gain
(cherry picked from commit 2395bf224032c44f1ea5d28e0c63af96a92b96df)
2020-01-30 17:59:57 +01:00
ybnd
c78afb1a97
Don't call bs1770gain outside of try statement
2020-01-30 17:02:28 +01:00
ybnd
53820c0a98
Handle bs1770gain v0.6.0 XML output
...
* Remove `0%\x08\x08` from output (backspace code doesn't resolve; progress percentages get spliced in)
* Handle changed attributes/fields:
* `sample-peak` attribute `factor` is called `amplitude` instead
* Album summary is not included in a `summary` tag now, but in two separate `integrated` and `sample-peak` tags
* Handle `lu` attribute
* Get bs1770gain version
* If v0.6.0 or later, add `--unit=ebu` flag to convert `db` attributes to LUFS
* May be useful later on
### Output examples
Track:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
<track total="1" number="1" file="02 tïtle 0.mp3">
<integrated lufs="-70.00" lu="52.00"/>
<sample-peak spfs="-72.28" amplitude="0.00"/>
</track>
<integrated lufs="-70.00" lu="52.00"/>
<sample-peak spfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```
Album:
```
<!-- analyzing ... -->
<bs1770gain norm="-18.00">
<track total="2" number="1" file="02 tïtle 0.mp3">
<integrated dbfs="-70.00" db="52.00"/>
<sample-peak dbfs="-72.28" amplitude="0.00"/>
</track>
<track total="2" number="2" file="02 tïtle 1.mp3">
<integrated dbfs="-70.00" db="52.00"/>
<sample-peak dbfs="-72.28" amplitude="0.00"/>
</track>
<integrated dbfs="-70.00" db="52.00"/>
<sample-peak dbfs="-72.28" amplitude="0.00"/>
</bs1770gain>
<!-- done. -->
```
2020-01-30 16:13:29 +01:00
Adrian Sampson
c1937e1b01
Merge pull request #3477 from ybnd/master
...
Remove --replaygain flag when checking bs1770gain availability
2020-01-29 09:45:55 -06:00
ybnd
a4a0a4bd28
Remove --replaygain flag when checking bs1770gain availability
...
bs1770gain exits with error 1 when called without data, interpreted as unavailable
2020-01-28 09:45:20 +01:00
Adrian Sampson
ca3142b1d9
Merge pull request #3467 from BrainDamage/keyfinder-cli
...
support for keyfinder-cli, which doesn't want the -f flag for paths
2020-01-14 08:24:54 -05:00
BrainDamage
f118314682
support for keyfinder-cli, which doesn't want the -f flag for paths
2020-01-14 05:07:33 +01:00
Adrian Sampson
a08f2315ea
Simplify Confuse usage ( #3463 )
2019-12-26 20:44:14 -05:00
Adrian Sampson
f0eede2ab4
Merge pull request #3463 from mathieupinet/fetchart_highresolution
...
fetchart: New high_resolution config option (#3391 )
2019-12-26 20:43:51 -05:00
Mat
2593a5be34
Use a local var to use high resolution option
2019-12-26 21:55:48 +00:00
Mat
7ad3f7f728
Apply suggestions from code review
...
Fix wording in docs
Co-Authored-By: Adrian Sampson <adrian@radbox.org>
2019-12-26 21:09:26 +00:00
Mat
3570f5cd56
New high_resolution config option in fetchart
2019-12-26 17:36:56 +00:00
Adrian Sampson
a9b19e1678
Merge pull request #3459 from cole-miller/index-tracks
...
discogs: Add `index_tracks` option (closes #3458 )
2019-12-18 15:59:35 -05:00
Cole Miller
ea02890be6
Merge remote-tracking branch 'origin/index-tracks' into index-tracks
2019-12-18 14:46:15 -05:00
Cole Miller
49d9f474a5
Update changelog
2019-12-18 14:44:57 -05:00
Cole Miller
e945ed894d
Add trailing comma
...
Co-Authored-By: Adrian Sampson <adrian@radbox.org>
2019-12-18 14:31:59 -05:00
Cole Miller
6c948764fe
Wrap comment lines
2019-12-17 17:56:56 -05:00
Cole Miller
614289af5f
Remove use of `list.clear()' for compatibility
2019-12-17 17:46:43 -05:00
Cole Miller
3ccafa2495
Fix `str.join' usage
2019-12-17 17:40:16 -05:00
Cole Miller
5f74edf2d9
One more documentation typo
2019-12-17 17:01:34 -05:00
Cole Miller
67e402bbae
Fix typo in new documentation
2019-12-17 16:57:24 -05:00
Cole Miller
90fb79f408
Document `index_tracks' option
2019-12-17 16:54:56 -05:00
Cole Miller
8805ba28fd
Add comments
2019-12-17 16:33:41 -05:00
Cole Miller
02e03be93d
Incorporate divisions into track titles
2019-12-17 15:38:54 -05:00
Cole Miller
e31695b606
Trace hierarchy of index tracks
2019-12-17 15:27:26 -05:00
Cole Miller
6889b9ffdc
Add `index_tracks' configuration option
2019-12-17 13:43:53 -05:00
Adrian Sampson
20630d1947
Merge pull request #3457 from mathieupinet/patch-1
...
Wording/grammar
2019-12-16 17:07:25 -05:00
Mat
e760fc6947
Wording/grammar
2019-12-16 21:47:13 +00:00
Adrian Sampson
bc9e9664fd
Drop Python 3.4; add Travis builds for 3.8
2019-12-10 13:03:53 -05:00
Adrian Sampson
2e24887f53
Changelog for #3449
2019-12-09 15:57:41 -05:00
Adrian Sampson
9739e9be9b
Docs tweaks for #3449
2019-12-09 15:55:31 -05:00
Adrian Sampson
40750cd3e2
Merge pull request #3449 from jef/patch-1
...
Added schema variable and added more logging
2019-12-09 15:50:51 -05:00
Jef LeCompte
89f21d9601
Updated documentation
2019-12-09 07:13:25 -05:00
Jef LeCompte
e18b91da26
Remove example
2019-12-06 18:32:35 -05:00
Jef LeCompte
5a38e1b35c
Refactored token generation and updated comments based on suggestions.
...
Also updated documentation to note the password options.
2019-12-06 18:30:52 -05:00
Jef LeCompte
1690c08e77
Added URL to config and deprecated old configuration
2019-12-06 15:05:36 -05:00
Xavier Hocquet
c8e8e587f8
Add debug logger for Genius lyrics no-match
2019-12-05 20:06:49 -07:00
Xavier Hocquet
d43cf35ad2
Strip and lowercase Genius lyrics artist comparison
2019-12-05 20:06:46 -07:00
Adrian Sampson
60bba370c0
Credit & bug link for #3437
2019-11-25 08:45:30 -05:00
Adrian Sampson
28fb69a57a
Merge pull request #3437 from aereaux/consume_increment_playlist_version
...
Increment playlist_version when a track is consumed.
2019-11-25 08:44:52 -05:00