Adrian Sampson
4ecaa4239f
Fix unittest.skip decorator use
...
This fixes the py26 build.
2014-08-18 17:11:08 -07:00
Adrian Sampson
bf553eae34
MediaFile: detect missing numbers ( fix #901 )
2014-08-18 10:17:01 -07:00
Olin Gay
d076e14515
Complete PEP8 cleanup of spotify plugin
2014-08-17 09:53:54 -04:00
Olin Gay
6bab9a2cae
Merge branch 'master' of https://github.com/sampsyo/beets into spotify-plugin
2014-08-17 08:36:32 -04:00
Adrian Sampson
09b0e1c75d
Add failing test for #899
2014-08-15 12:38:41 -07:00
Adrian Sampson
7de6259c1d
MediaFile: make id3v23 a constructor parameter
...
For #899 , we need to change MediaFile's behavior (pre-write) based on whether
we're doing ID3v2.3 or not. So we need a field on the object, not a parameter
to `save()`.
2014-08-15 12:09:18 -07:00
Thomas Scholtes
76c7ba9186
Add asciify_paths configuration option
2014-08-06 17:53:44 +02:00
Thomas Scholtes
29e4fde571
convert: Simplify format configuration.
...
We don't have to specify the extension. By default it is the same as
the format name.
2014-08-05 12:06:35 +02:00
Thomas Scholtes
b27409684e
convert: Add --format option
...
This option allows the user to specify the format on the command line
instead of editing the configuration.
The commit also includes some refactoring. In particular adding
arguments to functions to avoid dependence on global state.
Doc and Changelog in next commit
2014-08-05 10:45:32 +02:00
Olin Gay
ce4b45ec76
Pull request for Spotify plugin development, see: https://groups.google.com/forum/#!topic/beets-users/2xsOZC-NMNk
2014-08-03 19:55:50 -04:00
Thomas Scholtes
0f2a9bdcdc
Record singletons for incremental import
...
We still need to implement this for flat imports, archives and toppath
singletons. Fixes #860 .
2014-07-31 11:09:16 +02:00
Thomas Scholtes
c5f23cc4f8
Don't write state to disk when nothing changes
2014-07-19 14:17:51 +02:00
Thomas Scholtes
46c9992633
Refactor resuming of imports
...
Instead of recording only the most recently imported path and assuming
that all previous path have also been imported, we record all imported
paths and skip recorded paths when resuming the import.
This fixes an issue where parallelism would screw up the import order
and reimport some files. It also allows us to record singleton items.
We can apply the same strategy can be applied for incremental imports.
2014-07-08 15:06:01 +02:00
Thomas Scholtes
b5426f72a1
Wrap mediafile read exceptions in library.ReadError
...
The ui only handles library Exceptions. Fixes #857 .
2014-07-06 13:19:43 +02:00
Adrian Sampson
10d0572214
Tiny style fixes for #854
2014-07-01 23:10:50 -07:00
philipbjorge
9e6f31eef0
Fixed flake8 errors
2014-07-01 19:41:43 -07:00
philipbjorge
16ef9a7aeb
Added unit test for Library unicode filenames #833
2014-07-01 19:19:55 -07:00
Adrian Sampson
e5c5e1858c
Changelog for #851 (bucket improvements)
2014-07-01 14:40:39 -07:00
Adrian Sampson
711b1a5bb1
Merge branch 'sotho-master'
2014-07-01 14:38:02 -07:00
Adrian Sampson
59da6c851d
Merge pull request #847 from KraYmer/issue805
...
lastgenre: remove duplicate genres
2014-07-01 14:27:51 -07:00
Alexander Elbs
9ca816f247
the bucket plugin transforms a pattern like 'A - D' into something that
...
matches all letters starting with A to D (upper and lower case). This
change allows to put more artists into that bucket. E.g. artists
starting with ä or Ä and 0 to 9 and … (three dots)
Example config for overriding a bucket pattern:
bucket:
bucket_alpha: ['A - D', 'E - L', 'M - R', 'S - Z']
bucket_alpha_regex:
'A - D': ^[0-9a-dA-D…äÄ]
2014-06-30 20:55:28 +02:00
Fabrice Laporte
df47f19e86
lastgenre: remove duplicate genres
2014-06-28 10:31:12 +02:00
Fabrice Laporte
ef89daf1be
test_art: add unit test
...
the test checks that the keyword priority (related to its
position in the keywords list) is considered when selecting
image filename amongst several candidates
2014-06-27 23:32:57 +02:00
Pierre Rust
18539b0bd1
Fix flake8 warnings.
2014-06-15 22:32:26 +02:00
Pierre Rust
69213ad574
Add tests for computed attributes.
2014-06-15 22:32:26 +02:00
Pierre Rust
936acf0236
Fix typo in common utility function for tests
2014-06-15 22:32:26 +02:00
Pierre Rust
728797718e
Add tests cases for sort on albums.
...
On fixed and flex attributes.
2014-06-15 22:32:26 +02:00
Pierre Rust
ad1c0b3831
Add unit tests for fixef and flex field sort
2014-06-15 22:32:26 +02:00
Pierre Rust
1303a915c1
Sort implementation
...
* sort can be sepcified using the 'field_name'(+|-) syntax
* supports fixed fields and flexible attributes
* includes plugins fix for API changes (might have missed some)
2014-06-15 22:32:25 +02:00
Thomas Scholtes
f19fa1567e
Test converter embeds album art
2014-06-02 17:09:16 +02:00
Thomas Scholtes
9c6491a65d
Embedart TestCase
2014-06-02 16:04:55 +02:00
Adrian Sampson
632d3a9612
dbcore: Add shared instances of common types
...
Following click's example:
https://github.com/mitsuhiko/click/blob/master/click/types.py#L414
2014-05-25 16:38:47 -07:00
Adrian Sampson
394e4e45eb
dbcore: Add types for non-fixed fields
...
The base Type class now serves as the catch-all logic for untyped fields.
2014-05-25 16:23:15 -07:00
Adrian Sampson
70b5a44ef4
Move query parsing to new dbcore.queryparse
...
Fix #649 .
2014-05-24 17:07:18 -07:00
Adrian Sampson
908584bde8
Revamp FormattedItemMapping
...
This subclass was not cleanly conforming to the Mapping abstract base. Now
we're in business -- the thing looks like a dict. Brought up by #782 .
2014-05-20 16:24:40 -07:00
Pierre Rust
9901d6a4eb
Add Test case for flexattr removal ( #779 )
2014-05-20 23:55:42 +02:00
Adrian Sampson
943cbe0838
MediaFile: allow setting date fields to None
2014-05-18 15:14:36 -07:00
Adrian Sampson
dfa8445980
Style and wording for Google Images ( #766 )
2014-05-17 22:10:39 -07:00
Adrian Sampson
7f675dbf64
Merge branch 'Lemutar-master'
2014-05-17 22:02:09 -07:00
Adrian Sampson
79aef50c25
AIFF support ( fix #250 )
...
Thanks to @EvanPurkhiser, AIFF is now supported in Mutagen 1.23! Now we can
support it too.
2014-05-17 21:13:40 -07:00
Lemutar
c890384215
add a test, replace urllibs , update help
2014-05-16 10:56:55 +02:00
Fabrice L.
c0f7e1fec4
Merge pull request #747 from KraYmer/issue740_buckets
...
Issue740: introduce bucket plugin to organize files in bucket directories
2014-05-10 23:04:28 +02:00
Fabrice Laporte
02f7e78fd3
fix flake8 warnings
2014-05-10 10:57:44 +02:00
Fabrice Laporte
21feab7ab1
add tests to check bad buckets definitions
...
message is now printed to the user when buckets declared in the config
file cannot be parsed
2014-05-10 10:55:38 +02:00
Fabrice Laporte
4add189608
Add option to extrapolate year buckets names
...
- spans are now tracked via a list of dicts instead of 2 lists
previously (simpler code)
- extend_year_spans() pregenerates all possible ranges at plugin setup
stage
- a BucketError is now raised if declared bucket format not accepted
2014-05-08 01:28:17 +02:00
Adrian Sampson
e800b46a5d
Make FormattedMapping behave more like a dict
...
The collections.Mapping abstract base class provides all the nice dict-like
functionality we need.
2014-05-06 11:32:20 -07:00
Fabrice Laporte
509af59d4e
cleanup docstrings and add tests
2014-05-04 08:51:11 +02:00
Fabrice Laporte
31569baba7
fix range upper bound + tests added
2014-05-03 23:46:31 +02:00
Fabrice Laporte
581bf768ca
add buckets plugin + tests
...
Add a new template functions %bucket(text, field) for path formatting.
2014-05-03 13:55:21 +02:00
Adrian Sampson
6cc643520d
Merge branch 'KraYmer-lyrics-integration-sources'
2014-05-01 08:58:07 -07:00
Adrian Sampson
362db8f22f
Merge pull request #728 from sampsyo/lastgenre-tests-new
...
Tests for lastgenre (cleaned up)
2014-04-29 08:38:56 -07:00
Adrian Sampson
233f71a457
Use real booleans for whitelist/canonical options
...
As opposed to the strings "true" and "false".
2014-04-28 23:00:00 -07:00
Adrian Sampson
add309b57d
Isolate lastgenre tests
...
We now appropriately set up and tear down the fixture for the lastgenre tests.
(This was causing unpredictable failures elsewhere before.)
2014-04-28 22:35:32 -07:00
Fabrice Laporte
ef3c1cd1ff
use booleans for whitelist and c14n options
...
homogenise options setup using booleans, while keeping the empty string
(synonym of ‘true’) for backward compatibility.
2014-04-28 10:31:22 +02:00
Adrian Sampson
d5dbaeff7a
lastgenre: Restore default whitelist
2014-04-27 13:54:32 -07:00
Adrian Sampson
dfd9a4c397
Merge branch 'KraYmer-lastgenre-tests-new' into lastgenre-tests-new
...
Conflicts:
test/test_lastgenre.py
2014-04-27 13:52:06 -07:00
Fabrice Laporte
d1cc95984e
Rename/add tests
...
Rewrite tests now that empty whitelist is allowed.
2014-04-27 22:32:31 +02:00
Fabrice Laporte
0613cb7d13
Update _setup_config
...
Give an empty string to obtain default whitelist, None for no whitelist
or a stringlist for a custom one.
2014-04-27 22:31:31 +02:00
Adrian Sampson
9f5f70aeab
Merge pull request #720 from sampsyo/import-refactor
...
Import refactor
2014-04-27 09:51:10 -07:00
Fabrice L.
e442749cd4
add a test that would fail with the restricted whitelist approach
...
If no option is set, valid genres should not be rejected. Which is an argument
to have a wide default whitelist.
2014-04-27 16:05:16 +02:00
Fabrice Laporte
e399173f7e
add a test that would fail with the restricted whitelist approach
...
If no option is set, valid genres should not be rejected. Which is an argument
to have a wide default whitelist.
2014-04-27 15:59:43 +02:00
Fabrice Laporte
d0d3c18da2
lastgenre: rewrite filtering logic to make tests pass
...
- remove filter_tags() as genres should not be removed this soon while
c14n has not been applied
- group all filtering logic in the function _resolve_genres (formerly
_strings_to_genre)
2014-04-26 20:51:13 -07:00
Fabrice Laporte
2e8e55736d
get rid of module level options variable
...
Conflicts:
beetsplug/lastgenre/__init__.py
2014-04-26 20:51:00 -07:00
Fabrice Laporte
4e5bb262a7
wip: rewrite setup_config
2014-04-26 20:50:04 -07:00
Fabrice Laporte
21f1607e8f
lastgenre: add tests functions
2014-04-26 20:50:04 -07:00
Fabrice Laporte
3d30708839
add test_lastgenre.py
2014-04-26 20:50:04 -07:00
Adrian Sampson
e9355f336b
Rename remove_duplicates and do_remove_duplicates
2014-04-26 20:21:20 -07:00
Adrian Sampson
38eba4af31
Remove obsolete null checks
...
Along with their tests. Background:
https://github.com/sampsyo/beets/pull/720/files#r12027386
2014-04-26 20:07:26 -07:00
Fabrice Laporte
cee5e81500
remove _lyricstext.py
2014-04-27 00:27:11 +02:00
Fabrice Laporte
af468f5259
Move lyrics listings from .py to .yaml file
2014-04-26 19:26:28 +02:00
Thomas Scholtes
1d787e0b38
Adapt FetchArt tests to new task api
2014-04-26 18:51:56 +02:00
Fabrice L
9e39946da5
Update lyrics_sources.py
...
add copyright header
2014-04-26 07:27:23 +02:00
Fabrice Laporte
567e6300fd
fix flake8
2014-04-26 07:27:13 +02:00
Fabrice Laporte
117d16f2ad
lyrics: add tests to track which websites can be scraped by our algo and be
...
used as sources fot the google custom search engine.
2014-04-26 07:26:50 +02:00
Thomas Scholtes
07dbe042f5
Move set_candidate logic
2014-04-25 13:23:35 +02:00
Thomas Scholtes
6d22c7489c
Test build with setup.py
...
Since some builds use `python ./setup.py test` to test beets we want to make
sure it runs smoothly.
2014-04-25 12:56:01 +02:00
Thomas Scholtes
495c49703c
Add pipeline.mutator_stage
2014-04-19 19:04:49 +02:00
Thomas Scholtes
d8362fd03c
Add pipeline.stage decorator
2014-04-19 18:54:29 +02:00
Thomas Scholtes
09ef565cfc
Make _infer_album_fields a method
2014-04-19 17:02:36 +02:00
Thomas Scholtes
ecb9ba97be
Add SingletonImportTask
...
The goal of this class is to eliminate all checks for `task.is_album`. This is
already accomplished for the methods. Next, we want to tackle the plugin
stages.
2014-04-19 17:02:36 +02:00
Thomas Scholtes
a09b2d4760
Test that duplicate files are removed
2014-04-19 17:02:20 +02:00
Thomas Scholtes
4677c55c4f
Remove DuplicateCheckTest
...
Superseded by `ImportDuplicate*Test`.
2014-04-19 15:50:49 +02:00
Thomas Scholtes
efee81cda7
Refactor ImportDuplicateAlbumTest
2014-04-19 15:49:39 +02:00
Thomas Scholtes
52e3413c5b
Test import singleton duplicates
2014-04-19 15:44:20 +02:00
Thomas Scholtes
0518d4e265
Add tests for duplicate album imports
2014-04-19 15:23:01 +02:00
Adrian Sampson
337b1f8610
tests: use Windows config location on Windows
...
Only 10 test failures remain on my system!
2014-04-18 15:57:57 -07:00
Adrian Sampson
5f4a9c6446
fix Windows path manipulation in importfeeds
2014-04-18 15:52:23 -07:00
Adrian Sampson
eee2213099
Merge pull request #696 from ayberk/master
...
Fixed #453 and added test cases
2014-04-18 15:38:27 -07:00
Adrian Sampson
309c5c1a58
fix #705 : unicode in SoundCheck fields
2014-04-17 18:10:16 -07:00
Thomas Scholtes
bd047ec6c8
Add tests for resumed import
2014-04-17 21:56:15 +02:00
Yevgeny Bezman
bbb1f7a295
tests: made all tests pass on cygwin. Fixes #655
2014-04-17 19:50:59 +03:00
Thomas Scholtes
a6aed22ddd
Flake8 fixes
2014-04-17 12:25:59 +02:00
Thomas Scholtes
ea04344560
Test and fix unicode issues in logs. Fixes #699
...
The helper functions for creating test fixtures now include unicode characters.
2014-04-17 12:12:49 +02:00
Ayberk Yilmaz
f67ace610a
Fixed #453 and added test cases
2014-04-16 23:16:04 +03:00
Thomas Scholtes
d02dec8364
Test albums and singletons simultaneously
2014-04-16 14:50:57 +02:00
Thomas Scholtes
b8687999e2
Query string for computed fields. Fixes #693
2014-04-16 14:18:07 +02:00
Thomas Scholtes
8057830c01
Test mbsync plugin
...
Exposes bug from #693
2014-04-16 14:01:00 +02:00
Thomas Scholtes
1f742130c4
Catch all archive extract errors and skip tests without unrar
2014-04-15 18:26:35 +02:00
Thomas Scholtes
68595ee09d
Import rar archives
2014-04-15 18:24:09 +02:00
Thomas Scholtes
e3acdd0cc8
Import tar archives
...
Also refactors the importer code to make better use of ArchiveImportTask.
2014-04-15 18:24:08 +02:00