Test albums and singletons simultaneously

This commit is contained in:
Thomas Scholtes 2014-04-16 14:50:57 +02:00
parent 0751c560e3
commit d02dec8364
2 changed files with 24 additions and 36 deletions

View file

@ -329,7 +329,7 @@ ALBUM_INFO_FIELDS = ['album', 'album_id', 'artist', 'artist_id',
'data_source', 'data_url']
def generate_track_info(track_id='track info'):
def generate_track_info(track_id='track info', values={}):
"""Return `TrackInfo` populated with mock data.
The `track_id` field is set to the corresponding argument. All other
@ -341,6 +341,8 @@ def generate_track_info(track_id='track info'):
)
for field in TRACK_INFO_FIELDS:
setattr(track, field, 'track info')
for field, value in values.items():
setattr(track, field, value)
return track
TRACK_INFO_FIELDS = ['artist', 'artist_id', 'artist_sort',

View file

@ -33,53 +33,39 @@ class MbsyncCliTest(unittest.TestCase, TestHelper):
self.teardown_beets()
@patch('beets.autotag.hooks.album_for_mbid')
def test_update_album(self, album_for_mbid):
@patch('beets.autotag.hooks.track_for_mbid')
def test_update_library(self, track_for_mbid, album_for_mbid):
album_for_mbid.return_value = \
generate_album_info('album id', ['track id'])
track_for_mbid.return_value = \
generate_track_info('singleton track id',
{'title': 'singleton info'})
self.lib.add_album([
Item(
artist='old artist',
album='old album',
title='old title',
mb_albumid='album id',
mb_trackid='track id',
path=''
),
])
item = self.lib.items().get()
album = self.lib.albums().get()
self.assertNotEqual(item.title, 'track info')
self.assertNotEqual(item.artist, 'track info')
self.assertNotEqual(album.album, 'album info')
self.run_command('mbsync')
item.load()
album.load()
self.assertEqual(item.title, 'track info')
self.assertEqual(item.artist, 'track info')
self.assertEqual(album.album, 'album info')
@patch('beets.autotag.hooks.track_for_mbid')
def test_update_singleton(self, track_for_mbid):
track_for_mbid.return_value = generate_track_info('track id')
album_item = Item(
title='old title',
mb_albumid='album id',
mb_trackid='track id',
path=''
)
album = self.lib.add_album([album_item])
item = Item(
artist='old artist',
album='old album',
title='old title',
mb_trackid='track id',
mb_trackid='singleton track id',
path='',
)
self.lib.add(item)
self.assertNotEqual(item.title, 'track info')
self.run_command('mbsync')
item.load()
self.assertEqual(item.title, 'track info')
self.assertEqual(item.title, 'singleton info')
album_item.load()
self.assertEqual(album_item.title, 'track info')
album.load()
self.assertEqual(album.album, 'album info')
def suite():