Commit graph

9863 commits

Author SHA1 Message Date
Graham R. Cobb
45cf9d00c7 Improve handling of paths for Windows tests
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-09 18:58:05 +00:00
Graham R. Cobb
ab2e858bce Aaargh! Forgot to run lint again
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-09 12:10:40 +00:00
Graham R. Cobb
f19faae1dc Attempt to make path-related tests portable to Windows
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-09 11:19:54 +00:00
Graham R. Cobb
4d5c5c02ae Lint fixes
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-08 17:26:04 +00:00
Graham R. Cobb
75f331e64b Update changelog with web regex query backslash fix for #3867.
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-08 17:08:36 +00:00
Graham R. Cobb
38fb1b5f08 Add tests for several web queries, including the regex queries fixed in
bugfix #3867.

Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-08 17:00:41 +00:00
Graham R. Cobb
553e38fc11 Do not do backslash substitution on regex queries
As discussed in bug #3867, backslash replacement in query strings is a bit of a
hack but it is useful (see #3566 and #3567 for more discussion). However,
it breaks many regular expressions so this patch stops the replacement if the
query term contains '::', indicating it is a regex match.

This commit fixes #3867.

Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-08 16:58:05 +00:00
Graham R. Cobb
c5556ff859 Changelog entry for fixing web include_paths artpath bug #3866
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-06 16:03:37 +00:00
Graham R. Cobb
9986b9892c Fix bug where album artpath not returned when INCLUDE_PATHS is set
Track item paths and album artpaths should be removed from results unless
INCLUDE_PATHS is set. This works for items but for albums the artpath is always
removed.

This patch makes the artpath removal conditional on INCLUDE_PATHS not being set
and includes a regression test. Note: the default value for INCLUDE_PATHS is
False so no changes will be seen by users unless they already have
INCLUDE_PATHS set.

Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-06 15:25:48 +00:00
Graham R. Cobb
49c747d144 Small documentation change to make GET /album/.../art clearer
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-06 15:14:41 +00:00
Graham R. Cobb
d2a1251756 Drop changelog as requested by @sampsyo.
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-05 22:42:27 +00:00
Graham R. Cobb
7d3fb0d7ec Fix lint errors
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-05 16:52:21 +00:00
Graham R. Cobb
3846e3519d Update changelog to mention small test coverage improvement for web plugin.
Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-05 16:38:03 +00:00
Graham R. Cobb
de58334ecb Test web API /stats
Added a test (test_get_stats) for the /stats web API.
This involved adding another item so that we can check both items and albums
are being counted correctly, which required a few small changes to some item
tests.

Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-05 16:29:26 +00:00
Graham R. Cobb
15be534e7c Test ?expand using documented syntax
Documentation says that ?expand does not need a value (i.e. ?expand=1 is wrong),
so the test is changed to reflect that syntax.

Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-05 16:17:14 +00:00
Graham R. Cobb
79b41f6f38 Add test for getting album track listing using ?expand=1
Added test_get_album_details to test fetching /album/2?expand=1.
Also changed second album name to make tests more robust.

Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-05 15:56:46 +00:00
Graham R. Cobb
dc55480f51 Document "id" handling in test setup and add test to confirm
self.lib.add ignores the "id" field from the entry being added and overwrites
it with the next free number. So remove the misleading id fields.
Add a test to confirm that the album query response contains the expected
album id number.

Signed-off-by: Graham R. Cobb <g+beets@cobb.uk.net>
2021-03-05 15:27:00 +00:00
Adrian Sampson
d226632eeb
Merge pull request #3863 from m0zes/trackdisambig
Add trackdisambig from musicbrainz.
2021-02-27 19:37:33 -05:00
Adam Tygart
ce78f75ce9 Further attempt to address the comments from sampsyo 2021-02-27 18:31:16 -06:00
Adam Tygart
f3e7edb21e Attempt to address the comments from sampsyo
Undoes the changes to autotag/hooks.py

If trackdisambig is not set to None at some point in time, the
test case for a non-existent trackdisambig fails. as such, try
to get the disambiguation with a default of None when setting
trackdisambig. Not sure if this is reasonable.
2021-02-27 15:23:35 -06:00
Adam Tygart
1b1209a6c3 Add trackdisambig from musicbrainz.
fixes beetbox/beets#1904
2021-02-27 15:07:32 -06:00
Adrian Sampson
5b6dff34a1
Merge pull request #3861 from grawlinson/update_discogs_client
Fix #3608: Replace discogs-client with python3-discogs-client
2021-02-26 16:42:33 -05:00
George Rawlinson
00252ab28f
Fix #3608: Replace discogs-client with python3-discogs-client
discogs-client has been deprecated since June 2020, the replacement
is actively developed by the community and does not have any breaking
API changes.

Signed-off-by: George Rawlinson <george@rawlinson.net.nz>
2021-02-27 10:09:23 +13:00
Adrian Sampson
e9b930b7e2
Merge pull request #3859 from akelge/master
Add strip_path to mpdstats
2021-02-23 07:54:09 -05:00
Andrea Mistrali
1a65501cee Clean up strip_path and logging 2021-02-23 10:40:59 +01:00
Andrea Mistrali
48e7d2964e Style changes 2021-02-23 05:45:53 +01:00
Andrea Mistrali
0e67b6801c ARGH! Wrong variable 2021-02-22 14:50:30 +01:00
Andrea Mistrali
921bc424cd Better handling of strip_path 2021-02-22 14:47:58 +01:00
Andrea Mistrali
99de85b5c2 Only leftmost subpath is replaced 2021-02-22 14:33:01 +01:00
Andrea Mistrali
ce974d4fc7 One line :) 2021-02-22 14:30:50 +01:00
Andrea Mistrali
af2229c1b7 Fix docs and changelog 2021-02-22 14:28:14 +01:00
Andrea Mistrali
414b682123 Add strip_path to mpdstats 2021-02-22 11:19:23 +01:00
Adrian Sampson
04ea754d00
Merge pull request #3844 from SamuelCook/remove_bs1770gain
Removes support for bs1770gain.
2021-01-29 08:13:00 -05:00
Samuel Cook
532ac7f291
Added entry in For packagers changelog section. 2021-01-28 09:42:58 -08:00
Samuel Cook
ff4cec2e69
Removes support for bs1770gain.
References in the documentation to this plugin were removed in
beetbox/beets#3127 (beetbox/beets#3130) but no actual code
changes were made.

This PR removes support for this dependency entirely.
2021-01-27 17:42:18 -08:00
Benedikt
16b79ad2e5
Merge pull request #3838 from wisp3rwind/pr_pipeline_remove_duplicate_code
pipeline: remove duplicate code from previous refactoring
2021-01-21 14:10:39 +01:00
wisp3rwind
848b64933c pipeline: remove duplicate code from previous refactoring 2021-01-20 15:19:06 +01:00
Adrian Sampson
8f8798647b
Merge pull request #3837 from johnhamelink/patch-2
Fixes #3834: Submitting AcoustID information for tracks which already have a fingerprint
2021-01-20 07:36:15 -05:00
John Hamelink
64944a284e
Added changelog entry for #3834 fix 2021-01-19 22:11:34 +00:00
John Hamelink
77ce69fe77
Fixes #3834:
This PR fixes a bug (#3834) where tracks which have already been fingerprinted do not return to be used by `beet submit` (part of the Chroma plugin). This results in  submission errors, as the fingerprint is omitted from the resultant payload sent to acoustID.
2021-01-19 22:05:34 +00:00
wisp3rwind
02ec2cfd57 style: whitespace fix, remove unnecessary parenthesis 2021-01-19 19:09:30 +01:00
wisp3rwind
f60ab5621a changelog spelling 2021-01-19 19:07:46 +01:00
Benedikt
6680f692f6
Merge pull request #3832 from vincentDcmps/master
Automatically choose subsonic authentication algorithm based on server version
2021-01-19 19:00:10 +01:00
vincent
2479edbe22 update changelog 2021-01-19 18:50:11 +01:00
Martin Haaß
9587caf916
convert: uses new par_map to work in parallel (#3830)
Squashed 5 commits:
* convert: uses new par_map to work in parallel
* linting
* code review: remove unneeded list syntax
* linting
* changelog addition
2021-01-19 18:47:02 +01:00
vincent
8af088c785 manage case of supysonic off 2021-01-18 18:24:25 +01:00
vincent
9b496e5027 change comparaison version method 2021-01-13 17:50:37 +01:00
Vincent Ducamps
03a665861d reformating subsonicupdate.py
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
2021-01-12 18:31:43 +01:00
Vincent Ducamps
b37c55bc0b pass get_version to private
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
2021-01-11 21:19:52 +01:00
vincent
811089af72 update test 2021-01-11 18:58:49 +01:00