Adrian Sampson
3ede874e96
Changelog note about new prompt interface
2016-12-28 14:18:27 -05:00
Adrian Sampson
6afe407f45
Remove one last duplicated set of prompts
2016-12-28 14:16:33 -05:00
Adrian Sampson
8937eec50a
Refactor built-in stnadard choices
2016-12-28 14:15:40 -05:00
Adrian Sampson
2f6538aee2
Refactor search options to ordinary choices
...
`PromptChoice`s can now return `Proposal` values, which makes these two
options just "normal" actions that could be provided by plugins.
2016-12-28 14:08:09 -05:00
Adrian Sampson
6c825970ac
Tolerate missing AlbumInfo.mediums field
2016-12-28 13:54:04 -05:00
Adrian Sampson
7c6eafa285
Refactor manual search options to use Proposal
...
This is the first step to making them behave like plugin actions.
2016-12-28 13:50:53 -05:00
Adrian Sampson
a414872430
Fix a missing parameter ( #2349 )
2016-12-28 13:36:19 -05:00
Adrian Sampson
22610b7684
Refactor extra choice return value
...
The `choose_candidate` function now returns the `PromptChoice` object instead
of a short letter that selects the `PromptChoice`.
2016-12-28 13:34:27 -05:00
Adrian Sampson
3578f0d429
Introduce a new Proposal type for tag results
...
tag_album and tag_item now return a Proposal. The idea is that plugin actions
should also be able to return Proposal values, just like the built-in actions.
2016-12-28 13:21:55 -05:00
Adrian Sampson
9b0a867c73
Expand some comments in choose_match
2016-12-28 12:40:33 -05:00
Adrian Sampson
d447d3e655
Changelog note for #2349 ( fix #2347 )
2016-12-28 12:06:29 -05:00
Adrian Sampson
8a62087376
Documentation tweaks for #2349
2016-12-28 12:03:57 -05:00
Adrian Sampson
2a3f3d9bfa
acousticbrainz: Make some strings into comments
...
When not in the docstring position, it's better to use "real" comments instead
of string literals.
2016-12-28 12:01:08 -05:00
Adrian Sampson
c27879edbc
Slight code formatting tweaks for #2349
2016-12-28 11:59:14 -05:00
Adrian Sampson
9db79835d6
Merge pull request #2349 from SusannaMaria/#2347
...
#2347 : First hack of ignoring already tagged items
2016-12-28 11:55:21 -05:00
Susanna Maria Hepp
7e1e31bddd
E128: continuation line under-indented for visual indent?
2016-12-28 15:30:57 +01:00
Susanna Maria Hepp
165f2e189e
Repair findings from Travis CI
2016-12-28 15:11:03 +01:00
Susanna Maria Hepp
8be0a271b5
Add documentation for the force-option
2016-12-27 22:11:27 +01:00
Susanna Maria Hepp
00371de0bb
Changes suggested by @sampsyo
2016-12-27 21:56:39 +01:00
Susanna Maria Hepp
c632949b64
Changes suggested by @Kraymer
2016-12-27 21:48:06 +01:00
nath@home
8e29a3ffcb
Zero: Last minute unimportant fixes:
...
*Remove the artifact of a debug log.
*Remove meaningless version number.
*Rephrase some docstrings.
*Remove tautological comments.
2016-12-27 19:13:29 +01:00
Adrian Sampson
a4e2538324
Merge pull request #2348 from benpetty/patch-1
...
typo in docs
2016-12-27 08:41:21 -05:00
Susanna Maria Hepp
bbaad2f17d
Introduce force option in acousticbrainz
2016-12-27 13:22:16 +01:00
Ben Petty
767798ca07
typo in docs
2016-12-26 20:27:35 -08:00
Susanna Maria Hepp
f93ee3accc
First hack of ignoring already tagged items
2016-12-26 23:54:24 +01:00
Adrian Sampson
8408264142
Update test file for new set of tags
...
The new MediaFile tags in #2333 mean that the `test_unicode_path` test will
write new tags to this test fixture file.
2016-12-26 17:41:44 -05:00
Adrian Sampson
a9fd3df681
Docs fixes for #2329
2016-12-26 17:33:23 -05:00
Adrian Sampson
a92323945e
Merge pull request #2329 from SJoshBrown/master
...
Add manually triggered mode for zero plugin
2016-12-26 17:29:17 -05:00
Adrian Sampson
641e62f2e0
Vastly simplify main random function
...
This is the payoff from the earlier refactorings: the control flow is now
consistent and clear, and the two factors (time vs. number, equal-chance or
not) are orthogonal. See also #2322 .
2016-12-26 17:04:21 -05:00
Adrian Sampson
33eb4ff91b
Refactor time-based selection ( #2322 )
2016-12-26 17:01:02 -05:00
Adrian Sampson
d053f98e81
random: Refactor equal chance logic
2016-12-26 16:43:47 -05:00
Adrian Sampson
5bbf16c2b1
Refactor length calculation ( #2322 )
...
Also, avoid setting an unnecessary field on the album objects. :/
2016-12-26 16:32:03 -05:00
Adrian Sampson
4c2457d6ce
Refactor random plugin a bit
...
Separate the callback function from the random selection logic.
2016-12-26 16:27:31 -05:00
Adrian Sampson
3a650a151e
Docs fixes for #2322
2016-12-26 16:10:46 -05:00
Adrian Sampson
c86b309762
Changelog for #2322 ( fix #2305 )
2016-12-26 16:09:43 -05:00
Adrian Sampson
9adfcbddd1
Merge pull request #2322 from diomekes/random-timelimit
...
random: add --time option, update docs
2016-12-26 16:08:14 -05:00
Josh Brown
b6577b4226
refactor long line for PEP8
2016-12-26 14:42:10 -06:00
Josh Brown
431ec5ee7a
Merge remote-tracking branch 'origin/master'
2016-12-26 14:21:19 -06:00
Josh Brown
7833469261
add confirmation for empty query
2016-12-26 14:13:01 -06:00
Josh Brown
2903925e2f
Rewrite zero plugin manual mode
2016-12-26 13:34:34 -06:00
Josh Brown
30ae211e66
update changelog
2016-12-26 12:10:19 -06:00
Josh Brown
ef80229350
additional zero tests
2016-12-26 12:10:19 -06:00
Josh Brown
5b8b61f0c0
added documentation for zero subcommand
2016-12-26 12:10:19 -06:00
Josh Brown
4cc4fe1290
added zero subcommand
2016-12-26 12:10:18 -06:00
Adrian Sampson
22937698e2
Merge pull request #2345 from beetbox/clean-zero
...
Cleanup zero plugin
2016-12-25 12:35:07 -05:00
nathdwek@laptop
7de97df209
Zero: rewrite tests.
...
Rely on plugin interface only.
Unregister listeners by hand for the moment.
2016-12-25 17:10:16 +01:00
nathdwek@laptop
96d331ace0
Zero: cleanup plugin
2016-12-24 19:13:10 +01:00
Johnny Robeson
57338f803f
Use released version of Python 3.6 for travis ( #2341 )
2016-12-24 04:39:30 -05:00
Adrian Sampson
10f0d03d79
Test "true" FLAC bitrate from Mutagen 1.35
...
Fix #2343 .
2016-12-23 20:23:23 -05:00
Adrian Sampson
8cc2ac5b39
Remove stray prints ( #2333 )
2016-12-21 21:11:16 -05:00
