Commit graph

9056 commits

Author SHA1 Message Date
Adrian Sampson
247e26fea3
Merge pull request #3365 from Ruin0x11/update-incremental-skip-later-doc
Correct documentation of `incremental_skip_later` flag
2019-09-12 08:34:22 -04:00
Ian Pickering
dd85a88ba5 Correct documentation of incremental_skip_later flag
The behavior is actually the opposite of what is documented.
2019-09-11 20:14:30 -07:00
Adrian Sampson
0077c0514b
Merge pull request #3364 from kergoth/empty-album-error
library: show album id in empty album error
2019-09-10 19:04:01 -04:00
Christopher Larson
959a058458 library: show album id in empty album error
This makes it possible to recover from this case, as you can correct
whatever caused it, by either fixing album ids on tracks or removing the
empty album id.

Signed-off-by: Christopher Larson <kergoth@gmail.com>
2019-09-09 08:12:38 -07:00
Adrian Sampson
00ac5928c1 Merge pull request #3357 from RollingStar/timid_rec
Make none_rec_action respect timid. #3242
2019-09-07 12:52:52 -04:00
unknown
c9468350ec Timid always prompts. Clarify docstring. 2019-09-07 11:49:54 -04:00
unknown
80e51027e6 remove debug line 2019-09-02 20:17:00 -04:00
unknown
7754dd27c5 Make none_rec_action respect timid. #3242 2019-09-02 20:15:35 -04:00
Adrian Sampson
29fe07282b
Merge pull request #3350 from apitofme/Fix-issue-#1693
Fix for issue #1693 (Apply `data_source` field to albums)
2019-08-23 13:25:11 -04:00
Chris
e0276138db Changelog added 2019-08-23 11:34:34 +01:00
Chris
ba4430c0bf Simplified conditional test, now w/o function call 2019-08-22 19:27:23 +01:00
Chris
ece99bb330 Changed test to look for 'key' in Item.keys() 2019-08-22 15:46:00 +01:00
Chris
6146857a11 Added check + store on object (no method call) 2019-08-22 14:53:25 +01:00
Chris
67a38fc0e4 Apply data_source field to albums #1693 2019-08-22 12:18:24 +01:00
Adrian Sampson
68e1093e28
Merge pull request #3348 from Vexatos/convert-link
convert: add option to symlink or hardlink instead of copying
2019-08-21 10:54:09 -04:00
Vexatos
7aab50b7b8
convert: Reduce amount of duplicate code for linking.
Also slightly reworded documentation.
2019-08-21 12:19:47 +02:00
Vexatos
aeb7d8846e
convert: disable album-art embedding for linked files.
Fixed flag precedence of link and hardlink over their options.
Fixed formatting issue.
2019-08-20 16:40:02 +02:00
Vexatos
a61aa74061
convert: add option to hardlink instead of copying.
Overrides the --link option.

As proposed in #2324.
2019-08-20 16:07:01 +02:00
Kier Davis
4820cee35c
convert: add option to symlink instead of copying
As proposed in #2324.

Updated commit from #2326.

Co-authored-by: Vexatos <stuarzt@gmx.de>
2019-08-20 14:50:44 +02:00
Benedikt
96d61b8b93
Merge pull request #3347 from wisp3rwind/pr-fix-track-number-0
Correctly display track number 0 in show_change
2019-08-20 09:31:01 +02:00
wisp3rwind
29d6967fa7 update changelog 2019-08-20 09:29:35 +02:00
wisp3rwind
0bc3727fcf Correctly display track number 0 in show_change
fixes issue #3346: When the per_disc_numbering option was set, the UI would
previously show a #0 -> #1 change when actually the index would be set
to 0 (a valid index, such as for hidden tracks).  Now, properly
distinguish index 0 and None (i.e. not set)
2019-08-20 00:02:32 +02:00
Adrian Sampson
27e0e7600d
Merge pull request #3345 from smopucilowski/simple-clean
Refactor magic values in discogs_client
2019-08-11 08:38:57 +02:00
Sebastian Pucilowski
a2ee8da8d6 Refactor magic values in discogs_client 2019-08-11 11:21:22 +10:00
Adrian Sampson
75eb2f4621 Changelog thanks & bug link to #3343 2019-08-03 22:40:50 -04:00
Adrian Sampson
5d6366a92d Merge pull request #3343 from rhlahuja/spotify-year-unpack
Fix handling of Spotify year-only release dates
2019-08-03 22:40:12 -04:00
Rahul Ahuja
7ec3632309 Fix year assignment with year-only release date 2019-08-03 19:07:56 -07:00
Adrian Sampson
3275081d09
Merge pull request #3342 from samuelnilsson/replaygain
Fix #3341
2019-08-03 17:40:51 -04:00
Samuel Nilsson
6e24669d61 Fix #3341 2019-08-03 22:51:40 +02:00
Adrian Sampson
c74c9a46a9 Punctuation improvements 2019-08-01 09:32:33 -04:00
Adrian Sampson
345e0d5315 Merge pull request #3339 from octos/master
improve readability
2019-08-01 09:31:48 -04:00
octos
5f6d1f0f96
improve readability 2019-07-31 22:41:32 -05:00
Adrian Sampson
e4b93de616
Merge pull request #3338 from beetbox/discogs-error
Use the 'resource_url' from discogs_client to not throw exception
2019-07-30 16:46:03 -04:00
Guilherme Danno
63594386c2
Add the changelog 2019-07-30 17:09:00 -03:00
Guilherme Danno
4908028985
Use the 'resource_url' from discogs_client 2019-07-30 16:46:59 -03:00
Adrian Sampson
32b33922cb
Merge pull request #3336 from samuelnilsson/replaygain
ffmpeg replaygain backend: Only calculate replaygain for audio stream
2019-07-29 08:12:03 -04:00
Samuel Nilsson
60c174101f ffmpeg replaygain backend: Only calculate replaygain for audio stream. Fixed documentation for backend option. 2019-07-29 10:32:19 +02:00
Adrian Sampson
ddede4e39e
Merge pull request #3065 from zsinskri/r128-targetlevel-config
replaygain: target level refactor
2019-07-25 19:28:28 -04:00
Zsin Skri
e3645dfd59
Merge branch 'master' into r128-targetlevel-config 2019-07-25 23:22:32 +02:00
Zsin Skri
a9f70f8151 apply suggested improvements
Apply improvements suggested in GitHub PullRequest #3065:
- be idiomatic
  - 0 is falsy
  - check enum equality, not identity
  - mutate list by constructing a new one
- improve documentation
  - fix a typo
  - do not mention deprecation of a config option
2019-07-26 01:02:03 +02:00
Adrian Sampson
9392256993 Spelling & changelog for #3334 2019-07-24 22:13:53 -04:00
Adrian Sampson
84032e56e2 Merge pull request #3334 from MartyLake/martylake_add_forward_slash_option
Add option to force forward slashes in paths
2019-07-24 22:11:59 -04:00
MartyLake
fb96660171 Review: simpler implementation and test
Because **all** the path are bytestrings
2019-07-24 18:09:54 +02:00
MartyLake
819f03f0e0 Add special case for string 2019-07-24 10:11:32 +02:00
MartyLake
7ee11b0f1a Review: add missing lines 2019-07-24 10:08:40 +02:00
MartyLake
c52973e1c0 Review: Adds missing point to finish sentences 2019-07-24 09:53:54 +02:00
Adrian Sampson
897100cb3b
Merge pull request #3335 from malcops/feature/pm/acousticbrainz-extra-fields
Feature/pm/acousticbrainz extra fields
2019-07-23 23:04:11 -04:00
Paul Malcolm
aa17625551 changelog entry: additional acousticbrainz fields 2019-07-23 20:25:26 -04:00
Paul Malcolm
5f9a394ca9 Issue #2860 Fetch more acousticbrainz fields 2019-07-23 20:25:26 -04:00
MartyLake
076a82daa6 Review: Rename method 2019-07-24 00:09:52 +02:00