Commit graph

3057 commits

Author SHA1 Message Date
Thomas Scholtes
100b3d4d65 Make mediafile tests independent of image order
For MP3s mutagen stores image tags in a hash with the `APIC:...` key. The order
of the images is therefore not well defined. A similar issue occurs with WMAs.
2014-04-02 22:15:00 +02:00
brilnius
d02e02fe20 Merge pull request #638 from brilnius/ui_del_attr2
Modify command: ability to delete/reset an attribute (beet modify field!)
2014-04-01 22:47:03 +02:00
Bruno Tournay
cd70e92b7f Modify command: ability to delete/reset an attribute (beet modify field!) 2014-04-01 22:38:33 +02:00
Adrian Sampson
0118ef336d Merge pull request #636 from skeuomorf/notifications
Add irc notifications by travis
2014-04-01 11:01:01 -07:00
Adrian Sampson
1f5717ca97 Merge pull request #635 from skeuomorf/badges
Add badges of travis and coverage to README
2014-04-01 11:00:27 -07:00
Mohammed Attia
0ef5ce2847 Add irc notifications by travis 2014-04-01 08:18:05 +02:00
Mohammed Attia
975e010e18 Add badges of travis and coverage to README 2014-04-01 08:12:08 +02:00
Adrian Sampson
8d196a8c01 changelog for #632 2014-03-26 13:39:12 -07:00
Adrian Sampson
e628b8f3a7 Merge pull request #633 from sampsyo/issue-632
Only use primary artist aliases. Fixes #632.
2014-03-26 13:22:24 -07:00
Filipe Fortes
ea90321226 Update tests given new alias behavior 2014-03-26 13:01:42 -07:00
Filipe Fortes
ebcd540e58 Only use primary artist aliases. Fixes #632.
MusicBrainz will send down various artist aliases that may not be the primary
(e.g. the previous name for a group). Only use an alias for the artist if it is
the primary alias in one of the import locales.
2014-03-26 12:02:52 -07:00
Thomas Scholtes
b2cb87aa6d Add completion script template to dist 2014-03-26 14:38:21 +01:00
Adrian Sampson
d778443ea0 don't wrap standard errors during Mutagen save() 2014-03-25 22:44:15 -07:00
Adrian Sampson
05ebd6d28e FileOperationError: also include the file path
This makes the errors fully self-descriptive, which simplifies logging them as
errors (you just have to `log.error(exc)` to get a reasonable message). We
also now handle these at the top level in case someone forgets to add a
handler. But in this case, we also send the full traceback to the debug log.
2014-03-25 22:41:28 -07:00
Adrian Sampson
3a26845f5e FileOperationError: include underlying exception
A primitive form of Python 3's "exception chaining", which is what we really
want here. Someday...
2014-03-25 22:14:50 -07:00
Adrian Sampson
3c8decc487 some reorg/docs for FileOperationError 2014-03-24 22:37:15 -07:00
Thomas Scholtes
4a6e3f12f1 Made config.yaml link to config page
Cherry picked from e9d7e9469f which was on wrong
branch. See #626
2014-03-24 17:59:22 +01:00
geigerzaehler
3ac2c7a1d7 Merge pull request #603 from geigerzaehler/write-exception-handling
Exception handling for item writes
2014-03-24 17:55:48 +01:00
Thomas Scholtes
86b2c215f2 Remove unused import 2014-03-24 17:55:36 +01:00
geigerzaehler
7cffaf4bb3 Merge pull request #625 from geigerzaehler/nose-capture-log
Use nose to capture logs during test
2014-03-24 17:43:16 +01:00
Thomas Scholtes
574903e986 Add FileOperationError and handling in item.write() 2014-03-24 14:22:27 +01:00
Thomas Scholtes
d21406dcb0 Use nose to capture logs during test
Set the loglevel of beets to `DEBUG` but capture all logging statements with
nose. The logs are only printed when a test fails. This gives us more
information when tests fail while being completely silent on success.
2014-03-23 21:12:08 +01:00
Adrian Sampson
553d5fb4ca Merge pull request #624 from thomwiggers/patch-2
Removed gbeets
2014-03-23 07:46:44 -07:00
Thom Wiggers
a4c5c575b5 Removed gbeets
It's link only lead to a readme on GitHub, not to any code.
2014-03-23 13:13:35 +01:00
Adrian Sampson
99bbecf7f5 add a defensive assertion 2014-03-22 11:00:24 -07:00
Thomas Scholtes
85b16e4e3d Remove unused code 2014-03-22 13:25:25 +01:00
Thomas Scholtes
a399f294e8 Handle exceptions in item.write and use plugin abort 2014-03-22 13:25:25 +01:00
Thomas Scholtes
a744e8ea59 Fix missing import 2014-03-22 13:25:25 +01:00
Thomas Scholtes
ddf5233daa Add _item_write method and remove duplicate code 2014-03-22 13:25:25 +01:00
Thomas Scholtes
13cbcad581 Unify exception handling of item.write() in UI
Don’t abort the program when there is something wrong with the filesystem.
2014-03-22 13:25:25 +01:00
Thomas Scholtes
92061099fe Add BeforeWriteError for plugins
The idea is that plugins may want to prevent beets from writing a file (for
example if an integrity check failed).
2014-03-22 13:25:25 +01:00
Adrian Sampson
810841ba5a a couple new extremely basic FAQs
These are also very common questions from new users.
2014-03-21 18:04:35 -07:00
Adrian Sampson
882d2305c0 docs: emphasize that you create config.yaml
This is, shockingly, the #1 question I get asked. I hope this helps.
2014-03-21 17:55:18 -07:00
Adrian Sampson
ddddbbb919 some more thorough documentation for #614 2014-03-21 17:51:50 -07:00
Adrian Sampson
3b403937d6 Merge pull request #614 from asutherland/survive-bad-dates
Return 0 dates instead of throwing on bad dates.
2014-03-21 17:43:30 -07:00
Adrian Sampson
1fb2584a06 avoid crashes on Mutagen bugs in save() (#622) 2014-03-20 14:35:45 -07:00
yoasif
0a9b41d984 Fixing last commit
b843071100
2014-03-19 23:18:19 -04:00
yoasif
b843071100 Fixed "hacking" link to point to Developers section 2014-03-19 23:01:15 -04:00
brilnius
e1878b34e7 Merge pull request #618 from brilnius/fix615
lastgenre plugin: separator in genre lists can now be configured
2014-03-19 22:22:41 +01:00
Bruno Tournay
81b74151ca Genre separator from config must be unicode string 2014-03-19 22:16:02 +01:00
Bruno Tournay
3348c0e3c2 Typo correction 2014-03-19 22:12:56 +01:00
Adrian Sampson
b0fd64662d update docs for #619 2014-03-19 10:34:03 -07:00
Thomas Scholtes
51647e6514 Changelog for 0daea144e8 2014-03-19 17:30:15 +01:00
Thomas Scholtes
0daea144e8 Fix album import feed with slashes
Makes tests from f2da1922b28571216c7bc0eaa71f56a316dc0d5d pass.
Fixes #610 and supersedes #611.
2014-03-19 17:26:11 +01:00
Thomas Scholtes
b131922b90 Add failing importfeed tests for albums with slashes
Isolates bug in #610
2014-03-19 17:26:11 +01:00
Adrian Sampson
5b42796eea Merge pull request #619 from brilnius/fix324
Replace option: leading whitespaces are also removed by default
2014-03-18 23:22:45 -07:00
Bruno Tournay
41e7611ead Replace option: leading whitespaces are also removed by default 2014-03-18 22:25:06 +01:00
Bruno Tournay
26abd603c8 Changelog for previous change (lastgenre separator) 2014-03-18 22:12:16 +01:00
Bruno Tournay
618708916b Separator in genre lists can now be configured 2014-03-18 22:03:11 +01:00
Andrew Sutherland
e290f8dfad Use _safe_cast to avoid dying on illegal dates. 2014-03-18 01:38:04 -04:00