Commit graph

5493 commits

Author SHA1 Message Date
kooimens
0ed98515ad Embedart: remove_art_file on import
Should fix #1662.

I think the fix is easy. Don't know if it's clean though. Did some tests (+/- 10 albums), all successful. This is the first time I'm using python so please let me know what I should improve:)
2015-10-30 17:04:11 +01:00
Adrian Sampson
16ad174d29 A debug message for ReplayGain 2015-10-29 17:43:31 -04:00
Frederik “Freso” S. Olesen
0fbd8d2dfb lastgenre: Clean up of the reggae related genres.
Fixes #1661.
2015-10-29 05:06:40 +01:00
Frederik “Freso” S. Olesen
41cbb47918 Add changelog entry for #1661. 2015-10-29 05:04:59 +01:00
Frederik “Freso” S. Olesen
5f5365021d lastgenre: Clean up Spanish reggae in the genre list.
* Add missing subgenres to whitelist and tree.
* Use proper terminology.
  * Add English term as child of Spanish one.

Source: https://en.wikipedia.org/wiki/Reggae_en_Espa%C3%B1ol
2015-10-29 05:00:33 +01:00
Frederik “Freso” S. Olesen
1aa808f37b lastgenre: Add raggamuffin.
Already recognised by the genres.txt whitelist, and is a more proper
term for `ragga`.

https://en.wikipedia.org/wiki/Ragga
2015-10-29 04:58:44 +01:00
Frederik “Freso” S. Olesen
1678c1d847 lastgenre: Replace top-level genre ska with reggae
… and move relevant genres from the tree to be children of the `reggae`
top-level genre as well as add `roots reggae` to the list.

See discussion at https://github.com/sampsyo/beets/issues/1661
2015-10-29 04:55:57 +01:00
Frederik “Freso” S. Olesen
b187251a7e lastgenre: Remove dance hall and polish reggae.
Neither of the two are recognised in the genres.txt whitelist.
2015-10-29 04:53:14 +01:00
Frederik “Freso” S. Olesen
004fb7d1c8 lastgenre: Fix up ragga jungle.
* Move `ragga jungle` to beneath `oldschool jungle`.
* Remove `ragga-jungle` which isn't recognised by the genre whitelist.

https://en.wikipedia.org/wiki/Ragga_jungle
2015-10-29 04:44:15 +01:00
Adrian Sampson
2537c06ac7 Changelog for #1652 fix 2015-10-24 13:09:15 -07:00
Adrian Sampson
4c6dbe6780 Remove seen_idents set
This was used since time immemorial to keep track of recently-imported music
that hasn't hit the database yet. I created it when the importer only added
music to the database at the end of the pipeline, after doing all the work to
manipulate the metadata. Now, for several reasons, we add the music
immediately after the user sees it and then manipulate the records *in the
database*. With the latest change, which gets rid of the last separation
between UI and database-adding, we no longer need to do this.
2015-10-24 13:06:16 -07:00
Adrian Sampson
079822b893 Importer: no separate stage for applying metadata
It's cheaper and easier to just apply metadata in the UI thread. The
advantage, then, is that we no longer need to keep track of anything in-memory
to enumerate data that has been seen by the user but not added to the database
yet!

In the next step, I'll remove `seen_idents` altogether.
2015-10-24 13:03:26 -07:00
Adrian Sampson
cc5aba8294 Roll back PR #1358: regression on recent duplicate
This should fix #1652, which found that this code did the wrong thing when
there were *no* `found_duplicates`: that is, when the duplicate actually came
from the `seen_keys` list, so the album is not in the database yet. This
handling was confusing "no non-empty duplicates" with "no in-database
duplicates", and incorrectly bypassing the duplicates prompt.

Since having empty albums in the database is a rare case (it should be
impossible!), and we should no longer *crash* when it happens, I am
considering it unnecessary to handle it specially. The user will now just see
"Old: 0 items" and that's that.
2015-10-24 12:46:27 -07:00
Adrian Sampson
15190794dc Log more details about duplicates
Part of the investigation into #1652.
2015-10-24 12:39:27 -07:00
Adrian Sampson
f784cd1a22 Fix #1656, maybe: encode Discogs token strings 2015-10-24 12:07:40 -07:00
Adrian Sampson
f4a617e641 Move color option in config example (fix #1653) 2015-10-19 13:44:52 -07:00
Adrian Sampson
10dc42d1d2 Changelog for #1649 2015-10-19 13:27:29 -07:00
Adrian Sampson
3503e6d1b2 Merge branch 'master' of github.com:sampsyo/beets 2015-10-19 11:40:59 -07:00
Adrian Sampson
e937ca5c15 Fix grammar in a docstring 2015-10-19 11:12:36 -07:00
Adrian Sampson
b4ecef9d47 Merge pull request #1650 from Nerten/master
Update plexupdate.py
2015-10-19 11:00:40 -07:00
Alex Nerten
a4ae7fa891 Update plexupdate.py
Fix #1649
2015-10-19 15:24:59 +03:00
Jack Wilsdon
0a7eb9e884 Merge pull request #1648 from Kernald/patch-1
Fix example of Types plugin documentation
2015-10-18 13:29:17 +01:00
Marc Plano-Lesay
054b9728b5 Fix example of Types plugin documentation 2015-10-18 13:46:39 +02:00
Adrian Sampson
ef26d4c926 Version bump for 1.3.16 2015-10-17 17:45:46 -07:00
Adrian Sampson
60e5e388cc Add date for 1.3.15 release 2015-10-17 17:45:21 -07:00
Adrian Sampson
9524ddcfe3 Clean up changelog for 1.3.15 release 2015-10-17 17:44:34 -07:00
Adrian Sampson
0b3ecfc6e8 Doc tweaks for #1639 2015-10-17 14:52:29 -07:00
Adrian Sampson
000487c757 Merge pull request #1639 from sadatay/genius_lyrics
Add Genius as a lyric source
2015-10-17 14:51:01 -07:00
Adrian Sampson
7c6f7b2fa7 Doc tweaks and changelog for #1641 (fix #1621) 2015-10-17 14:43:16 -07:00
Adrian Sampson
8c35a24073 zero: Check for conflicts only once (#1641)
The old version would trigger the warning twice.
2015-10-17 14:39:53 -07:00
Adrian Sampson
71acf93ef3 Merge pull request #1641 from adkow/zero-whitelist
Add whitelist feature to zero plugin
2015-10-17 13:18:56 -07:00
Joe LaSala
3ab9932059 Add Genius as a lyric source
Makes use of the Genius API and genius-api.com, a separate resource that
provides readable lyrics.
2015-10-13 19:14:08 -05:00
Adrian Kowalski
d180d42ddb Fix flake8 complaint about line length 2015-10-12 09:50:12 +02:00
Adrian Kowalski
da655534ae Change function name and correct documentation style 2015-10-12 09:39:20 +02:00
Adrian Kowalski
84da4b89a5 Update documentation for zero plugin 2015-10-09 21:38:38 +02:00
Adrian Kowalski
158486319f Improve code quality, separate shared logic into functions 2015-10-09 21:23:59 +02:00
Adrian Kowalski
9f51e46bae Add whitelist feature to zero plugin 2015-10-09 18:41:42 +02:00
Adrian Sampson
13fede597f Fix my fix for #1586: iterate over views 2015-10-08 10:40:18 -07:00
Adrian Sampson
3c8823db96 Run case sensitivity check (#1586) on bytestring
This should avoid problems when querying for Unicode paths.
2015-10-07 16:38:27 -07:00
Adrian Sampson
d29cc7b2c0 Refine docs for #1586 2015-10-07 16:36:12 -07:00
Adrian Sampson
a0a9af261c Use syspath in case sensitivity check (#1586) 2015-10-07 16:33:29 -07:00
Adrian Sampson
4677903844 Reorganize case sensitivity check function
Just a little readability enhancement.
2015-10-07 16:31:59 -07:00
Adrian Sampson
9e5e9a23ab Query case sensitivity depends on the query (#1586)
This could match intuition a little more closely and also avoids a coupling
with the configuration.
2015-10-07 15:53:26 -07:00
Adrian Sampson
9bf95bf634 Some test code cleanup for #1586 2015-10-07 15:50:32 -07:00
Adrian Sampson
3b604c7ff9 Merge pull request #1586 from mried/RobustCaseSensitiveDetection
A robust way to check for a case sensitive file system
2015-10-07 15:43:38 -07:00
Adrian Sampson
9f1c113476 For #1617: Use Confit's built-in path resolution
Has the side effect of raising more reasonable errors when the type is wrong.
2015-10-07 15:36:31 -07:00
Adrian Sampson
fe1fab9aee For #1617, fix laziness with a new subclass 2015-10-07 15:32:07 -07:00
Adrian Sampson
41c5f57339 Merge pull request #1637 from pferdefleisch/fix-genre-yaml
Remove yaml keys without sublists
2015-10-07 09:21:04 -07:00
Aaron Cruz
5fd836b173 Remove yaml keys without sublists 2015-10-07 12:15:09 +02:00
David Logie
168a1645e0 Move the included file loading out of confit.py. 2015-10-05 14:01:26 +01:00