Commit graph

2364 commits

Author SHA1 Message Date
Pedro Silva
0eb70ebfa5 Merge pull request #433 from sampsyo/argparse
Add vararg_callback utility function to beets.ui
2013-10-22 12:50:07 -07:00
Pedro Silva
48b963a66e Add docstring to new varargs callback ui function 2013-10-22 21:46:46 +02:00
Pedro Silva
7299ed24c6 Add vararg_callback utility function to beets.ui
Optparse doesn't support argparse nargs='+' style arguments.  This patch
adds a callback utility function that allows that idiom. The function is
taken from the page at
http://docs.python.org/2/library/optparse.html#callback-example-6-variable-arguments.

Here's an example of how to use it:

    from beets.ui import vararg_callback
    parser.add_option("-c", "--callback", dest="vararg_attr",
                      action="callback", callback=vararg_callback)
2013-10-22 18:11:24 +02:00
Adrian Sampson
17faa0d577 declarative style for misc metadata (#428) 2013-10-21 15:13:22 -07:00
Adrian Sampson
f7c9414058 Merge pull request #428 from pcaro90/master
Added "None" check to miscellaneous metadata.
2013-10-21 15:10:30 -07:00
Pedro Silva
aad0449f56 ensure command-line --keys is also respected 2013-10-22 00:05:02 +02:00
Pedro Silva
3d862d63d5 Properly initialize keys config as a list 2013-10-21 23:53:58 +02:00
Pedro Silva
6ae10ed765 add 'keys' option to allow duplicate matching on arbitrary attributes
- towards addressing #427
- TODO: invert key list
- TODO: implement alternative strategies (fp, md5, etc)
2013-10-21 23:32:33 +02:00
Pablo Caro
5c4a30b70f Added "None" check to miscellaneous metadata.
Without a "None" check in those fields, the plugin MBSync and the "update"
command  may incur in a loop: While the MBSync plugin insists in the value
"None" (not the string "None"!) for some of the optional and misc metadata
(change which is propagated to the beets database, while maintaining the actual
value equal to an empty string in the file), the "update" command in beet
change the database back, as an empty string is found in that field in the
file. These changes are repeated every time a "mbsync" command is followed by
an "update" command.
2013-10-21 20:25:24 +02:00
Adrian Sampson
2bb2827a16 merge 2013-10-20 13:32:15 -07:00
Adrian Sampson
6ddb296c87 mediafile: add lower-case RG ID3 tags 2013-10-20 13:31:39 -07:00
Peter Schnebel
c82cd29081 requires 'self' 2013-10-18 14:10:16 +02:00
Peter Schnebel
840bf15e5b fixed typo 2013-10-18 12:52:22 +02:00
Peter Schnebel
185ef32551 removed duplicate 2013-10-17 23:39:59 +02:00
Adrian Sampson
2d2836825f #416: workaround comment, py26-ify 2013-10-17 12:10:17 -07:00
Adrian Sampson
3070ac382e lastgenre count/min_weight (#416): changelog/thanks
Also closes #407.
2013-10-17 12:07:31 -07:00
Adrian Sampson
f09bf57f6a Merge pull request #416 from pscn/master
Added min_weight option to lastgenre plugin, to provide for filtering out unpopular genres.
2013-10-17 12:00:35 -07:00
Adrian Sampson
526aa0f811 Beatport API closure (#423) 2013-10-17 11:55:00 -07:00
Peter Schnebel
6cb5e8064c make the doc 'clearer' 2013-10-17 09:57:56 +02:00
Peter Schnebel
b1570beba9 Merged the ``multiple` and `max_genres` option into one `count`` option.
Updated debug output to waste less lines.
2013-10-17 09:52:35 +02:00
Peter Schnebel
b2a23a58e2 fixed indentation 2013-10-17 09:30:26 +02:00
Adrian Sampson
225c4ed41c changelog for #420 2013-10-16 21:55:51 -07:00
Adrian Sampson
b037f777da echonest_tempo/#420: py26, line wrap, ... 2013-10-16 21:53:46 -07:00
Adrian Sampson
52312ee877 Merge pull request #420 from pscn/echonest_tempo
Fixed song matching in echonest_tempo plugin
2013-10-16 21:42:23 -07:00
Peter Schnebel
66c01adca1 use duration as another hint to find good matches 2013-10-16 12:40:27 +02:00
Peter Schnebel
fd0d8820bb Fixed detection of the correct song in EchoNest. 2013-10-16 12:19:25 +02:00
Peter Schnebel
0ff15c5c4d The way of the impatient is filled with useless commits :( 2013-10-16 11:35:26 +02:00
Peter Schnebel
fa10515799 Bugfix for Album.get_top_tracks workaround. 2013-10-16 11:31:18 +02:00
Peter Schnebel
d339e2f815 Workaround for pylast issue https://code.google.com/p/pylast/issues/detail?id=85 as suggested by @sampsyo 2013-10-16 08:45:13 +02:00
Adrian Sampson
ed44982f75 ftintitle: skip on empty albumartist (#418) 2013-10-15 10:03:15 -07:00
Peter Schnebel
c5896684f3 The following only applies when ``multiple`` is activated:
Return one valid genre even if its weight is lower then ```min_weight```.
Default for ```min_weight``` is now *10*.
Added new config option ```max_genres``` to limit the amount of genres returned.  Default is *3*.
2013-10-15 13:20:45 +02:00
Adrian Sampson
9d0824d71d slightly amend plugin requires (#419)
BPD does not need requests (it's vendored), but it does need pygst.
2013-10-14 21:24:19 -07:00
Adrian Sampson
c93f2b1fd8 Merge pull request #419 from sochotnicky/setup.py-plugin-requires
[setup.py] Add plugin requires as extras_require
2013-10-14 21:17:49 -07:00
Adrian Sampson
8e2c1bbe68 ftintitle: check artist_sort for null (fix #418) 2013-10-14 21:11:40 -07:00
Stanislav Ochotnicky
980b8bf6db [setup.py] Add plugin requires as extras_require
extras_require is not really used for installation/building but helps packagers
decide what dependencies are really needed for specific functionality
2013-10-15 01:08:52 +02:00
Adrian Sampson
e430b61e7d Merge pull request #417 from sochotnicky/update-mutagen-dep
setup.py: update version of mutagen dependency
2013-10-14 15:43:49 -07:00
Stanislav Ochotnicky
0aa9f8eedc setup.py: update version of mutagen dependency
We actually need 1.22 due to usage of update_to_v23
2013-10-14 23:09:07 +02:00
Peter Schnebel
eafceaa0ed Added min_weight option to lastgenre, to provide for filtering out unpopulare genres. 2013-10-14 12:36:39 +02:00
Adrian Sampson
9f87870a84 per_disc_numbering: fall back to global indices
If the per-medium values aren't available, use the global numbers.
2013-10-13 18:26:19 -07:00
Adrian Sampson
fac13a041e missing: tolerate disctotal == None
This problem:
http://pastebin.ca/2466454
is likely indicative of a bug elsewhere, but defensive coding seems like a
good idea here.
2013-10-13 18:22:43 -07:00
Adrian Sampson
ce7254c08a readme: more relevant plugin callouts 2013-10-13 18:02:19 -07:00
Adrian Sampson
c1c1b56419 readme: fix plugin-writing link, add mailing list link 2013-10-13 17:51:44 -07:00
Adrian Sampson
f12d589e84 version bump: 1.3.2 2013-10-12 19:43:58 -07:00
Adrian Sampson
86fec680b6 add missing ftintitle docs 2013-10-12 19:35:17 -07:00
Adrian Sampson
5127d716d1 typo 2013-10-12 19:24:25 -07:00
Adrian Sampson
b7334496d7 Added tag v1.3.1 for changeset 78ce7bd4a1d1 2013-10-12 19:05:02 -07:00
Adrian Sampson
2b82d0d813 1.3.1: changelog summary & release date 2013-10-12 19:03:51 -07:00
Adrian Sampson
20bdffcbd6 API docs: slightly less skeletal 2013-10-09 01:09:02 -07:00
Adrian Sampson
d6dac1d35b scrub: no need to save after delete()
The delete() method on Mutagen objects writes the file directly. Calling
save() was unnecessary and, in at least one case we found, could inadvertently
preserve non-standard tags that Mutagen did not understand.
2013-10-08 14:49:29 -07:00
Adrian Sampson
c0c01b2680 id3v23 config option (fix #388) 2013-10-06 20:20:18 -07:00