Commit graph

9832 commits

Author SHA1 Message Date
David Swarbrick
07b5e69f40 fetchart/artresizer: add max_filesize support (#3560)
Squashed from the PR, relevant commit messages follow below:

Added file size option to artresizer

 - In line with comments on PR, adjusted the ArtResizer API to add
   functionality to "resize to X bytes" through `max_filesize` arg

 - Adjustment to changelog.rst to include max_filesize change to ArtResizer
   and addition of new plugin.

Added explicit tests for PIL & Imagemagick Methods

 - Checks new resizing functions do reduce the filesize of images

Expose max_filesize logic to fetchart plugin

- Add syspath escaping for OS cross compatibility
- Return smaller PIL image even if max filesize not reached.
- Test resize logic against known smaller filesize (//2)
- Pass integer (not float) quality argument to PIL
- Remove Pillow from dependencies
- Implement "max_filesize" fetchart option, including
  logic to resize and rescale if maxwidth is also set.

Added tests & documentation for fetchart additions.

Tests now check that a target filesize is reached with a
higher initial quality (a difficult check to pass).

With a starting quality of 95% PIL takes 4 iterations to succeed
in lowering the example cover image to 90% its original size.
To cover all bases, the PIL loop has been changed to 5 iterations
in the worst case, and the documentation altered to reflect the
50% loss in quality this implies. This seems reasonable as users
concerned about performance would most likely be persuaded to
install ImageMagick, or remove the maximum filesize constraint.
The previous 30% figure was arbitrary.
2021-03-23 12:00:14 +01:00
Adrian Sampson
04ea754d00
Merge pull request #3844 from SamuelCook/remove_bs1770gain
Removes support for bs1770gain.
2021-01-29 08:13:00 -05:00
Samuel Cook
532ac7f291
Added entry in For packagers changelog section. 2021-01-28 09:42:58 -08:00
Samuel Cook
ff4cec2e69
Removes support for bs1770gain.
References in the documentation to this plugin were removed in
beetbox/beets#3127 (beetbox/beets#3130) but no actual code
changes were made.

This PR removes support for this dependency entirely.
2021-01-27 17:42:18 -08:00
Benedikt
16b79ad2e5
Merge pull request #3838 from wisp3rwind/pr_pipeline_remove_duplicate_code
pipeline: remove duplicate code from previous refactoring
2021-01-21 14:10:39 +01:00
wisp3rwind
848b64933c pipeline: remove duplicate code from previous refactoring 2021-01-20 15:19:06 +01:00
Adrian Sampson
8f8798647b
Merge pull request #3837 from johnhamelink/patch-2
Fixes #3834: Submitting AcoustID information for tracks which already have a fingerprint
2021-01-20 07:36:15 -05:00
John Hamelink
64944a284e
Added changelog entry for #3834 fix 2021-01-19 22:11:34 +00:00
John Hamelink
77ce69fe77
Fixes #3834:
This PR fixes a bug (#3834) where tracks which have already been fingerprinted do not return to be used by `beet submit` (part of the Chroma plugin). This results in  submission errors, as the fingerprint is omitted from the resultant payload sent to acoustID.
2021-01-19 22:05:34 +00:00
wisp3rwind
02ec2cfd57 style: whitespace fix, remove unnecessary parenthesis 2021-01-19 19:09:30 +01:00
wisp3rwind
f60ab5621a changelog spelling 2021-01-19 19:07:46 +01:00
Benedikt
6680f692f6
Merge pull request #3832 from vincentDcmps/master
Automatically choose subsonic authentication algorithm based on server version
2021-01-19 19:00:10 +01:00
vincent
2479edbe22 update changelog 2021-01-19 18:50:11 +01:00
Martin Haaß
9587caf916
convert: uses new par_map to work in parallel (#3830)
Squashed 5 commits:
* convert: uses new par_map to work in parallel
* linting
* code review: remove unneeded list syntax
* linting
* changelog addition
2021-01-19 18:47:02 +01:00
vincent
8af088c785 manage case of supysonic off 2021-01-18 18:24:25 +01:00
vincent
9b496e5027 change comparaison version method 2021-01-13 17:50:37 +01:00
Vincent Ducamps
03a665861d reformating subsonicupdate.py
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
2021-01-12 18:31:43 +01:00
Vincent Ducamps
b37c55bc0b pass get_version to private
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
2021-01-11 21:19:52 +01:00
vincent
811089af72 update test 2021-01-11 18:58:49 +01:00
vincent
375c158fc7 implement version check 2021-01-11 18:29:27 +01:00
vincent
54748ad4c9 change auth option enc by password 2021-01-11 17:56:09 +01:00
vincent
93bb114175 update doc 2021-01-11 17:55:23 +01:00
vincent
c1cc91c5e9 add old password option 2021-01-10 12:30:05 +01:00
vincent
0d5ad875d4 add .view to endpoint 2021-01-10 12:19:43 +01:00
Adrian Sampson
cbc045f1c8
Merge pull request #3822 from dosoe/beets_500
Fetch data for releases with more than 500 tracks
2021-01-08 18:09:52 -05:00
soergeld
f22c3efc10 Merge https://github.com/beetbox/beets into beets_500 2021-01-08 20:51:52 +01:00
Jack Wilsdon
dc0350d6ff Remove flake8-blind-except flake8 extension
pycodestyle 2.1.0 now raises a lint error on blind "except" statements,
whereas this library now raises a lint error on "except Exception"
instead (which is something we don't really want).
2021-01-08 18:21:07 +00:00
Dorian Soergel
db6dbbf27b
simplification 2021-01-08 17:32:37 +01:00
soergeld
422bd456f5 prepare for inclusion of work-level-rels 2021-01-07 19:49:50 +01:00
soergeld
2e4a873f57 logs and simplifications 2021-01-07 19:05:27 +01:00
Dorian Soergel
9d34d0f793
debug
Co-authored-by: Adrian Sampson <adrian@radbox.org>
2021-01-07 18:36:38 +01:00
soergeld
e54bf27546 style 2021-01-07 14:32:31 +01:00
soergeld
4d86fd8a7c logging 2021-01-07 14:28:45 +01:00
soergeld
441f0c559e Merge branch 'beets_500' of https://github.com/dosoe/beets into beets_500 2021-01-07 12:43:37 +01:00
soergeld
7afdbd49b3 TYPO 2021-01-07 12:41:42 +01:00
soergeld
c87dc08c4a move 500 to global constant 2021-01-07 12:37:40 +01:00
Dorian Soergel
5bddb6dddc
Merge branch 'master' into beets_500 2021-01-07 12:36:37 +01:00
Adrian Sampson
6a4c94120c
Merge pull request #3825 from agsimmons/fix-mpd2-warning-py2
Add Python version check for mpdstats
2021-01-06 16:14:38 -05:00
Andrew Simmons
3117cc0d31 Update changelog 2021-01-06 10:52:18 -05:00
Andrew Simmons
73a7723a15 Add python version check 2021-01-06 10:33:50 -05:00
Adrian Sampson
d94fb21bd0
Merge pull request #3824 from auguste42/master
discogs plugin: fix index_track option
2021-01-05 17:29:08 -05:00
Auguste Olivry
34c38f41bd Cosmetic fix 2021-01-05 16:15:50 +01:00
Auguste Olivry
345cf6e39b Move index handling inside coalesce_tracks 2021-01-05 16:14:36 +01:00
Auguste Olivry
a391740614 Update changelog 2021-01-05 14:25:57 +01:00
Auguste Olivry
c61d18bed3 Remove semicolon when prefix is empty 2021-01-05 14:15:22 +01:00
Auguste Olivry
8bda9f991a Keep index tracks in coalesced tracklist 2021-01-05 14:15:22 +01:00
soergeld
b691a71745 style and legibility 2021-01-01 14:56:46 +01:00
soergeld
52a85cdf18 style and legibility 2021-01-01 14:55:14 +01:00
soergeld
7da5c374cc style 2020-12-30 16:18:59 +01:00
soergeld
66379d542c style 2020-12-30 16:05:05 +01:00