Commit graph

7587 commits

Author SHA1 Message Date
Fabrice Laporte
07af27e44b Lyrics are last paragraph with class 'mxm-lyrics__content'
Remove ‘data-reactid’ from marker.
2017-05-02 23:40:25 +02:00
Fabrice Laporte
3e38a33c4a Fix PEP8 2017-05-02 23:37:20 +02:00
Fabrice Laporte
11eb90c758 Fix PEP8 2017-05-02 07:46:51 +02:00
Fabrice Laporte
3e3ad6974c Fix PEP8 2017-05-02 07:30:40 +02:00
Fabrice Laporte
fa9262d61b Disable tests that do real requests to lyrics sites by default.
Set BEETS_TEST_LYRICS_SOURCES environment variable to '1' to not skip the
tests.
2017-05-02 01:05:18 +02:00
Fabrice Laporte
d88cabc846 Divide LyricsGooglePluginTest into two classes.
Move existing tests into LyricsGooglePluginMachineryTest.
Create LyricsPluginSourcesTest class to check fetching of each source.
Some code was supposed to do that until now but was never executed as we
exited early at the "if not check_lyrics_fetched():" check.
2017-05-02 01:03:26 +02:00
Fabrice Laporte
a85dcd88c4 Store whole expected lyrics, not just keywords, but randomized 2017-05-02 00:56:56 +02:00
Fabrice Laporte
4e0527f07d Docstrings style 2017-05-02 00:54:58 +02:00
Fabrice Laporte
f8862ac0ea Sort imports 2017-05-02 00:52:07 +02:00
Fabrice Laporte
a165d6c00b Fix MusiXmatch text extraction markers 2017-05-01 23:40:09 +02:00
Fabrice Laporte
2bf58a61c3 Decode string with Unicode escape 2017-04-30 23:14:23 +02:00
Nathan Dwek
68089ac8e9 Merge pull request #2524 from beetbox/command-output-close-stdin
Close stdin when performing `command_output()`
2017-04-24 20:31:04 +02:00
Adrian Sampson
2c71092eaa Merge pull request #2526 from jwilk/errno
Don't hardcode errno constant
2017-04-23 23:14:34 -04:00
Jakub Wilk
95a868bb50 Don't hardcode errno constant
The value of ENOENT is architecture-dependent, so don't assume
it's always 2.
2017-04-23 23:28:32 +02:00
nath@home
b38f34b2c0 command_output: insure py2/3 compat
This should make #2524 pass
2017-04-22 15:52:09 +02:00
nath@home
7a08e4a978 Changelog for 2524 2017-04-22 15:07:28 +02:00
nath@home
7a3c786215 command-output: Wire subproc stdin to /dev/null
This should fix 2488, where beet convert would prevent further
inputs.
2017-04-22 15:01:31 +02:00
Adrian Sampson
80f77aea4d Merge pull request #2522 from discopatrick/date-value-field-validation-method
Date value field validation method
2017-04-21 08:48:52 -04:00
discopatrick
4dbc4134b3 consolidates the declaration and incrementing of ordinal into one line 2017-04-21 12:55:44 +01:00
discopatrick
85adbd1383 gives variable the better name of ‘ordinal’ 2017-04-20 13:36:31 +01:00
discopatrick
713c00aea7 reverts order of precisions from broadest to narrowest 2017-04-20 13:20:22 +01:00
discopatrick
ab7cc8f1ab Merge branch 'master' into date-value-field-validation-method
# Conflicts:
#	beets/dbcore/query.py
2017-04-20 13:03:25 +01:00
Adrian Sampson
fae8fcc932 ftintitle: Clarify indexing
This can only be a two-element array, so just use the index 1. This matches
better with the comments, that say "right-hand side" instead of "the last
value in the list."
2017-04-19 19:08:15 -04:00
Adrian Sampson
9d42728f7f ftintitle: Clarify control flow
Assigning to this variable made it hard to tell what the function was actually
returning.
2017-04-19 19:07:29 -04:00
Adrian Sampson
78f19db511 Merge pull request #2521 from tweitzel/master
add --yes argument to play command
2017-04-19 18:59:50 -04:00
xarph
02aa6191c1 rename --force to --yes in play plugin
fix some pep8 goo
2017-04-19 10:51:44 -07:00
Adrian Sampson
18127ce6bf Merge branch 'master' of github.com:beetbox/beets 2017-04-19 11:37:36 -04:00
Adrian Sampson
29b57fb5a7 Changelog for #2517 2017-04-19 11:36:58 -04:00
Adrian Sampson
31c7330de4 Merge pull request #2517 from discopatrick/date-value-field-validation
Date value field validation
2017-04-19 11:36:18 -04:00
Adrian Sampson
21c59bfcdd Merge pull request #2508 from Mary011196/master
OperationalError from SQlite that indicates a permissions problem.
2017-04-19 11:25:37 -04:00
discopatrick
18c512893e more flake8 updates 2017-04-19 14:10:04 +01:00
xarph
ffcaf33845 add -f argument to play command 2017-04-18 15:30:24 -07:00
Adrian Sampson
7eaaa99566 Changelog entry for #2508 2017-04-18 17:59:12 -04:00
Adrian Sampson
906bd97d46 Hint about database access errors 2017-04-18 17:57:13 -04:00
Adrian Sampson
19e09585d8 Re-raise other errors
And re-use the SQLite error string instead of a hand-written one for now.
2017-04-18 10:32:44 -04:00
Adrian Sampson
621427fa63 Reformat a docstring 2017-04-18 10:31:09 -04:00
Mary011196
e756f98845 Correcting the mistakes that Travis CI showed me 2017-04-16 17:24:48 +03:00
Adrian Sampson
512031a099 Revise changelog for #2509 2017-04-16 08:57:52 -04:00
Adrian Sampson
8a99eea146 Merge pull request #2509 from mattmurch/Issue549
Add default replace for - to _
2017-04-16 08:56:22 -04:00
Mary011196
0492741bf7 Error check with if statemetnt 2017-04-16 15:18:40 +03:00
Mary011196
f7a58447f0 Change the error name to DBAccessError 2017-04-16 15:15:45 +03:00
Adrian Sampson
346ecbc6d4 Slightly more verbose config overlay description 2017-04-15 15:43:26 -04:00
Adrian Sampson
8e58a61eb4 Remove one blank line 2017-04-15 15:34:09 -04:00
Adrian Sampson
560d003375 Merge pull request #2514 from MolarAmbiguity/master
Add info about overlaying configs, Resolves #2084
2017-04-15 15:34:00 -04:00
Adrian Sampson
a2eb6fae0b Merge pull request #2518 from jwilk/re.sub
Fix misuse of flags in re.sub() calls
2017-04-15 12:00:09 -04:00
Adrian Sampson
419d9a0667 Remove an accidentally-committed config 2017-04-15 11:52:09 -04:00
Adrian Sampson
0cbb40869a Merge pull request #2403 from antlarr/master
Run python2 or python3 depending on what's being used
2017-04-15 11:28:45 -04:00
Adrian Sampson
fb7296711c Fix Windows encoding in convert stub (#2516) 2017-04-15 11:27:19 -04:00
Adrian Sampson
e709ae6dd5 Changelog for #2516 2017-04-15 11:13:47 -04:00
Jakub Wilk
d3664ad5db Fix misuse of flags in re.sub() calls
The 4th argument of re.sub() is maximum number of substitutions,
not flags.
2017-04-15 14:44:19 +02:00