Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-01-30 03:54:21 +01:00
Code Issues Projects Releases Wiki Activity

Remove feature for separate review

Browse source
This commit is contained in:
Thomas Scholtes 2014-02-13 15:31:08 +01:00
parent d8ea108ee2
commit a825f8465f
2 changed files with 3 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
beets/mediafile.py
View file

@ -996,8 +996,6 @@ class MediaFile(object):
if self.mgfile.tags is None:
self.mgfile.add_tags()
self._dirty = False
def save(self, id3v23=False):
"""Write the object's tags back to the file.
@ -1011,7 +1009,7 @@ class MediaFile(object):
id3 = id3.tags
id3.update_to_v23()
self.mgfile.save(v2_version=3)
elif self._dirty:
else:
self.mgfile.save()
def delete(self):
@ -1025,19 +1023,6 @@ class MediaFile(object):
for tag in self.mgfile.keys():
del self.mgfile[tag]
def __setattr__(self, name, value):
if name == '_dirty':
super(MediaFile, self).__setattr__(name, value)
elif hasattr(self, name):
old_value = getattr(self, name)
super(MediaFile, self).__setattr__(name, value)
new_value = getattr(self, name)
changed = self._dirty or new_value != old_value
super(MediaFile, self).__setattr__('_dirty', changed)
else:
super(MediaFile, self).__setattr__(name, value)
super(MediaFile, self).__setattr__('_dirty', True)
# Field definitions.

3
test/test_mediafile.py
View file

@ -63,6 +63,7 @@ class ArtTestMixin(object):
self.assertEqual(mediafile.art, self.jpg_data)
# TODO include this in ReadWriteTestBase if implemented
class LazySaveTestMixin(object):
"""Mediafile should only write changes when tags have changed
"""
@ -100,7 +101,7 @@ class LazySaveTestMixin(object):
return mtime
class ReadWriteTestBase(ArtTestMixin, LazySaveTestMixin):
class ReadWriteTestBase(ArtTestMixin):
"""Test writing and reading tags. Subclasses must set ``extension`` and
``audio_properties``.
"""