From a825f8465fdfb5556fe4fdf04fccb79ab52fd64a Mon Sep 17 00:00:00 2001
From: Thomas Scholtes <thomas-scholtes@gmx.de>
Date: Thu, 13 Feb 2014 15:31:08 +0100
Subject: [PATCH] Remove feature for separate review

---
 beets/mediafile.py     | 17 +----------------
 test/test_mediafile.py |  3 ++-
 2 files changed, 3 insertions(+), 17 deletions(-)

diff --git a/beets/mediafile.py b/beets/mediafile.py
index af30d6a8a..493fe78eb 100644
--- a/beets/mediafile.py
+++ b/beets/mediafile.py
@@ -996,8 +996,6 @@ class MediaFile(object):
         if self.mgfile.tags is None:
             self.mgfile.add_tags()
 
-        self._dirty = False
-
     def save(self, id3v23=False):
         """Write the object's tags back to the file.
 
@@ -1011,7 +1009,7 @@ class MediaFile(object):
                 id3 = id3.tags
             id3.update_to_v23()
             self.mgfile.save(v2_version=3)
-        elif self._dirty:
+        else:
             self.mgfile.save()
 
     def delete(self):
@@ -1025,19 +1023,6 @@ class MediaFile(object):
             for tag in self.mgfile.keys():
                 del self.mgfile[tag]
 
-    def __setattr__(self, name, value):
-        if name == '_dirty':
-            super(MediaFile, self).__setattr__(name, value)
-        elif hasattr(self, name):
-            old_value = getattr(self, name)
-            super(MediaFile, self).__setattr__(name, value)
-            new_value = getattr(self, name)
-            changed = self._dirty or new_value != old_value
-            super(MediaFile, self).__setattr__('_dirty', changed)
-        else:
-            super(MediaFile, self).__setattr__(name, value)
-            super(MediaFile, self).__setattr__('_dirty', True)
-
 
     # Field definitions.
 
diff --git a/test/test_mediafile.py b/test/test_mediafile.py
index 0735a8e71..0c8dbb4a3 100644
--- a/test/test_mediafile.py
+++ b/test/test_mediafile.py
@@ -63,6 +63,7 @@ class ArtTestMixin(object):
         self.assertEqual(mediafile.art, self.jpg_data)
 
 
+# TODO include this in ReadWriteTestBase if implemented
 class LazySaveTestMixin(object):
     """Mediafile should only write changes when tags have changed
     """
@@ -100,7 +101,7 @@ class LazySaveTestMixin(object):
         return mtime
 
 
-class ReadWriteTestBase(ArtTestMixin, LazySaveTestMixin):
+class ReadWriteTestBase(ArtTestMixin):
     """Test writing and reading tags. Subclasses must set ``extension`` and
     ``audio_properties``.
     """