From 5db8f69bc1f475b3f094978555889e5cfcab6208 Mon Sep 17 00:00:00 2001 From: Adrian Sampson Date: Sun, 5 Jun 2016 12:37:05 -0700 Subject: [PATCH] Fix invocation signature for check_art_similarity The second argument is an Item, not a filename. --- test/test_embedart.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/test/test_embedart.py b/test/test_embedart.py index abd9a6f96..dd70d5e84 100644 --- a/test/test_embedart.py +++ b/test/test_embedart.py @@ -171,30 +171,31 @@ class ArtSimilarityTest(unittest.TestCase): mock_extract.return_value = True proc = mock_subprocess.Popen.return_value log = logging.getLogger('beets.embedart') + item = _common.item() # everything is fine proc.returncode = 0 proc.communicate.return_value = "10", "tagada" - self.assertTrue(art.check_art_similarity(log, b'path', b'path', 20)) - self.assertFalse(art.check_art_similarity(log, b'path', b'path', 5)) + self.assertTrue(art.check_art_similarity(log, item, b'path', 20)) + self.assertFalse(art.check_art_similarity(log, item, b'path', 5)) # small failure proc.returncode = 1 proc.communicate.return_value = "tagada", "10" - self.assertTrue(art.check_art_similarity(log, b'path', b'path', 20)) - self.assertFalse(art.check_art_similarity(log, b'path', b'path', 5)) + self.assertTrue(art.check_art_similarity(log, item, b'path', 20)) + self.assertFalse(art.check_art_similarity(log, item, b'path', 5)) # bigger failure proc.returncode = 2 - self.assertIsNone(art.check_art_similarity(log, b'path', b'path', 20)) + self.assertIsNone(art.check_art_similarity(log, item, b'path', 20)) # IM result parsing problems proc.returncode = 0 proc.communicate.return_value = "foo", "bar" - self.assertIsNone(art.check_art_similarity(log, b'path', b'path', 20)) + self.assertIsNone(art.check_art_similarity(log, item, b'path', 20)) proc.returncode = 1 - self.assertIsNone(art.check_art_similarity(log, b'path', b'path', 20)) + self.assertIsNone(art.check_art_similarity(log, item, b'path', 20)) def suite():