mirror of
https://github.com/stashapp/stash.git
synced 2025-12-06 08:26:00 +01:00
* Don't capitalize local variables
ValidCodecs -> validCodecs
* Capitalize deprecation markers
A deprecated marker should be capitalized.
* Use re.MustCompile for static regexes
If the regex fails to compile, it's a programmer error, and should be
treated as such. The regex is entirely static.
* Simplify else-if constructions
Rewrite
else { if cond {}}
to
else if cond {}
* Use a switch statement to analyze formats
Break an if-else chain. While here, simplify code flow.
Also introduce a proper static error for unsupported image formats,
paving the way for being able to check against the error.
* Rewrite ifElse chains into switch statements
The "Effective Go" https://golang.org/doc/effective_go#switch document
mentions it is more idiomatic to write if-else chains as switches when
it is possible.
Find all the plain rewrite occurrences in the code base and rewrite.
In some cases, the if-else chains are replaced by a switch scrutinizer.
That is, the code sequence
if x == 1 {
..
} else if x == 2 {
..
} else if x == 3 {
...
}
can be rewritten into
switch x {
case 1:
..
case 2:
..
case 3:
..
}
which is clearer for the compiler: it can decide if the switch is
better served by a jump-table then a branch-chain.
* Rewrite switches, introduce static errors
Introduce two new static errors:
* `ErrNotImplmented`
* `ErrNotSupported`
And use these rather than forming new generative errors whenever the
code is called. Code can now test on the errors (since they are static
and the pointers to them wont change).
Also rewrite ifElse chains into switches in this part of the code base.
* Introduce a StashBoxError in configuration
Since all stashbox errors are the same, treat them as such in the code
base. While here, rewrite an ifElse chain.
In the future, it might be beneifical to refactor configuration errors
into one error which can handle missing fields, which context the error
occurs in and so on. But for now, try to get an overview of the error
categories by hoisting them into static errors.
* Get rid of an else-block in transaction handling
If we succesfully `recover()`, we then always `panic()`. This means the
rest of the code is not reachable, so we can avoid having an else-block
here.
It also solves an ifElse-chain style check in the code base.
* Use strings.ReplaceAll
Rewrite
strings.Replace(s, o, n, -1)
into
strings.ReplaceAll(s, o, n)
To make it consistent and clear that we are doing an all-replace in the
string rather than replacing parts of it. It's more of a nitpick since
there are no implementation differences: the stdlib implementation is
just to supply -1.
* Rewrite via gocritic's assignOp
Statements of the form
x = x + e
is rewritten into
x += e
where applicable.
* Formatting
* Review comments handled
Stash-box is a proper noun.
Rewrite a switch into an if-chain which returns on the first error
encountered.
* Use context.TODO() over context.Background()
Patch in the same vein as everything else: use the TODO() marker so we
can search for it later and link it into the context tree/tentacle once
it reaches down to this level in the code base.
* Tell the linter to ignore a section in manager_tasks.go
The section is less readable, so mark it with a nolint for now. Because
the rewrite enables a ifElseChain, also mark that as nolint for now.
* Use strings.ReplaceAll over strings.Replace
* Apply an ifElse rewrite
else { if .. { .. } } rewrite into else if { .. }
* Use switch-statements over ifElseChains
Rewrite chains of if-else into switch statements. Where applicable,
add an early nil-guard to simplify case analysis. Also, in
ScanTask's Start(..), invert the logic to outdent the whole block, and
help the reader: if it's not a scene, the function flow is now far more
local to the top of the function, and it's clear that the rest of the
function has to do with scene management.
* Enable gocritic on the code base.
Disable appendAssign for now since we aren't passing that check yet.
* Document the nolint additions
* Document StashBoxBatchPerformerTagInput
251 lines
7.5 KiB
Go
251 lines
7.5 KiB
Go
package sqlite
|
|
|
|
import (
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
"math/rand"
|
|
"regexp"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/stashapp/stash/pkg/logger"
|
|
"github.com/stashapp/stash/pkg/models"
|
|
)
|
|
|
|
var randomSortFloat = rand.Float64()
|
|
|
|
func selectAll(tableName string) string {
|
|
idColumn := getColumn(tableName, "*")
|
|
return "SELECT " + idColumn + " FROM " + tableName + " "
|
|
}
|
|
|
|
func selectDistinctIDs(tableName string) string {
|
|
idColumn := getColumn(tableName, "id")
|
|
return "SELECT DISTINCT " + idColumn + " FROM " + tableName + " "
|
|
}
|
|
|
|
func getColumn(tableName string, columnName string) string {
|
|
return tableName + "." + columnName
|
|
}
|
|
|
|
func getPagination(findFilter *models.FindFilterType) string {
|
|
if findFilter == nil {
|
|
panic("nil find filter for pagination")
|
|
}
|
|
|
|
if findFilter.IsGetAll() {
|
|
return " "
|
|
}
|
|
|
|
return getPaginationSQL(findFilter.GetPage(), findFilter.GetPageSize())
|
|
}
|
|
|
|
func getPaginationSQL(page int, perPage int) string {
|
|
page = (page - 1) * perPage
|
|
return " LIMIT " + strconv.Itoa(perPage) + " OFFSET " + strconv.Itoa(page) + " "
|
|
}
|
|
|
|
func getSortDirection(direction string) string {
|
|
if direction != "ASC" && direction != "DESC" {
|
|
return "ASC"
|
|
} else {
|
|
return direction
|
|
}
|
|
}
|
|
func getSort(sort string, direction string, tableName string) string {
|
|
direction = getSortDirection(direction)
|
|
|
|
const randomSeedPrefix = "random_"
|
|
|
|
switch {
|
|
case strings.HasSuffix(sort, "_count"):
|
|
var relationTableName = strings.TrimSuffix(sort, "_count") // TODO: pluralize?
|
|
colName := getColumn(relationTableName, "id")
|
|
return " ORDER BY COUNT(distinct " + colName + ") " + direction
|
|
case strings.Compare(sort, "filesize") == 0:
|
|
colName := getColumn(tableName, "size")
|
|
return " ORDER BY cast(" + colName + " as integer) " + direction
|
|
case strings.HasPrefix(sort, randomSeedPrefix):
|
|
// seed as a parameter from the UI
|
|
// turn the provided seed into a float
|
|
seedStr := "0." + sort[len(randomSeedPrefix):]
|
|
seed, err := strconv.ParseFloat(seedStr, 32)
|
|
if err != nil {
|
|
// fallback to default seed
|
|
seed = randomSortFloat
|
|
}
|
|
return getRandomSort(tableName, direction, seed)
|
|
case strings.Compare(sort, "random") == 0:
|
|
return getRandomSort(tableName, direction, randomSortFloat)
|
|
default:
|
|
colName := getColumn(tableName, sort)
|
|
var additional string
|
|
if tableName == "scenes" {
|
|
additional = ", bitrate DESC, framerate DESC, scenes.rating DESC, scenes.duration DESC"
|
|
} else if tableName == "scene_markers" {
|
|
additional = ", scene_markers.scene_id ASC, scene_markers.seconds ASC"
|
|
}
|
|
if strings.Compare(sort, "name") == 0 {
|
|
return " ORDER BY " + colName + " COLLATE NOCASE " + direction + additional
|
|
}
|
|
if strings.Compare(sort, "title") == 0 {
|
|
return " ORDER BY " + colName + " COLLATE NATURAL_CS " + direction + additional
|
|
}
|
|
|
|
return " ORDER BY " + colName + " " + direction + additional
|
|
}
|
|
}
|
|
|
|
func getRandomSort(tableName string, direction string, seed float64) string {
|
|
// https://stackoverflow.com/a/24511461
|
|
colName := getColumn(tableName, "id")
|
|
randomSortString := strconv.FormatFloat(seed, 'f', 16, 32)
|
|
return " ORDER BY " + "(substr(" + colName + " * " + randomSortString + ", length(" + colName + ") + 2))" + " " + direction
|
|
}
|
|
|
|
func getCountSort(primaryTable, joinTable, primaryFK, direction string) string {
|
|
return fmt.Sprintf(" ORDER BY (SELECT COUNT(*) FROM %s WHERE %s = %s.id) %s", joinTable, primaryFK, primaryTable, getSortDirection(direction))
|
|
}
|
|
|
|
func getSearchBinding(columns []string, q string, not bool) (string, []interface{}) {
|
|
var likeClauses []string
|
|
var args []interface{}
|
|
|
|
notStr := ""
|
|
binaryType := " OR "
|
|
if not {
|
|
notStr = " NOT"
|
|
binaryType = " AND "
|
|
}
|
|
q = strings.TrimSpace(q)
|
|
trimmedQuery := strings.Trim(q, "\"")
|
|
|
|
if trimmedQuery == q {
|
|
q = regexp.MustCompile(`\s+`).ReplaceAllString(q, " ")
|
|
queryWords := strings.Split(q, " ")
|
|
// Search for any word
|
|
for _, word := range queryWords {
|
|
for _, column := range columns {
|
|
likeClauses = append(likeClauses, column+notStr+" LIKE ?")
|
|
args = append(args, "%"+word+"%")
|
|
}
|
|
}
|
|
} else {
|
|
// Search the exact query
|
|
for _, column := range columns {
|
|
likeClauses = append(likeClauses, column+notStr+" LIKE ?")
|
|
args = append(args, "%"+trimmedQuery+"%")
|
|
}
|
|
}
|
|
likes := strings.Join(likeClauses, binaryType)
|
|
|
|
return "(" + likes + ")", args
|
|
}
|
|
|
|
func getInBinding(length int) string {
|
|
bindings := strings.Repeat("?, ", length)
|
|
bindings = strings.TrimRight(bindings, ", ")
|
|
return "(" + bindings + ")"
|
|
}
|
|
|
|
func getSimpleCriterionClause(criterionModifier models.CriterionModifier, rhs string) (string, int) {
|
|
if modifier := criterionModifier.String(); criterionModifier.IsValid() {
|
|
switch modifier {
|
|
case "EQUALS":
|
|
return "= " + rhs, 1
|
|
case "NOT_EQUALS":
|
|
return "!= " + rhs, 1
|
|
case "GREATER_THAN":
|
|
return "> " + rhs, 1
|
|
case "LESS_THAN":
|
|
return "< " + rhs, 1
|
|
case "IS_NULL":
|
|
return "IS NULL", 0
|
|
case "NOT_NULL":
|
|
return "IS NOT NULL", 0
|
|
case "BETWEEN":
|
|
return "BETWEEN (" + rhs + ") AND (" + rhs + ")", 2
|
|
case "NOT_BETWEEN":
|
|
return "NOT BETWEEN (" + rhs + ") AND (" + rhs + ")", 2
|
|
default:
|
|
logger.Errorf("todo")
|
|
return "= ?", 1 // TODO
|
|
}
|
|
}
|
|
|
|
return "= ?", 1 // TODO
|
|
}
|
|
|
|
func getIntCriterionWhereClause(column string, input models.IntCriterionInput) (string, []interface{}) {
|
|
binding, _ := getSimpleCriterionClause(input.Modifier, "?")
|
|
var args []interface{}
|
|
|
|
switch input.Modifier {
|
|
case "EQUALS", "NOT_EQUALS":
|
|
args = []interface{}{input.Value}
|
|
case "LESS_THAN":
|
|
args = []interface{}{input.Value}
|
|
case "GREATER_THAN":
|
|
args = []interface{}{input.Value}
|
|
case "BETWEEN", "NOT_BETWEEN":
|
|
upper := 0
|
|
if input.Value2 != nil {
|
|
upper = *input.Value2
|
|
}
|
|
args = []interface{}{input.Value, upper}
|
|
}
|
|
|
|
return column + " " + binding, args
|
|
}
|
|
|
|
// returns where clause and having clause
|
|
func getMultiCriterionClause(primaryTable, foreignTable, joinTable, primaryFK, foreignFK string, criterion *models.MultiCriterionInput) (string, string) {
|
|
whereClause := ""
|
|
havingClause := ""
|
|
switch criterion.Modifier {
|
|
case models.CriterionModifierIncludes:
|
|
// includes any of the provided ids
|
|
whereClause = foreignTable + ".id IN " + getInBinding(len(criterion.Value))
|
|
case models.CriterionModifierIncludesAll:
|
|
// includes all of the provided ids
|
|
whereClause = foreignTable + ".id IN " + getInBinding(len(criterion.Value))
|
|
havingClause = "count(distinct " + foreignTable + ".id) IS " + strconv.Itoa(len(criterion.Value))
|
|
case models.CriterionModifierExcludes:
|
|
// excludes all of the provided ids
|
|
if joinTable != "" {
|
|
whereClause = primaryTable + ".id not in (select " + joinTable + "." + primaryFK + " from " + joinTable + " where " + joinTable + "." + foreignFK + " in " + getInBinding(len(criterion.Value)) + ")"
|
|
} else {
|
|
whereClause = "not exists (select s.id from " + primaryTable + " as s where s.id = " + primaryTable + ".id and s." + foreignFK + " in " + getInBinding(len(criterion.Value)) + ")"
|
|
}
|
|
}
|
|
|
|
return whereClause, havingClause
|
|
}
|
|
|
|
func getCountCriterionClause(primaryTable, joinTable, primaryFK string, criterion models.IntCriterionInput) (string, []interface{}) {
|
|
lhs := fmt.Sprintf("(SELECT COUNT(*) FROM %s s WHERE s.%s = %s.id)", joinTable, primaryFK, primaryTable)
|
|
return getIntCriterionWhereClause(lhs, criterion)
|
|
}
|
|
|
|
func getImage(tx dbi, query string, args ...interface{}) ([]byte, error) {
|
|
rows, err := tx.Queryx(query, args...)
|
|
|
|
if err != nil && !errors.Is(err, sql.ErrNoRows) {
|
|
return nil, err
|
|
}
|
|
defer rows.Close()
|
|
|
|
var ret []byte
|
|
if rows.Next() {
|
|
if err := rows.Scan(&ret); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
if err := rows.Err(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return ret, nil
|
|
}
|