mirror of
https://github.com/stashapp/stash.git
synced 2025-12-08 01:13:09 +01:00
* Add migration script for tag relations table * Expand hierarchical filter features Expand the features of the hierarchical multi input filter with support for using a relations table, which only has parent_id and child_id columns, and support adding an additional intermediate table to join on, for example for scenes and tags which are linked by the scenes_tags table as well. * Add hierarchical filtering for tags * Add hierarchical tags support to scene markers Refactor filtering of scene markers to filterBuilder and in the process add support for hierarchical tags as well. * List parent and child tags on tag details page * Support setting parent and child tags Add support for setting parent and child tags during tag creation and tag updates. * Validate no loops are created in tags hierarchy * Update tag merging to support tag hierarcy * Add unit tests for tags.EnsureUniqueHierarchy * Fix applying recursive to with clause The SQL `RECURSIVE` of a `WITH` clause only needs to be applied once, imediately after the `WITH`. So this fixes the query building to do just that, automatically applying the `RECURSIVE` keyword when any added with clause is added as recursive. * Rename hierarchical root id column * Rewrite hierarchical filtering for performance Completely rewrite the hierarchical filtering to optimize for performance. Doing the recursive query in combination with a complex query seems to break SQLite optimizing some things which means that the recursive part might be 2,5 second slower than adding a static `VALUES()` list. This is mostly noticable in case of the tag hierarchy where setting an exclusion with any depth (or depth: all) being applied has this performance impact of 2,5 second. "Include" also suffered this issue, but some rewritten query by joining in the *_tags table in one pass and applying a `WHERE x IS NOT NULL` filter did seem to optimize that case. But that optimization isn't applied to the `IS NULL` filter of "exclude". Running a simple query beforehand to get all (recursive) items and then applying them to the query doesn't have this performance penalty. * Remove UI references to child studios and tags * Add parents to tag export * Support importing of parent relationship for tags * Assign stable ids to parent / child badges * Silence Apollo warning on parents/children fields on tags Silence warning triggered by Apollo GraphQL by explicitly instructing it to use the incoming parents/children values. By default it already does this, but it triggers a warning as it might be unintended that it uses the incoming values (instead of for example merging both arrays). Setting merge to false still applies the same behaviour (use only incoming values) but silences the warning as it's explicitly configured to work like this. * Rework detecting unique tag hierarchy Completely rework the unique tag hierarchy to detect invalid hierarchies for which a tag is "added in the middle". So when there are tags A <- B and A <- C, you could previously edit tag B and add tag C as a sub tag without it being noticed as parent A being applied twice (to tag C). While afterwards saving tag C would fail as tag A was applied as parent twice. The updated code correctly detects this scenario as well. Furthermore the error messaging has been reworked a bit and the message now mentions both the direct parent / sub tag as well as the tag which would results in the error. So in aboves example it would now show the message that tag C can't be applied because tag A already is a parent. * Update relations on cached tags when needed Update the relations on cached tags when a tag is created / updated / deleted so these always reflect the correct state. Otherwise (re)opening a tag might still show the old relations untill the page is fully reloaded or the list is navigated. But this obviously is strange when you for example have tag A, create or update tag B to have a relation to tag A, and from tags B page click through to tag A and it doesn't show that it is linked to tag B.
296 lines
7 KiB
Go
296 lines
7 KiB
Go
package database
|
|
|
|
import (
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/fvbommel/sortorder"
|
|
"github.com/gobuffalo/packr/v2"
|
|
"github.com/golang-migrate/migrate/v4"
|
|
sqlite3mig "github.com/golang-migrate/migrate/v4/database/sqlite3"
|
|
"github.com/golang-migrate/migrate/v4/source"
|
|
"github.com/jmoiron/sqlx"
|
|
sqlite3 "github.com/mattn/go-sqlite3"
|
|
|
|
"github.com/stashapp/stash/pkg/logger"
|
|
"github.com/stashapp/stash/pkg/utils"
|
|
)
|
|
|
|
var DB *sqlx.DB
|
|
var WriteMu *sync.Mutex
|
|
var dbPath string
|
|
var appSchemaVersion uint = 26
|
|
var databaseSchemaVersion uint
|
|
|
|
var (
|
|
// ErrMigrationNeeded indicates that a database migration is needed
|
|
// before the database can be initialized
|
|
ErrMigrationNeeded = errors.New("database migration required")
|
|
|
|
// ErrDatabaseNotInitialized indicates that the database is not
|
|
// initialized, usually due to an incomplete configuration.
|
|
ErrDatabaseNotInitialized = errors.New("database not initialized")
|
|
)
|
|
|
|
const sqlite3Driver = "sqlite3ex"
|
|
|
|
// Ready returns an error if the database is not ready to begin transactions.
|
|
func Ready() error {
|
|
if DB == nil {
|
|
return ErrDatabaseNotInitialized
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func init() {
|
|
// register custom driver with regexp function
|
|
registerCustomDriver()
|
|
}
|
|
|
|
// Initialize initializes the database. If the database is new, then it
|
|
// performs a full migration to the latest schema version. Otherwise, any
|
|
// necessary migrations must be run separately using RunMigrations.
|
|
// Returns true if the database is new.
|
|
func Initialize(databasePath string) error {
|
|
dbPath = databasePath
|
|
|
|
if err := getDatabaseSchemaVersion(); err != nil {
|
|
return fmt.Errorf("error getting database schema version: %s", err.Error())
|
|
}
|
|
|
|
if databaseSchemaVersion == 0 {
|
|
// new database, just run the migrations
|
|
if err := RunMigrations(); err != nil {
|
|
return fmt.Errorf("error running initial schema migrations: %s", err.Error())
|
|
}
|
|
// RunMigrations calls Initialise. Just return
|
|
return nil
|
|
} else {
|
|
if databaseSchemaVersion > appSchemaVersion {
|
|
panic(fmt.Sprintf("Database schema version %d is incompatible with required schema version %d", databaseSchemaVersion, appSchemaVersion))
|
|
}
|
|
|
|
// if migration is needed, then don't open the connection
|
|
if NeedsMigration() {
|
|
logger.Warnf("Database schema version %d does not match required schema version %d.", databaseSchemaVersion, appSchemaVersion)
|
|
return nil
|
|
}
|
|
}
|
|
|
|
const disableForeignKeys = false
|
|
DB = open(databasePath, disableForeignKeys)
|
|
WriteMu = &sync.Mutex{}
|
|
|
|
return nil
|
|
}
|
|
|
|
func Close() error {
|
|
WriteMu.Lock()
|
|
defer WriteMu.Unlock()
|
|
|
|
return DB.Close()
|
|
}
|
|
|
|
func open(databasePath string, disableForeignKeys bool) *sqlx.DB {
|
|
// https://github.com/mattn/go-sqlite3
|
|
url := "file:" + databasePath + "?_journal=WAL"
|
|
if !disableForeignKeys {
|
|
url += "&_fk=true"
|
|
}
|
|
|
|
conn, err := sqlx.Open(sqlite3Driver, url)
|
|
conn.SetMaxOpenConns(25)
|
|
conn.SetMaxIdleConns(4)
|
|
conn.SetConnMaxLifetime(30 * time.Second)
|
|
if err != nil {
|
|
logger.Fatalf("db.Open(): %q\n", err)
|
|
}
|
|
|
|
return conn
|
|
}
|
|
|
|
func Reset(databasePath string) error {
|
|
err := DB.Close()
|
|
|
|
if err != nil {
|
|
return errors.New("Error closing database: " + err.Error())
|
|
}
|
|
|
|
err = os.Remove(databasePath)
|
|
if err != nil {
|
|
return errors.New("Error removing database: " + err.Error())
|
|
}
|
|
|
|
// remove the -shm, -wal files ( if they exist )
|
|
walFiles := []string{databasePath + "-shm", databasePath + "-wal"}
|
|
for _, wf := range walFiles {
|
|
if exists, _ := utils.FileExists(wf); exists {
|
|
err = os.Remove(wf)
|
|
if err != nil {
|
|
return errors.New("Error removing database: " + err.Error())
|
|
}
|
|
}
|
|
}
|
|
|
|
Initialize(databasePath)
|
|
return nil
|
|
}
|
|
|
|
// Backup the database. If db is nil, then uses the existing database
|
|
// connection.
|
|
func Backup(db *sqlx.DB, backupPath string) error {
|
|
if db == nil {
|
|
var err error
|
|
db, err = sqlx.Connect(sqlite3Driver, "file:"+dbPath+"?_fk=true")
|
|
if err != nil {
|
|
return fmt.Errorf("Open database %s failed:%s", dbPath, err)
|
|
}
|
|
defer db.Close()
|
|
}
|
|
|
|
logger.Infof("Backing up database into: %s", backupPath)
|
|
_, err := db.Exec(`VACUUM INTO "` + backupPath + `"`)
|
|
if err != nil {
|
|
return fmt.Errorf("vacuum failed: %s", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func RestoreFromBackup(backupPath string) error {
|
|
logger.Infof("Restoring backup database %s into %s", backupPath, dbPath)
|
|
return os.Rename(backupPath, dbPath)
|
|
}
|
|
|
|
// Migrate the database
|
|
func NeedsMigration() bool {
|
|
return databaseSchemaVersion != appSchemaVersion
|
|
}
|
|
|
|
func AppSchemaVersion() uint {
|
|
return appSchemaVersion
|
|
}
|
|
|
|
func DatabasePath() string {
|
|
return dbPath
|
|
}
|
|
|
|
func DatabaseBackupPath() string {
|
|
return fmt.Sprintf("%s.%d.%s", dbPath, databaseSchemaVersion, time.Now().Format("20060102_150405"))
|
|
}
|
|
|
|
func Version() uint {
|
|
return databaseSchemaVersion
|
|
}
|
|
|
|
func getMigrate() (*migrate.Migrate, error) {
|
|
migrationsBox := packr.New("Migrations Box", "./migrations")
|
|
packrSource := &Packr2Source{
|
|
Box: migrationsBox,
|
|
Migrations: source.NewMigrations(),
|
|
}
|
|
|
|
databasePath := utils.FixWindowsPath(dbPath)
|
|
s, _ := WithInstance(packrSource)
|
|
|
|
const disableForeignKeys = true
|
|
conn := open(databasePath, disableForeignKeys)
|
|
|
|
driver, err := sqlite3mig.WithInstance(conn.DB, &sqlite3mig.Config{})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// use sqlite3Driver so that migration has access to durationToTinyInt
|
|
return migrate.NewWithInstance(
|
|
"packr2",
|
|
s,
|
|
databasePath,
|
|
driver,
|
|
)
|
|
}
|
|
|
|
func getDatabaseSchemaVersion() error {
|
|
m, err := getMigrate()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
databaseSchemaVersion, _, _ = m.Version()
|
|
m.Close()
|
|
return nil
|
|
}
|
|
|
|
// Migrate the database
|
|
func RunMigrations() error {
|
|
m, err := getMigrate()
|
|
if err != nil {
|
|
panic(err.Error())
|
|
}
|
|
|
|
databaseSchemaVersion, _, _ = m.Version()
|
|
stepNumber := appSchemaVersion - databaseSchemaVersion
|
|
if stepNumber != 0 {
|
|
logger.Infof("Migrating database from version %d to %d", databaseSchemaVersion, appSchemaVersion)
|
|
err = m.Steps(int(stepNumber))
|
|
if err != nil {
|
|
// migration failed
|
|
logger.Errorf("Error migrating database: %s", err.Error())
|
|
m.Close()
|
|
return err
|
|
}
|
|
}
|
|
|
|
m.Close()
|
|
|
|
// re-initialise the database
|
|
Initialize(dbPath)
|
|
|
|
// run a vacuum on the database
|
|
logger.Info("Performing vacuum on database")
|
|
_, err = DB.Exec("VACUUM")
|
|
if err != nil {
|
|
logger.Warnf("error while performing post-migration vacuum: %s", err.Error())
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func registerCustomDriver() {
|
|
sql.Register(sqlite3Driver,
|
|
&sqlite3.SQLiteDriver{
|
|
ConnectHook: func(conn *sqlite3.SQLiteConn) error {
|
|
funcs := map[string]interface{}{
|
|
"regexp": regexFn,
|
|
"durationToTinyInt": durationToTinyIntFn,
|
|
}
|
|
|
|
for name, fn := range funcs {
|
|
if err := conn.RegisterFunc(name, fn, true); err != nil {
|
|
return fmt.Errorf("error registering function %s: %s", name, err.Error())
|
|
}
|
|
}
|
|
|
|
// COLLATE NATURAL_CS - Case sensitive natural sort
|
|
err := conn.RegisterCollation("NATURAL_CS", func(s string, s2 string) int {
|
|
if sortorder.NaturalLess(s, s2) {
|
|
return -1
|
|
} else {
|
|
return 1
|
|
}
|
|
})
|
|
|
|
if err != nil {
|
|
return fmt.Errorf("error registering natural sort collation: %s", err.Error())
|
|
}
|
|
|
|
return nil
|
|
},
|
|
},
|
|
)
|
|
}
|