mirror of
https://github.com/stashapp/stash.git
synced 2026-01-30 12:02:55 +01:00
* Make copies of buffers Avoid reusing one of the incoming arrays as a append extension, and make a copy of the data. It's cleaner in the long run and possibly easier for the GC to maintain. * Avoid appendAssign problems in tag code Reuse the existing slice when appending. * Fix appendAssign in encoder_scene_preview_chunk Appending and creating a new slice is somewhat unintuitive since the underlying slice might be extended to satisfy the new capacity. This sometimes leads to faulty logic. Rewrite the code so it reuses `args` for all appending, and builds one array clearly in the code. It follows the general style of the function where `args` is being built in small incremental batches and avoids the introduction of new names. * Enable the appendAssign check This makes us pass all gocritic warnings. Co-authored-by: WithoutPants <53250216+WithoutPants@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| api | ||
| autotag | ||
| database | ||
| dlna | ||
| ffmpeg | ||
| file | ||
| gallery | ||
| image | ||
| job | ||
| logger | ||
| manager | ||
| match | ||
| models | ||
| movie | ||
| performer | ||
| plugin | ||
| scene | ||
| scraper | ||
| session | ||
| sqlite | ||
| static | ||
| studio | ||
| tag | ||
| utils | ||