mirror of
https://github.com/stashapp/stash.git
synced 2025-12-10 18:32:30 +01:00
87709fd018
* Avoid redundant logging in migrations
Return the error and let the caller handle the logging of the error if
needed.
While here, defer m.Close() to the function boundary.
* Treat errors as values
Use %v rather than %s and pass the errors directly.
* Generate a wrapped error on stat-failure
* Log 3 unchecked errors
Rather than ignore errors, log them at
the WARNING log level.
The server has been functioning without these, so assume they are not at
the ERROR level.
* Propagate errors upward
Failure in path generation was ignored. Propagate the errors upward the
call stack, so it can be handled at the level of orchestration.
* Warn on errors
Log errors rather than quenching them.
Errors are logged at the Warn-level for now.
* Check error when creating test databases
Use the builtin log package and stop the program fatally on error.
* Add warnings to uncheck task errors
Focus on the task system in a single commit, logging unchecked
errors as warnings.
* Warn-on-error in API routes
Look through the API routes, and make sure errors are being logged if
they occur. Prefer the Warn-log-level because none of these has proven
to be fatal in the system up until now.
* Propagate error when adding Util API
* Propagate error on adding util API
* Return unhandled error
* JS log API: propagate and log errors
* JS Plugins: log GQL addition failures.
* Warn on failure to write to stdin
* Warn on failure to stop task
* Wrap viper.BindEnv
The current viper code only errors if no name is provided, so it should
never fail. Rewrite the code flow to factor through a panic-function.
This removes error warnings from this part of the code.
* Log errors in concurrency test
If we can't initialize the configuration, treat the test as a failure.
* Warn on errors in configuration code
* Plug an unchecked error in gallery zip walking
* Warn on screenshot serving failure
* Warn on encoder screenshot failure
* Warn on errors in path-handling code
* Undo the errcheck on configurations for now.
* Use one-line initializers where applicable
rather than using
err := f()
if err!= nil { ..
prefer the shorter
if err := f(); err != nil { ..
If f() isn't too long of a name, or wraps a function with a body.
106 lines
2.8 KiB
Go
106 lines
2.8 KiB
Go
package manager
|
|
|
|
import (
|
|
"net/http"
|
|
"sync"
|
|
|
|
"github.com/stashapp/stash/pkg/ffmpeg"
|
|
"github.com/stashapp/stash/pkg/logger"
|
|
"github.com/stashapp/stash/pkg/manager/config"
|
|
"github.com/stashapp/stash/pkg/models"
|
|
"github.com/stashapp/stash/pkg/utils"
|
|
)
|
|
|
|
var (
|
|
streamingFiles = make(map[string][]*http.ResponseWriter)
|
|
streamingFilesMutex = sync.RWMutex{}
|
|
)
|
|
|
|
func RegisterStream(filepath string, w *http.ResponseWriter) {
|
|
streamingFilesMutex.Lock()
|
|
streams := streamingFiles[filepath]
|
|
streamingFiles[filepath] = append(streams, w)
|
|
streamingFilesMutex.Unlock()
|
|
}
|
|
|
|
func deregisterStream(filepath string, w *http.ResponseWriter) {
|
|
streamingFilesMutex.Lock()
|
|
defer streamingFilesMutex.Unlock()
|
|
streams := streamingFiles[filepath]
|
|
|
|
for i, v := range streams {
|
|
if v == w {
|
|
streamingFiles[filepath] = append(streams[:i], streams[i+1:]...)
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
func WaitAndDeregisterStream(filepath string, w *http.ResponseWriter, r *http.Request) {
|
|
notify := r.Context().Done()
|
|
go func() {
|
|
<-notify
|
|
deregisterStream(filepath, w)
|
|
}()
|
|
}
|
|
|
|
func KillRunningStreams(path string) {
|
|
ffmpeg.KillRunningEncoders(path)
|
|
|
|
streamingFilesMutex.RLock()
|
|
streams := streamingFiles[path]
|
|
streamingFilesMutex.RUnlock()
|
|
|
|
for _, w := range streams {
|
|
hj, ok := (*w).(http.Hijacker)
|
|
if !ok {
|
|
// if we can't close the connection can't really do anything else
|
|
logger.Warnf("cannot close running stream for: %s", path)
|
|
return
|
|
}
|
|
|
|
// hijack and close the connection
|
|
conn, _, err := hj.Hijack()
|
|
if err != nil {
|
|
logger.Errorf("cannot close running stream for '%s' due to error: %s", path, err.Error())
|
|
} else {
|
|
conn.Close()
|
|
}
|
|
}
|
|
}
|
|
|
|
type SceneServer struct {
|
|
TXNManager models.TransactionManager
|
|
}
|
|
|
|
func (s *SceneServer) StreamSceneDirect(scene *models.Scene, w http.ResponseWriter, r *http.Request) {
|
|
fileNamingAlgo := config.GetInstance().GetVideoFileNamingAlgorithm()
|
|
|
|
filepath := GetInstance().Paths.Scene.GetStreamPath(scene.Path, scene.GetHash(fileNamingAlgo))
|
|
RegisterStream(filepath, &w)
|
|
http.ServeFile(w, r, filepath)
|
|
WaitAndDeregisterStream(filepath, &w, r)
|
|
}
|
|
|
|
func (s *SceneServer) ServeScreenshot(scene *models.Scene, w http.ResponseWriter, r *http.Request) {
|
|
filepath := GetInstance().Paths.Scene.GetScreenshotPath(scene.GetHash(config.GetInstance().GetVideoFileNamingAlgorithm()))
|
|
|
|
// fall back to the scene image blob if the file isn't present
|
|
screenshotExists, _ := utils.FileExists(filepath)
|
|
if screenshotExists {
|
|
http.ServeFile(w, r, filepath)
|
|
} else {
|
|
var cover []byte
|
|
err := s.TXNManager.WithReadTxn(r.Context(), func(repo models.ReaderRepository) error {
|
|
cover, _ = repo.Scene().GetCover(scene.ID)
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
logger.Warnf("read transaction failed while serving screenshot: %v", err)
|
|
}
|
|
|
|
if err = utils.ServeImage(cover, w, r); err != nil {
|
|
logger.Warnf("unable to serve screenshot image: %v", err)
|
|
}
|
|
}
|
|
}
|