mirror of
https://github.com/stashapp/stash.git
synced 2025-12-14 04:13:56 +01:00
87709fd018
* Avoid redundant logging in migrations
Return the error and let the caller handle the logging of the error if
needed.
While here, defer m.Close() to the function boundary.
* Treat errors as values
Use %v rather than %s and pass the errors directly.
* Generate a wrapped error on stat-failure
* Log 3 unchecked errors
Rather than ignore errors, log them at
the WARNING log level.
The server has been functioning without these, so assume they are not at
the ERROR level.
* Propagate errors upward
Failure in path generation was ignored. Propagate the errors upward the
call stack, so it can be handled at the level of orchestration.
* Warn on errors
Log errors rather than quenching them.
Errors are logged at the Warn-level for now.
* Check error when creating test databases
Use the builtin log package and stop the program fatally on error.
* Add warnings to uncheck task errors
Focus on the task system in a single commit, logging unchecked
errors as warnings.
* Warn-on-error in API routes
Look through the API routes, and make sure errors are being logged if
they occur. Prefer the Warn-log-level because none of these has proven
to be fatal in the system up until now.
* Propagate error when adding Util API
* Propagate error on adding util API
* Return unhandled error
* JS log API: propagate and log errors
* JS Plugins: log GQL addition failures.
* Warn on failure to write to stdin
* Warn on failure to stop task
* Wrap viper.BindEnv
The current viper code only errors if no name is provided, so it should
never fail. Rewrite the code flow to factor through a panic-function.
This removes error warnings from this part of the code.
* Log errors in concurrency test
If we can't initialize the configuration, treat the test as a failure.
* Warn on errors in configuration code
* Plug an unchecked error in gallery zip walking
* Warn on screenshot serving failure
* Warn on encoder screenshot failure
* Warn on errors in path-handling code
* Undo the errcheck on configurations for now.
* Use one-line initializers where applicable
rather than using
err := f()
if err!= nil { ..
prefer the shorter
if err := f(); err != nil { ..
If f() isn't too long of a name, or wraps a function with a body.
72 lines
1.8 KiB
Go
72 lines
1.8 KiB
Go
package paths
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
|
|
"github.com/stashapp/stash/pkg/logger"
|
|
"github.com/stashapp/stash/pkg/utils"
|
|
)
|
|
|
|
const thumbDirDepth int = 2
|
|
const thumbDirLength int = 2 // thumbDirDepth * thumbDirLength must be smaller than the length of checksum
|
|
|
|
type generatedPaths struct {
|
|
Screenshots string
|
|
Thumbnails string
|
|
Vtt string
|
|
Markers string
|
|
Transcodes string
|
|
Downloads string
|
|
Tmp string
|
|
}
|
|
|
|
func newGeneratedPaths(path string) *generatedPaths {
|
|
gp := generatedPaths{}
|
|
gp.Screenshots = filepath.Join(path, "screenshots")
|
|
gp.Thumbnails = filepath.Join(path, "thumbnails")
|
|
gp.Vtt = filepath.Join(path, "vtt")
|
|
gp.Markers = filepath.Join(path, "markers")
|
|
gp.Transcodes = filepath.Join(path, "transcodes")
|
|
gp.Downloads = filepath.Join(path, "download_stage")
|
|
gp.Tmp = filepath.Join(path, "tmp")
|
|
return &gp
|
|
}
|
|
|
|
func (gp *generatedPaths) GetTmpPath(fileName string) string {
|
|
return filepath.Join(gp.Tmp, fileName)
|
|
}
|
|
|
|
func (gp *generatedPaths) EnsureTmpDir() error {
|
|
return utils.EnsureDir(gp.Tmp)
|
|
}
|
|
|
|
func (gp *generatedPaths) EmptyTmpDir() error {
|
|
return utils.EmptyDir(gp.Tmp)
|
|
}
|
|
|
|
func (gp *generatedPaths) RemoveTmpDir() error {
|
|
return utils.RemoveDir(gp.Tmp)
|
|
}
|
|
|
|
func (gp *generatedPaths) TempDir(pattern string) (string, error) {
|
|
if err := gp.EnsureTmpDir(); err != nil {
|
|
logger.Warnf("Could not ensure existence of a temporary directory: %v", err)
|
|
}
|
|
ret, err := ioutil.TempDir(gp.Tmp, pattern)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
if err = utils.EmptyDir(ret); err != nil {
|
|
logger.Warnf("could not recursively empty dir: %v", err)
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
func (gp *generatedPaths) GetThumbnailPath(checksum string, width int) string {
|
|
fname := fmt.Sprintf("%s_%d.jpg", checksum, width)
|
|
return filepath.Join(gp.Thumbnails, utils.GetIntraDir(checksum, thumbDirDepth, thumbDirLength), fname)
|
|
}
|