mirror of
https://github.com/stashapp/stash.git
synced 2025-12-08 01:13:09 +01:00
87709fd018
* Avoid redundant logging in migrations
Return the error and let the caller handle the logging of the error if
needed.
While here, defer m.Close() to the function boundary.
* Treat errors as values
Use %v rather than %s and pass the errors directly.
* Generate a wrapped error on stat-failure
* Log 3 unchecked errors
Rather than ignore errors, log them at
the WARNING log level.
The server has been functioning without these, so assume they are not at
the ERROR level.
* Propagate errors upward
Failure in path generation was ignored. Propagate the errors upward the
call stack, so it can be handled at the level of orchestration.
* Warn on errors
Log errors rather than quenching them.
Errors are logged at the Warn-level for now.
* Check error when creating test databases
Use the builtin log package and stop the program fatally on error.
* Add warnings to uncheck task errors
Focus on the task system in a single commit, logging unchecked
errors as warnings.
* Warn-on-error in API routes
Look through the API routes, and make sure errors are being logged if
they occur. Prefer the Warn-log-level because none of these has proven
to be fatal in the system up until now.
* Propagate error when adding Util API
* Propagate error on adding util API
* Return unhandled error
* JS log API: propagate and log errors
* JS Plugins: log GQL addition failures.
* Warn on failure to write to stdin
* Warn on failure to stop task
* Wrap viper.BindEnv
The current viper code only errors if no name is provided, so it should
never fail. Rewrite the code flow to factor through a panic-function.
This removes error warnings from this part of the code.
* Log errors in concurrency test
If we can't initialize the configuration, treat the test as a failure.
* Warn on errors in configuration code
* Plug an unchecked error in gallery zip walking
* Warn on screenshot serving failure
* Warn on encoder screenshot failure
* Warn on errors in path-handling code
* Undo the errcheck on configurations for now.
* Use one-line initializers where applicable
rather than using
err := f()
if err!= nil { ..
prefer the shorter
if err := f(); err != nil { ..
If f() isn't too long of a name, or wraps a function with a body.
85 lines
2 KiB
Go
85 lines
2 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"strconv"
|
|
|
|
"github.com/go-chi/chi"
|
|
"github.com/stashapp/stash/pkg/image"
|
|
"github.com/stashapp/stash/pkg/logger"
|
|
"github.com/stashapp/stash/pkg/manager"
|
|
"github.com/stashapp/stash/pkg/models"
|
|
"github.com/stashapp/stash/pkg/utils"
|
|
)
|
|
|
|
type imageRoutes struct {
|
|
txnManager models.TransactionManager
|
|
}
|
|
|
|
func (rs imageRoutes) Routes() chi.Router {
|
|
r := chi.NewRouter()
|
|
|
|
r.Route("/{imageId}", func(r chi.Router) {
|
|
r.Use(ImageCtx)
|
|
|
|
r.Get("/image", rs.Image)
|
|
r.Get("/thumbnail", rs.Thumbnail)
|
|
})
|
|
|
|
return r
|
|
}
|
|
|
|
// region Handlers
|
|
|
|
func (rs imageRoutes) Thumbnail(w http.ResponseWriter, r *http.Request) {
|
|
image := r.Context().Value(imageKey).(*models.Image)
|
|
filepath := manager.GetInstance().Paths.Generated.GetThumbnailPath(image.Checksum, models.DefaultGthumbWidth)
|
|
|
|
// if the thumbnail doesn't exist, fall back to the original file
|
|
exists, _ := utils.FileExists(filepath)
|
|
if exists {
|
|
http.ServeFile(w, r, filepath)
|
|
} else {
|
|
rs.Image(w, r)
|
|
}
|
|
}
|
|
|
|
func (rs imageRoutes) Image(w http.ResponseWriter, r *http.Request) {
|
|
i := r.Context().Value(imageKey).(*models.Image)
|
|
|
|
// if image is in a zip file, we need to serve it specifically
|
|
image.Serve(w, r, i.Path)
|
|
}
|
|
|
|
// endregion
|
|
|
|
func ImageCtx(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
imageIdentifierQueryParam := chi.URLParam(r, "imageId")
|
|
imageID, _ := strconv.Atoi(imageIdentifierQueryParam)
|
|
|
|
var image *models.Image
|
|
readTxnErr := manager.GetInstance().TxnManager.WithReadTxn(r.Context(), func(repo models.ReaderRepository) error {
|
|
qb := repo.Image()
|
|
if imageID == 0 {
|
|
image, _ = qb.FindByChecksum(imageIdentifierQueryParam)
|
|
} else {
|
|
image, _ = qb.Find(imageID)
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if readTxnErr != nil {
|
|
logger.Warnf("read transaction failure while trying to read image by id: %v", readTxnErr)
|
|
}
|
|
|
|
if image == nil {
|
|
http.Error(w, http.StatusText(404), 404)
|
|
return
|
|
}
|
|
|
|
ctx := context.WithValue(r.Context(), imageKey, image)
|
|
next.ServeHTTP(w, r.WithContext(ctx))
|
|
})
|
|
}
|