mirror of
https://github.com/stashapp/stash.git
synced 2025-12-15 12:52:38 +01:00
5495d72849
* Restructure data layer part 2 (#2599) * Refactor and separate image model * Refactor image query builder * Handle relationships in image query builder * Remove relationship management methods * Refactor gallery model/query builder * Add scenes to gallery model * Convert scene model * Refactor scene models * Remove unused methods * Add unit tests for gallery * Add image tests * Add scene tests * Convert unnecessary scene value pointers to values * Convert unnecessary pointer values to values * Refactor scene partial * Add scene partial tests * Refactor ImagePartial * Add image partial tests * Refactor gallery partial update * Add partial gallery update tests * Use zero/null package for null values * Add files and scan system * Add sqlite implementation for files/folders * Add unit tests for files/folders * Image refactors * Update image data layer * Refactor gallery model and creation * Refactor scene model * Refactor scenes * Don't set title from filename * Allow galleries to freely add/remove images * Add multiple scene file support to graphql and UI * Add multiple file support for images in graphql/UI * Add multiple file for galleries in graphql/UI * Remove use of some deprecated fields * Remove scene path usage * Remove gallery path usage * Remove path from image * Move funscript to video file * Refactor caption detection * Migrate existing data * Add post commit/rollback hook system * Lint. Comment out import/export tests * Add WithDatabase read only wrapper * Prepend tasks to list * Add 32 pre-migration * Add warnings in release and migration notes
492 lines
14 KiB
Go
492 lines
14 KiB
Go
package image
|
|
|
|
// import (
|
|
// "context"
|
|
// "errors"
|
|
// "testing"
|
|
|
|
// "github.com/stashapp/stash/pkg/models"
|
|
// "github.com/stashapp/stash/pkg/models/jsonschema"
|
|
// "github.com/stashapp/stash/pkg/models/mocks"
|
|
// "github.com/stretchr/testify/assert"
|
|
// "github.com/stretchr/testify/mock"
|
|
// )
|
|
|
|
// var (
|
|
// path = "path"
|
|
|
|
// imageNameErr = "imageNameErr"
|
|
// // existingImageName = "existingImageName"
|
|
|
|
// existingImageID = 100
|
|
// existingStudioID = 101
|
|
// existingGalleryID = 102
|
|
// existingPerformerID = 103
|
|
// // existingMovieID = 104
|
|
// existingTagID = 105
|
|
|
|
// existingStudioName = "existingStudioName"
|
|
// existingStudioErr = "existingStudioErr"
|
|
// missingStudioName = "missingStudioName"
|
|
|
|
// existingGalleryChecksum = "existingGalleryChecksum"
|
|
// existingGalleryErr = "existingGalleryErr"
|
|
// missingGalleryChecksum = "missingGalleryChecksum"
|
|
|
|
// existingPerformerName = "existingPerformerName"
|
|
// existingPerformerErr = "existingPerformerErr"
|
|
// missingPerformerName = "missingPerformerName"
|
|
|
|
// existingTagName = "existingTagName"
|
|
// existingTagErr = "existingTagErr"
|
|
// missingTagName = "missingTagName"
|
|
|
|
// missingChecksum = "missingChecksum"
|
|
// errChecksum = "errChecksum"
|
|
// )
|
|
|
|
// var testCtx = context.Background()
|
|
|
|
// func TestImporterName(t *testing.T) {
|
|
// i := Importer{
|
|
// Path: path,
|
|
// Input: jsonschema.Image{},
|
|
// }
|
|
|
|
// assert.Equal(t, path, i.Name())
|
|
// }
|
|
|
|
// func TestImporterPreImport(t *testing.T) {
|
|
// i := Importer{
|
|
// Path: path,
|
|
// }
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithStudio(t *testing.T) {
|
|
// studioReaderWriter := &mocks.StudioReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// StudioWriter: studioReaderWriter,
|
|
// Path: path,
|
|
// Input: jsonschema.Image{
|
|
// Studio: existingStudioName,
|
|
// },
|
|
// }
|
|
|
|
// studioReaderWriter.On("FindByName", testCtx, existingStudioName, false).Return(&models.Studio{
|
|
// ID: existingStudioID,
|
|
// }, nil).Once()
|
|
// studioReaderWriter.On("FindByName", testCtx, existingStudioErr, false).Return(nil, errors.New("FindByName error")).Once()
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, existingStudioID, *i.image.StudioID)
|
|
|
|
// i.Input.Studio = existingStudioErr
|
|
// err = i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// studioReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithMissingStudio(t *testing.T) {
|
|
// studioReaderWriter := &mocks.StudioReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// Path: path,
|
|
// StudioWriter: studioReaderWriter,
|
|
// Input: jsonschema.Image{
|
|
// Studio: missingStudioName,
|
|
// },
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumFail,
|
|
// }
|
|
|
|
// studioReaderWriter.On("FindByName", testCtx, missingStudioName, false).Return(nil, nil).Times(3)
|
|
// studioReaderWriter.On("Create", testCtx, mock.AnythingOfType("models.Studio")).Return(&models.Studio{
|
|
// ID: existingStudioID,
|
|
// }, nil)
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumIgnore
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumCreate
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, existingStudioID, *i.image.StudioID)
|
|
|
|
// studioReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithMissingStudioCreateErr(t *testing.T) {
|
|
// studioReaderWriter := &mocks.StudioReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// StudioWriter: studioReaderWriter,
|
|
// Path: path,
|
|
// Input: jsonschema.Image{
|
|
// Studio: missingStudioName,
|
|
// },
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumCreate,
|
|
// }
|
|
|
|
// studioReaderWriter.On("FindByName", testCtx, missingStudioName, false).Return(nil, nil).Once()
|
|
// studioReaderWriter.On("Create", testCtx, mock.AnythingOfType("models.Studio")).Return(nil, errors.New("Create error"))
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithGallery(t *testing.T) {
|
|
// galleryReaderWriter := &mocks.GalleryReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// GalleryWriter: galleryReaderWriter,
|
|
// Path: path,
|
|
// Input: jsonschema.Image{
|
|
// Galleries: []string{
|
|
// existingGalleryChecksum,
|
|
// },
|
|
// },
|
|
// }
|
|
|
|
// galleryReaderWriter.On("FindByChecksums", testCtx, []string{existingGalleryChecksum}).Return([]*models.Gallery{{
|
|
// ID: existingGalleryID,
|
|
// }}, nil).Once()
|
|
// galleryReaderWriter.On("FindByChecksums", testCtx, []string{existingGalleryErr}).Return(nil, errors.New("FindByChecksum error")).Once()
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, existingGalleryID, i.image.GalleryIDs[0])
|
|
|
|
// i.Input.Galleries = []string{
|
|
// existingGalleryErr,
|
|
// }
|
|
|
|
// err = i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// galleryReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithMissingGallery(t *testing.T) {
|
|
// galleryReaderWriter := &mocks.GalleryReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// Path: path,
|
|
// GalleryWriter: galleryReaderWriter,
|
|
// Input: jsonschema.Image{
|
|
// Galleries: []string{
|
|
// missingGalleryChecksum,
|
|
// },
|
|
// },
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumFail,
|
|
// }
|
|
|
|
// galleryReaderWriter.On("FindByChecksums", testCtx, []string{missingGalleryChecksum}).Return(nil, nil).Times(3)
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumIgnore
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Nil(t, i.image.GalleryIDs)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumCreate
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Nil(t, i.image.GalleryIDs)
|
|
|
|
// galleryReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithPerformer(t *testing.T) {
|
|
// performerReaderWriter := &mocks.PerformerReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// PerformerWriter: performerReaderWriter,
|
|
// Path: path,
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumFail,
|
|
// Input: jsonschema.Image{
|
|
// Performers: []string{
|
|
// existingPerformerName,
|
|
// },
|
|
// },
|
|
// }
|
|
|
|
// performerReaderWriter.On("FindByNames", testCtx, []string{existingPerformerName}, false).Return([]*models.Performer{
|
|
// {
|
|
// ID: existingPerformerID,
|
|
// Name: models.NullString(existingPerformerName),
|
|
// },
|
|
// }, nil).Once()
|
|
// performerReaderWriter.On("FindByNames", testCtx, []string{existingPerformerErr}, false).Return(nil, errors.New("FindByNames error")).Once()
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, []int{existingPerformerID}, i.image.PerformerIDs)
|
|
|
|
// i.Input.Performers = []string{existingPerformerErr}
|
|
// err = i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// performerReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithMissingPerformer(t *testing.T) {
|
|
// performerReaderWriter := &mocks.PerformerReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// Path: path,
|
|
// PerformerWriter: performerReaderWriter,
|
|
// Input: jsonschema.Image{
|
|
// Performers: []string{
|
|
// missingPerformerName,
|
|
// },
|
|
// },
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumFail,
|
|
// }
|
|
|
|
// performerReaderWriter.On("FindByNames", testCtx, []string{missingPerformerName}, false).Return(nil, nil).Times(3)
|
|
// performerReaderWriter.On("Create", testCtx, mock.AnythingOfType("models.Performer")).Return(&models.Performer{
|
|
// ID: existingPerformerID,
|
|
// }, nil)
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumIgnore
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumCreate
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, []int{existingPerformerID}, i.image.PerformerIDs)
|
|
|
|
// performerReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithMissingPerformerCreateErr(t *testing.T) {
|
|
// performerReaderWriter := &mocks.PerformerReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// PerformerWriter: performerReaderWriter,
|
|
// Path: path,
|
|
// Input: jsonschema.Image{
|
|
// Performers: []string{
|
|
// missingPerformerName,
|
|
// },
|
|
// },
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumCreate,
|
|
// }
|
|
|
|
// performerReaderWriter.On("FindByNames", testCtx, []string{missingPerformerName}, false).Return(nil, nil).Once()
|
|
// performerReaderWriter.On("Create", testCtx, mock.AnythingOfType("models.Performer")).Return(nil, errors.New("Create error"))
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithTag(t *testing.T) {
|
|
// tagReaderWriter := &mocks.TagReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// TagWriter: tagReaderWriter,
|
|
// Path: path,
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumFail,
|
|
// Input: jsonschema.Image{
|
|
// Tags: []string{
|
|
// existingTagName,
|
|
// },
|
|
// },
|
|
// }
|
|
|
|
// tagReaderWriter.On("FindByNames", testCtx, []string{existingTagName}, false).Return([]*models.Tag{
|
|
// {
|
|
// ID: existingTagID,
|
|
// Name: existingTagName,
|
|
// },
|
|
// }, nil).Once()
|
|
// tagReaderWriter.On("FindByNames", testCtx, []string{existingTagErr}, false).Return(nil, errors.New("FindByNames error")).Once()
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, []int{existingTagID}, i.image.TagIDs)
|
|
|
|
// i.Input.Tags = []string{existingTagErr}
|
|
// err = i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// tagReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithMissingTag(t *testing.T) {
|
|
// tagReaderWriter := &mocks.TagReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// Path: path,
|
|
// TagWriter: tagReaderWriter,
|
|
// Input: jsonschema.Image{
|
|
// Tags: []string{
|
|
// missingTagName,
|
|
// },
|
|
// },
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumFail,
|
|
// }
|
|
|
|
// tagReaderWriter.On("FindByNames", testCtx, []string{missingTagName}, false).Return(nil, nil).Times(3)
|
|
// tagReaderWriter.On("Create", testCtx, mock.AnythingOfType("models.Tag")).Return(&models.Tag{
|
|
// ID: existingTagID,
|
|
// }, nil)
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumIgnore
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
|
|
// i.MissingRefBehaviour = models.ImportMissingRefEnumCreate
|
|
// err = i.PreImport(testCtx)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, []int{existingTagID}, i.image.TagIDs)
|
|
|
|
// tagReaderWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestImporterPreImportWithMissingTagCreateErr(t *testing.T) {
|
|
// tagReaderWriter := &mocks.TagReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// TagWriter: tagReaderWriter,
|
|
// Path: path,
|
|
// Input: jsonschema.Image{
|
|
// Tags: []string{
|
|
// missingTagName,
|
|
// },
|
|
// },
|
|
// MissingRefBehaviour: models.ImportMissingRefEnumCreate,
|
|
// }
|
|
|
|
// tagReaderWriter.On("FindByNames", testCtx, []string{missingTagName}, false).Return(nil, nil).Once()
|
|
// tagReaderWriter.On("Create", testCtx, mock.AnythingOfType("models.Tag")).Return(nil, errors.New("Create error"))
|
|
|
|
// err := i.PreImport(testCtx)
|
|
// assert.NotNil(t, err)
|
|
// }
|
|
|
|
// func TestImporterFindExistingID(t *testing.T) {
|
|
// readerWriter := &mocks.ImageReaderWriter{}
|
|
|
|
// i := Importer{
|
|
// ReaderWriter: readerWriter,
|
|
// Path: path,
|
|
// Input: jsonschema.Image{
|
|
// Checksum: missingChecksum,
|
|
// },
|
|
// }
|
|
|
|
// expectedErr := errors.New("FindBy* error")
|
|
// readerWriter.On("FindByChecksum", testCtx, missingChecksum).Return(nil, nil).Once()
|
|
// readerWriter.On("FindByChecksum", testCtx, checksum).Return(&models.Image{
|
|
// ID: existingImageID,
|
|
// }, nil).Once()
|
|
// readerWriter.On("FindByChecksum", testCtx, errChecksum).Return(nil, expectedErr).Once()
|
|
|
|
// id, err := i.FindExistingID(testCtx)
|
|
// assert.Nil(t, id)
|
|
// assert.Nil(t, err)
|
|
|
|
// i.Input.Checksum = checksum
|
|
// id, err = i.FindExistingID(testCtx)
|
|
// assert.Equal(t, existingImageID, *id)
|
|
// assert.Nil(t, err)
|
|
|
|
// i.Input.Checksum = errChecksum
|
|
// id, err = i.FindExistingID(testCtx)
|
|
// assert.Nil(t, id)
|
|
// assert.NotNil(t, err)
|
|
|
|
// readerWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestCreate(t *testing.T) {
|
|
// readerWriter := &mocks.ImageReaderWriter{}
|
|
|
|
// image := models.Image{
|
|
// Title: title,
|
|
// }
|
|
|
|
// imageErr := models.Image{
|
|
// Title: imageNameErr,
|
|
// }
|
|
|
|
// i := Importer{
|
|
// ReaderWriter: readerWriter,
|
|
// image: image,
|
|
// }
|
|
|
|
// errCreate := errors.New("Create error")
|
|
// readerWriter.On("Create", testCtx, &image).Run(func(args mock.Arguments) {
|
|
// args.Get(1).(*models.Image).ID = imageID
|
|
// }).Return(nil).Once()
|
|
// readerWriter.On("Create", testCtx, &imageErr).Return(errCreate).Once()
|
|
|
|
// id, err := i.Create(testCtx)
|
|
// assert.Equal(t, imageID, *id)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, imageID, i.ID)
|
|
|
|
// i.image = imageErr
|
|
// id, err = i.Create(testCtx)
|
|
// assert.Nil(t, id)
|
|
// assert.NotNil(t, err)
|
|
|
|
// readerWriter.AssertExpectations(t)
|
|
// }
|
|
|
|
// func TestUpdate(t *testing.T) {
|
|
// readerWriter := &mocks.ImageReaderWriter{}
|
|
|
|
// image := models.Image{
|
|
// Title: title,
|
|
// }
|
|
|
|
// imageErr := models.Image{
|
|
// Title: imageNameErr,
|
|
// }
|
|
|
|
// i := Importer{
|
|
// ReaderWriter: readerWriter,
|
|
// image: image,
|
|
// }
|
|
|
|
// errUpdate := errors.New("Update error")
|
|
|
|
// // id needs to be set for the mock input
|
|
// image.ID = imageID
|
|
// readerWriter.On("Update", testCtx, &image).Return(nil).Once()
|
|
|
|
// err := i.Update(testCtx, imageID)
|
|
// assert.Nil(t, err)
|
|
// assert.Equal(t, imageID, i.ID)
|
|
|
|
// i.image = imageErr
|
|
|
|
// // need to set id separately
|
|
// imageErr.ID = errImageID
|
|
// readerWriter.On("Update", testCtx, &imageErr).Return(errUpdate).Once()
|
|
|
|
// err = i.Update(testCtx, errImageID)
|
|
// assert.NotNil(t, err)
|
|
|
|
// readerWriter.AssertExpectations(t)
|
|
// }
|