mirror of
https://github.com/stashapp/stash.git
synced 2025-12-06 16:34:02 +01:00
214a15bc40
* Add a space after // comments
For consistency, the commentFormatting lint checker suggests a space
after each // comment block. This commit handles all the spots in
the code where that is needed.
* Rewrite documentation on functions
Use the Go idiom of commenting:
* First sentence declares the purpose.
* First word is the name being declared
The reason this style is preferred is such that grep is able to find
names the user might be interested in. Consider e.g.,
go doc -all pkg/ffmpeg | grep -i transcode
in which case a match will tell you the name of the function you are
interested in.
* Remove old code comment-blocks
There are some commented out old code blocks in the code base. These are
either 3 years old, or 2 years old. By now, I don't think their use is
going to come back any time soon, and Git will track old pieces of
deleted code anyway.
Opt for deletion.
* Reorder imports
Split stdlib imports from non-stdlib imports in files we are touching.
* Use a range over an iteration variable
Probably more go-idiomatic, and the code needed comment-fixing anyway.
* Use time.After rather than rolling our own
The idiom here is common enough that the stdlib contains a function for
it. Use the stdlib function over our own variant.
* Enable the commentFormatting linter
112 lines
3.2 KiB
Go
112 lines
3.2 KiB
Go
package manager
|
|
|
|
import (
|
|
"github.com/stashapp/stash/pkg/ffmpeg"
|
|
"github.com/stashapp/stash/pkg/logger"
|
|
"github.com/stashapp/stash/pkg/manager/config"
|
|
"github.com/stashapp/stash/pkg/models"
|
|
"github.com/stashapp/stash/pkg/utils"
|
|
)
|
|
|
|
type GenerateTranscodeTask struct {
|
|
Scene models.Scene
|
|
Overwrite bool
|
|
fileNamingAlgorithm models.HashAlgorithm
|
|
}
|
|
|
|
func (t *GenerateTranscodeTask) Start() {
|
|
hasTranscode := HasTranscode(&t.Scene, t.fileNamingAlgorithm)
|
|
if !t.Overwrite && hasTranscode {
|
|
return
|
|
}
|
|
|
|
ffprobe := instance.FFProbe
|
|
var container ffmpeg.Container
|
|
|
|
if t.Scene.Format.Valid {
|
|
container = ffmpeg.Container(t.Scene.Format.String)
|
|
} else { // container isn't in the DB
|
|
// shouldn't happen unless user hasn't scanned after updating to PR#384+ version
|
|
tmpVideoFile, err := ffprobe.NewVideoFile(t.Scene.Path, false)
|
|
if err != nil {
|
|
logger.Errorf("[transcode] error reading video file: %s", err.Error())
|
|
return
|
|
}
|
|
|
|
container = ffmpeg.MatchContainer(tmpVideoFile.Container, t.Scene.Path)
|
|
}
|
|
|
|
videoCodec := t.Scene.VideoCodec.String
|
|
audioCodec := ffmpeg.MissingUnsupported
|
|
if t.Scene.AudioCodec.Valid {
|
|
audioCodec = ffmpeg.AudioCodec(t.Scene.AudioCodec.String)
|
|
}
|
|
|
|
if ffmpeg.IsStreamable(videoCodec, audioCodec, container) {
|
|
return
|
|
}
|
|
|
|
videoFile, err := ffprobe.NewVideoFile(t.Scene.Path, false)
|
|
if err != nil {
|
|
logger.Errorf("[transcode] error reading video file: %s", err.Error())
|
|
return
|
|
}
|
|
|
|
sceneHash := t.Scene.GetHash(t.fileNamingAlgorithm)
|
|
outputPath := instance.Paths.Generated.GetTmpPath(sceneHash + ".mp4")
|
|
transcodeSize := config.GetInstance().GetMaxTranscodeSize()
|
|
options := ffmpeg.TranscodeOptions{
|
|
OutputPath: outputPath,
|
|
MaxTranscodeSize: transcodeSize,
|
|
}
|
|
encoder := instance.FFMPEG
|
|
|
|
if videoCodec == ffmpeg.H264 { // for non supported h264 files stream copy the video part
|
|
if audioCodec == ffmpeg.MissingUnsupported {
|
|
encoder.CopyVideo(*videoFile, options)
|
|
} else {
|
|
encoder.TranscodeAudio(*videoFile, options)
|
|
}
|
|
} else {
|
|
if audioCodec == ffmpeg.MissingUnsupported {
|
|
// ffmpeg fails if it trys to transcode an unsupported audio codec
|
|
encoder.TranscodeVideo(*videoFile, options)
|
|
} else {
|
|
encoder.Transcode(*videoFile, options)
|
|
}
|
|
}
|
|
|
|
if err := utils.SafeMove(outputPath, instance.Paths.Scene.GetTranscodePath(sceneHash)); err != nil {
|
|
logger.Errorf("[transcode] error generating transcode: %s", err.Error())
|
|
return
|
|
}
|
|
|
|
logger.Debugf("[transcode] <%s> created transcode: %s", sceneHash, outputPath)
|
|
}
|
|
|
|
// return true if transcode is needed
|
|
// used only when counting files to generate, doesn't affect the actual transcode generation
|
|
// if container is missing from DB it is treated as non supported in order not to delay the user
|
|
func (t *GenerateTranscodeTask) isTranscodeNeeded() bool {
|
|
|
|
videoCodec := t.Scene.VideoCodec.String
|
|
container := ""
|
|
audioCodec := ffmpeg.MissingUnsupported
|
|
if t.Scene.AudioCodec.Valid {
|
|
audioCodec = ffmpeg.AudioCodec(t.Scene.AudioCodec.String)
|
|
}
|
|
|
|
if t.Scene.Format.Valid {
|
|
container = t.Scene.Format.String
|
|
}
|
|
|
|
if ffmpeg.IsStreamable(videoCodec, audioCodec, ffmpeg.Container(container)) {
|
|
return false
|
|
}
|
|
|
|
hasTranscode := HasTranscode(&t.Scene, t.fileNamingAlgorithm)
|
|
if !t.Overwrite && hasTranscode {
|
|
return false
|
|
}
|
|
return true
|
|
}
|