mirror of
https://github.com/stashapp/stash.git
synced 2025-12-24 17:23:27 +01:00
c6f6205e4f
* Replace error assertions with Go 1.13 style
Use `errors.As(..)` over type assertions. This enables better use of
wrapped errors in the future, and lets us pass some errorlint checks
in the process.
The rewrite is entirely mechanical, and uses a standard idiom for
doing so.
* Use Go 1.13's errors.Is(..)
Rather than directly checking for error equality, use errors.Is(..).
This protects against error wrapping issues in the future.
Even though something like sql.ErrNoRows doesn't need the wrapping, do
so anyway, for the sake of consistency throughout the code base.
The change almost lets us pass the `errorlint` Go checker except for
a missing case in `js.go` which is to be handled separately; it isn't
mechanical, like these changes are.
* Remove goconst
goconst isn't a useful linter in many cases, because it's false positive
rate is high. It's 100% for the current code base.
* Avoid direct comparison of errors in recover()
Assert that we are catching an error from recover(). If we are,
check that the error caught matches errStop.
* Enable the "errorlint" checker
Configure the checker to avoid checking for errorf wraps. These are
often false positives since the suggestion is to blanket wrap errors
with %w, and that exposes the underlying API which you might not want
to do.
The other warnings are good however, and with the current patch stack,
the code base passes all these checks as well.
* Configure rowserrcheck
The project uses sqlx. Configure rowserrcheck to include said package.
* Mechanically rewrite a large set of errors
Mechanically search for errors that look like
fmt.Errorf("...%s", err.Error())
and rewrite those into
fmt.Errorf("...%v", err)
The `fmt` package is error-aware and knows how to call err.Error()
itself.
The rationale is that this is more idiomatic Go; it paves the
way for using error wrapping later with %w in some sites.
This patch only addresses the entirely mechanical rewriting caught by
a project-side search/replace. There are more individual sites not
addressed by this patch.
|
||
|---|---|---|
| .. | ||
| urlbuilders | ||
| authentication.go | ||
| changeset_translator.go | ||
| check_version.go | ||
| context_keys.go | ||
| images.go | ||
| resolver.go | ||
| resolver_model_gallery.go | ||
| resolver_model_image.go | ||
| resolver_model_movie.go | ||
| resolver_model_performer.go | ||
| resolver_model_scene.go | ||
| resolver_model_scene_marker.go | ||
| resolver_model_studio.go | ||
| resolver_model_tag.go | ||
| resolver_mutation_configure.go | ||
| resolver_mutation_dlna.go | ||
| resolver_mutation_gallery.go | ||
| resolver_mutation_image.go | ||
| resolver_mutation_job.go | ||
| resolver_mutation_metadata.go | ||
| resolver_mutation_movie.go | ||
| resolver_mutation_performer.go | ||
| resolver_mutation_plugin.go | ||
| resolver_mutation_saved_filter.go | ||
| resolver_mutation_scene.go | ||
| resolver_mutation_scraper.go | ||
| resolver_mutation_stash_box.go | ||
| resolver_mutation_studio.go | ||
| resolver_mutation_tag.go | ||
| resolver_mutation_tag_test.go | ||
| resolver_query_configuration.go | ||
| resolver_query_dlna.go | ||
| resolver_query_find_gallery.go | ||
| resolver_query_find_image.go | ||
| resolver_query_find_movie.go | ||
| resolver_query_find_performer.go | ||
| resolver_query_find_saved_filter.go | ||
| resolver_query_find_scene.go | ||
| resolver_query_find_scene_marker.go | ||
| resolver_query_find_studio.go | ||
| resolver_query_find_tag.go | ||
| resolver_query_job.go | ||
| resolver_query_logs.go | ||
| resolver_query_metadata.go | ||
| resolver_query_plugin.go | ||
| resolver_query_scene.go | ||
| resolver_query_scraper.go | ||
| resolver_subscription_job.go | ||
| resolver_subscription_logging.go | ||
| routes_downloads.go | ||
| routes_image.go | ||
| routes_movie.go | ||
| routes_performer.go | ||
| routes_scene.go | ||
| routes_studio.go | ||
| routes_tag.go | ||
| server.go | ||
| session.go | ||
| types.go | ||