Backup_Repos/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2025-12-06 16:34:02 +01:00
Code Issues Projects Releases Wiki Activity

fix point markers ui bug (#5684)

Browse source
This commit is contained in:
skier233 2025-02-25 17:18:53 -05:00 committed by GitHub
parent b8af147a8d
commit f65976cf4d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ui/v2.5/src/components/ScenePlayer/ScenePlayer.tsx
View file

@ -733,16 +733,8 @@ export const ScenePlayer: React.FC<IScenePlayerProps> = ({
} }
} }
// Add markers in chunks
const CHUNK_SIZE = 10;
for (let i = 0; i < timestampMarkers.length; i += CHUNK_SIZE) {
const chunk = timestampMarkers.slice(i, i + CHUNK_SIZE);
requestAnimationFrame(() => {
chunk.forEach((m) => markers.addDotMarker(m));
});
}
requestAnimationFrame(() => { requestAnimationFrame(() => {
markers.addDotMarkers(timestampMarkers);
markers.addRangeMarkers(rangeMarkers); markers.addRangeMarkers(rangeMarkers);
}); });
}, [getPlayer, scene, uiConfig]); }, [getPlayer, scene, uiConfig]);

17
ui/v2.5/src/components/ScenePlayer/markers.ts
View file

@ -100,6 +100,12 @@ class MarkersPlugin extends videojs.getPlugin("plugin") {
if (seekBar) { if (seekBar) {
seekBar.appendChild(markerSet.dot); seekBar.appendChild(markerSet.dot);
} }
this.markers.push(marker);
this.markerDivs.push(markerSet);
}
addDotMarkers(markers: IMarker[]) {
markers.forEach(this.addDotMarker, this);
} }
private renderRangeMarkers(markers: IMarker[], layer: number) { private renderRangeMarkers(markers: IMarker[], layer: number) {
@ -255,7 +261,16 @@ class MarkersPlugin extends videojs.getPlugin("plugin") {
} }
clearMarkers() { clearMarkers() {
this.removeMarkers([...this.markers]); for (const markerSet of this.markerDivs) {
if (markerSet.dot?.hasAttribute("marker-tooltip-shown")) {
this.hideMarkerTooltip();
}
markerSet.dot?.remove();
if (markerSet.range) markerSet.range.remove();
}
this.markers = [];
this.markerDivs = [];
} }
// Implementing the findColors method // Implementing the findColors method