Saved filter bugs (#1524)

* Don't use default filter in VIEW persist state
* Reshuffle randomly sorted saved filters
This commit is contained in:
WithoutPants 2021-06-23 11:01:23 +10:00 committed by GitHub
parent 2fdf672015
commit debf21e6b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions

View file

@ -165,6 +165,8 @@ export const SavedFilterList: React.FC<ISavedFilterListProps> = ({
const newFilter = filter.clone();
newFilter.currentPage = 1;
newFilter.configureFromQueryParameters(JSON.parse(f.filter));
// #1507 - reset random seed when loaded
newFilter.randomSeed = -1;
onSetFilter(newFilter);
}

View file

@ -627,11 +627,18 @@ const useList = <QueryResult extends IQueryResult, QueryData extends IDataItem>(
// if default query is set and no search params are set, then
// load the default query
if (!location.search && defaultFilter?.findDefaultFilter) {
// #1512 - use default query only if persistState is ALL
if (
options.persistState === PersistanceLevel.ALL &&
!location.search &&
defaultFilter?.findDefaultFilter
) {
newFilter.currentPage = 1;
newFilter.configureFromQueryParameters(
JSON.parse(defaultFilter.findDefaultFilter.filter)
);
// #1507 - reset random seed when loaded
newFilter.randomSeed = -1;
update = true;
}