Fix UI loop when sorting by random without seed (#6167)

This commit is contained in:
WithoutPants 2025-10-22 11:31:42 +11:00 committed by GitHub
parent 71e4071871
commit 947a17355c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -24,6 +24,7 @@ export function useFilterURL(
const history = useHistory();
const location = useLocation();
const prevLocation = usePrevious(location);
// when the filter changes, update the URL
const updateFilter = useCallback(
@ -47,7 +48,8 @@ export function useFilterURL(
// and updates the filter accordingly.
useEffect(() => {
// don't apply if active is false
if (!active) return;
// also don't apply if location is unchanged
if (!active || prevLocation === location) return;
// re-init to load default filter on empty new query params
if (!location.search) {
@ -73,7 +75,8 @@ export function useFilterURL(
});
}, [
active,
location.search,
prevLocation,
location,
defaultFilter,
setFilter,
updateFilter,