Backup_Repos/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2025-12-06 08:26:00 +01:00
Code Issues Projects Releases Wiki Activity

Prevent unnecessary re-queries

Browse source
This commit is contained in:
WithoutPants 2025-12-03 18:20:39 +11:00
parent 3494bfb197
commit 8ad889d68c
2 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ui/v2.5/src/components/List/ListProvider.tsx
View file

@ -1,5 +1,10 @@
import React, { useMemo } from "react";
import { IListSelect, useCachedQueryResult, useListSelect } from "./util";
import {
IListSelect,
useCachedQueryResult,
useListSelect,
useMetadataFilter,
} from "./util";
import { isFunction } from "lodash-es";
import { IHasID } from "src/utils/data";
import { useFilter } from "./FilterProvider";
@ -135,10 +140,7 @@ export const QueryResultContext = <
}, [filter, filterHook]);
// metadata filter is the effective filter with the sort, page size and page number removed
const metadataFilter = useMemo(
() => effectiveFilter.metadataInfo(),
[effectiveFilter]
);
const metadataFilter = useMetadataFilter(effectiveFilter);
const result = useResult(effectiveFilter);

13
ui/v2.5/src/components/List/util.ts
View file

@ -483,6 +483,19 @@ export function useCachedQueryResult<T extends QueryResult>(
return cachedResult;
}
// used to generate a metadata info filter that only updates when necessary
export function useMetadataFilter(filter: ListFilterModel) {
const lastValue = usePrevious(filter);
return useMemo(() => {
if (!lastValue || !totalCountImpacted(lastValue!, filter)) {
return filter.metadataInfo();
}
return lastValue;
}, [filter, lastValue]);
}
export interface IQueryResultHook<
T extends QueryResult,
E extends IHasID = IHasID