Backup_Repos/stash
1
0
Fork 0
mirror of https://github.com/stashapp/stash.git synced 2026-05-09 05:05:29 +02:00
Code Issues Projects Releases Wiki Activity

fix(scraper): prevent nil pointer dereference in scrapeScene

Browse source 
When scrapeScene finds no results, ret remains nil and is passed to
processSceneRelationships, which unconditionally dereferences it at
line 89 (ret.Performers = ...), causing a panic.

Initialize ret to an empty ScrapedScene so processSceneRelationships
always has a valid pointer. This also preserves the intent of #3953:
returning a scene with only relationship fields set when scraped
non-relationship data is absent.

Fixes panic: runtime error: invalid memory address or nil pointer
dereference at pkg/scraper/mapped.go:89 in processSceneRelationships
This commit is contained in:
Marco 2026-04-23 00:16:29 +02:00
parent 22d2dbc46b
commit 820f354ed2
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/scraper/mapped.go
View file

@ -184,7 +184,10 @@ func (s mappedScraper) scrapeScene(ctx context.Context, q mappedQuery) (*models.
logger.Debug(`Processing scene:`)
results := sceneMap.process(ctx, q, s.Common, urlsIsMulti)
var ret *models.ScrapedScene
// Initialize ret to a non-nil empty scene so that processSceneRelationships
// can safely populate relationship fields even when no direct results were found.
// This preserves the intent of #3953: returning a scene with only relationships.
ret := &models.ScrapedScene{}
if len(results) > 0 {
ret = results[0].scrapedScene()
}