From 7bb437df67c0534124dd95d5597b3878a7b2e9db Mon Sep 17 00:00:00 2001 From: WithoutPants <53250216+WithoutPants@users.noreply.github.com> Date: Tue, 2 Dec 2025 16:01:44 +1100 Subject: [PATCH] Remove month/year only formats from ParseDateStringAsTime --- pkg/utils/date.go | 12 ------------ pkg/utils/date_test.go | 41 ++--------------------------------------- 2 files changed, 2 insertions(+), 51 deletions(-) diff --git a/pkg/utils/date.go b/pkg/utils/date.go index 511cf8a4f..de5566e4d 100644 --- a/pkg/utils/date.go +++ b/pkg/utils/date.go @@ -23,17 +23,5 @@ func ParseDateStringAsTime(dateString string) (time.Time, error) { return t, nil } - // Support partial dates: year-month format - t, e = time.Parse("2006-01", dateString) - if e == nil { - return t, nil - } - - // Support partial dates: year only format - t, e = time.Parse("2006", dateString) - if e == nil { - return t, nil - } - return time.Time{}, fmt.Errorf("ParseDateStringAsTime failed: dateString <%s>", dateString) } diff --git a/pkg/utils/date_test.go b/pkg/utils/date_test.go index f3622ca40..ae077c21e 100644 --- a/pkg/utils/date_test.go +++ b/pkg/utils/date_test.go @@ -2,7 +2,6 @@ package utils import ( "testing" - "time" ) func TestParseDateStringAsTime(t *testing.T) { @@ -16,13 +15,11 @@ func TestParseDateStringAsTime(t *testing.T) { {"Date only", "2014-01-02", false}, {"Date with time", "2014-01-02 15:04:05", false}, - // Partial date formats (new support) - {"Year-Month", "2006-08", false}, - {"Year only", "2014", false}, - // Invalid formats {"Invalid format", "not-a-date", true}, {"Empty string", "", true}, + {"Year-Month", "2006-08", true}, + {"Year only", "2014", true}, } for _, tt := range tests { @@ -44,37 +41,3 @@ func TestParseDateStringAsTime(t *testing.T) { }) } } - -func TestParseDateStringAsTime_YearOnly(t *testing.T) { - result, err := ParseDateStringAsTime("2014") - if err != nil { - t.Fatalf("Failed to parse year-only date: %v", err) - } - - if result.Year() != 2014 { - t.Errorf("Expected year 2014, got %d", result.Year()) - } - if result.Month() != time.January { - t.Errorf("Expected month January, got %s", result.Month()) - } - if result.Day() != 1 { - t.Errorf("Expected day 1, got %d", result.Day()) - } -} - -func TestParseDateStringAsTime_YearMonth(t *testing.T) { - result, err := ParseDateStringAsTime("2006-08") - if err != nil { - t.Fatalf("Failed to parse year-month date: %v", err) - } - - if result.Year() != 2006 { - t.Errorf("Expected year 2006, got %d", result.Year()) - } - if result.Month() != time.August { - t.Errorf("Expected month August, got %s", result.Month()) - } - if result.Day() != 1 { - t.Errorf("Expected day 1, got %d", result.Day()) - } -}