From 3df7ee06eb97e1aea04c98c86b2a06d793b4b109 Mon Sep 17 00:00:00 2001
From: WithoutPants <53250216+WithoutPants@users.noreply.github.com>
Date: Mon, 17 May 2021 15:46:00 +1000
Subject: [PATCH] Shortcut scan walk for excluded folders (#1382)

* Shortcut scan walk for excluded folders
* Add note to manual
* Add changelog entry
---
 pkg/manager/task_scan.go                          | 7 +++++++
 ui/v2.5/src/components/Changelog/versions/v080.md | 1 +
 ui/v2.5/src/docs/en/Configuration.md              | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/pkg/manager/task_scan.go b/pkg/manager/task_scan.go
index 41497cb9e..568589e9f 100644
--- a/pkg/manager/task_scan.go
+++ b/pkg/manager/task_scan.go
@@ -1098,6 +1098,13 @@ func walkFilesToScan(s *models.StashConfig, f filepath.WalkFunc) error {
 				return filepath.SkipDir
 			}
 
+			// shortcut: skip the directory entirely if it matches both exclusion patterns
+			// add a trailing separator so that it correctly matches against patterns like path/.*
+			pathExcludeTest := path + string(filepath.Separator)
+			if (s.ExcludeVideo || matchFileRegex(pathExcludeTest, excludeVidRegex)) && (s.ExcludeImage || matchFileRegex(pathExcludeTest, excludeImgRegex)) {
+				return filepath.SkipDir
+			}
+
 			return nil
 		}
 
diff --git a/ui/v2.5/src/components/Changelog/versions/v080.md b/ui/v2.5/src/components/Changelog/versions/v080.md
index 1b4fb4faa..cd0a49858 100644
--- a/ui/v2.5/src/components/Changelog/versions/v080.md
+++ b/ui/v2.5/src/components/Changelog/versions/v080.md
@@ -1,2 +1,3 @@
 ### 🎨 Improvements
+* Skip scanning directories if path matches image and video exclude patterns. ([#1382](https://github.com/stashapp/stash/pull/1382))
 * Add button to remove studio stash ID. ([#1378](https://github.com/stashapp/stash/pull/1378))
diff --git a/ui/v2.5/src/docs/en/Configuration.md b/ui/v2.5/src/docs/en/Configuration.md
index d25377149..4bcef2a07 100644
--- a/ui/v2.5/src/docs/en/Configuration.md
+++ b/ui/v2.5/src/docs/en/Configuration.md
@@ -32,6 +32,8 @@ exclude:
 * the fourth the directory `/stash/videos/exclude/`
 * and the last a windows network path `\\stash\network\share\excl\`
 
+**Note:** if a directory is excluded for images and videos, then the directory will be excluded from scans completely.
+
 _a useful [link](https://regex101.com/) to experiment with regexps_
 
 ## Hashing algorithms