Clear markers on unmount (#5678)

This commit is contained in:
WithoutPants 2025-02-28 18:22:13 +11:00 committed by GitHub
parent 59014f14ca
commit 23e36b12fe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -714,7 +714,6 @@ export const ScenePlayer: React.FC<IScenePlayerProps> = ({
}));
const markers = player!.markers();
markers.clearMarkers();
const uniqueTagNames = markerData
.map((marker) => marker.primaryTag.name)
@ -772,6 +771,8 @@ export const ScenePlayer: React.FC<IScenePlayerProps> = ({
return () => {
player.off("loadedmetadata", handleLoadMetadata);
const markers = player!.markers();
markers.clearMarkers();
};
}, [getPlayer, scene, loadMarkers]);