From 0bba8889b842ddd517fd85a3bc788cef7e16c6e9 Mon Sep 17 00:00:00 2001 From: WithoutPants <53250216+WithoutPants@users.noreply.github.com> Date: Fri, 3 May 2024 13:10:17 +1000 Subject: [PATCH] Fix duplicate scene checker select logic (#4800) --- .../SceneDuplicateChecker/SceneDuplicateChecker.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/v2.5/src/components/SceneDuplicateChecker/SceneDuplicateChecker.tsx b/ui/v2.5/src/components/SceneDuplicateChecker/SceneDuplicateChecker.tsx index 1532bf5e8..4c3e6ee54 100644 --- a/ui/v2.5/src/components/SceneDuplicateChecker/SceneDuplicateChecker.tsx +++ b/ui/v2.5/src/components/SceneDuplicateChecker/SceneDuplicateChecker.tsx @@ -165,9 +165,9 @@ export const SceneDuplicateChecker: React.FC = () => { } const findLargestScene = (group: GQL.SlimSceneDataFragment[]) => { - // Get total size of a scene + // Get maximum file size of a scene const totalSize = (scene: GQL.SlimSceneDataFragment) => { - return scene.files.reduce((sum: number, f) => sum + (f.size || 0), 0); + return scene.files.reduce((prev: number, f) => Math.max(prev, f.size), 0); }; // Find scene object with maximum total size return group.reduce((largest, scene) => { @@ -178,10 +178,10 @@ export const SceneDuplicateChecker: React.FC = () => { }; const findLargestResolutionScene = (group: GQL.SlimSceneDataFragment[]) => { - // Get resolution of a scene + // Get maximum resolution of a scene const sceneResolution = (scene: GQL.SlimSceneDataFragment) => { return scene.files.reduce( - (sum: number, f) => sum + (f.height * f.width || 0), + (prev: number, f) => Math.max(prev, f.height * f.width), 0 ); };