Backup_Repos/komga
1
0
Fork 0
mirror of https://github.com/gotson/komga.git synced 2025-12-29 11:52:56 +01:00
Code Issues Projects Releases Wiki Activity

add tests for dto sanitization of url for Series and Books

Browse source
This commit is contained in:
Gauthier Roebroeck 2019-12-23 11:18:30 +08:00
parent 4909fb612c
commit 874b3c057e
2 changed files with 133 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
komga/src/test/kotlin/org/gotson/komga/interfaces/web/rest/BookControllerTest.kt
View file

@ -2,6 +2,7 @@ package org.gotson.komga.interfaces.web.rest
import org.gotson.komga.domain.model.BookMetadata
import org.gotson.komga.domain.model.BookPage
import org.gotson.komga.domain.model.UserRoles
import org.gotson.komga.domain.model.makeBook
import org.gotson.komga.domain.model.makeLibrary
import org.gotson.komga.domain.model.makeSeries
@ -24,6 +25,7 @@ import org.springframework.boot.test.context.SpringBootTest
import org.springframework.jdbc.core.JdbcTemplate
import org.springframework.test.context.junit.jupiter.SpringExtension
import org.springframework.test.web.servlet.MockMvc
import org.springframework.test.web.servlet.MockMvcResultMatchersDsl
import org.springframework.test.web.servlet.get
import javax.sql.DataSource
@ -87,7 +89,7 @@ class BookControllerTest(
.andExpect {
status { isOk }
jsonPath("$.content.length()") { value(1) }
jsonPath("\$.content[0].name") { value("1") }
jsonPath("$.content[0].name") { value("1") }
}
}
@ -274,4 +276,68 @@ class BookControllerTest(
mockMvc.get("/api/v1/books/${book.id}/pages/$page")
.andExpect { status { isBadRequest } }
}
@Nested
inner class DtoUrlSanitization {
@Test
@WithMockCustomUser
fun `given regular user when getting books then full url is hidden`() {
val series = makeSeries(
name = "series",
books = listOf(makeBook("1.cbr"))
).also { it.library = library }
seriesRepository.save(series)
val validation: MockMvcResultMatchersDsl.() -> Unit = {
status { isOk }
jsonPath("$.content[0].url") { value("1.cbr") }
}
mockMvc.get("/api/v1/books")
.andExpect(validation)
mockMvc.get("/api/v1/books/latest")
.andExpect(validation)
mockMvc.get("/api/v1/series/${series.id}/books?ready_only=false")
.andExpect(validation)
mockMvc.get("/api/v1/books/${series.books.first().id}")
.andExpect {
status { isOk }
jsonPath("$.url") { value("1.cbr") }
}
}
@Test
@WithMockCustomUser(roles = [UserRoles.ADMIN])
fun `given admin user when getting books then full url is available`() {
val series = makeSeries(
name = "series",
books = listOf(makeBook("1.cbr"))
).also { it.library = library }
seriesRepository.save(series)
val url = "/1.cbr"
val validation: MockMvcResultMatchersDsl.() -> Unit = {
status { isOk }
jsonPath("$.content[0].url") { value(url) }
}
mockMvc.get("/api/v1/books")
.andExpect(validation)
mockMvc.get("/api/v1/books/latest")
.andExpect(validation)
mockMvc.get("/api/v1/series/${series.id}/books?ready_only=false")
.andExpect(validation)
mockMvc.get("/api/v1/books/${series.books.first().id}")
.andExpect {
status { isOk }
jsonPath("$.url") { value(url) }
}
}
}
}

66
komga/src/test/kotlin/org/gotson/komga/interfaces/web/rest/SeriesControllerTest.kt
View file

@ -1,6 +1,7 @@
package org.gotson.komga.interfaces.web.rest
import org.gotson.komga.domain.model.BookMetadata
import org.gotson.komga.domain.model.UserRoles
import org.gotson.komga.domain.model.makeBook
import org.gotson.komga.domain.model.makeLibrary
import org.gotson.komga.domain.model.makeSeries
@ -20,6 +21,7 @@ import org.springframework.boot.test.context.SpringBootTest
import org.springframework.jdbc.core.JdbcTemplate
import org.springframework.test.context.junit.jupiter.SpringExtension
import org.springframework.test.web.servlet.MockMvc
import org.springframework.test.web.servlet.MockMvcResultMatchersDsl
import org.springframework.test.web.servlet.get
import javax.sql.DataSource
@ -220,4 +222,68 @@ class SeriesControllerTest(
.andExpect { status { isNotFound } }
}
}
@Nested
inner class DtoUrlSanitization {
@Test
@WithMockCustomUser
fun `given regular user when getting series then url is hidden`() {
val series = makeSeries(
name = "series",
books = listOf(makeBook("1.cbr"))
).also { it.library = library }
seriesRepository.save(series)
val validation: MockMvcResultMatchersDsl.() -> Unit = {
status { isOk }
jsonPath("$.content[0].url") { value("") }
}
mockMvc.get("/api/v1/series")
.andExpect(validation)
mockMvc.get("/api/v1/series/latest")
.andExpect(validation)
mockMvc.get("/api/v1/series/new")
.andExpect(validation)
mockMvc.get("/api/v1/series/${series.id}")
.andExpect {
status { isOk }
jsonPath("$.url") { value("") }
}
}
@Test
@WithMockCustomUser(roles = [UserRoles.ADMIN])
fun `given admin user when getting series then url is available`() {
val series = makeSeries(
name = "series",
books = listOf(makeBook("1.cbr"))
).also { it.library = library }
seriesRepository.save(series)
val url = "/series"
val validation: MockMvcResultMatchersDsl.() -> Unit = {
status { isOk }
jsonPath("$.content[0].url") { value(url) }
}
mockMvc.get("/api/v1/series")
.andExpect(validation)
mockMvc.get("/api/v1/series/latest")
.andExpect(validation)
mockMvc.get("/api/v1/series/new")
.andExpect(validation)
mockMvc.get("/api/v1/series/${series.id}")
.andExpect {
status { isOk }
jsonPath("$.url") { value(url) }
}
}
}
}