From 4a5450ac25f3aa347ac4027f64d77ddcdc667144 Mon Sep 17 00:00:00 2001
From: Gauthier Roebroeck <gauthier.roebroeck@gmail.com>
Date: Mon, 30 Jun 2025 15:00:46 +0800
Subject: [PATCH] more component tests

---
 next-ui/src/App.vue                           |  4 +-
 next-ui/src/components.d.ts                   |  1 +
 .../user/form/ChangePassword.stories.ts       | 60 ++++++++++++++++
 .../components/user/form/ChangePassword.vue   |  2 +-
 .../fragment/user/form/CreateEdit.stories.ts  | 61 ++++++++++++++++
 .../fragment}/user/form/CreateEdit.vue        |  0
 next-ui/src/mocks/api/handlers.ts             | 10 ++-
 next-ui/src/mocks/api/handlers/libraries.ts   | 72 +++++++++++++++++++
 next-ui/src/mocks/api/handlers/referential.ts |  7 ++
 next-ui/src/pages/server/users.vue            |  2 +-
 10 files changed, 214 insertions(+), 5 deletions(-)
 create mode 100644 next-ui/src/components/user/form/ChangePassword.stories.ts
 create mode 100644 next-ui/src/fragments/fragment/user/form/CreateEdit.stories.ts
 rename next-ui/src/{components => fragments/fragment}/user/form/CreateEdit.vue (100%)
 create mode 100644 next-ui/src/mocks/api/handlers/libraries.ts
 create mode 100644 next-ui/src/mocks/api/handlers/referential.ts

diff --git a/next-ui/src/App.vue b/next-ui/src/App.vue
index f39946ec..345ddcf1 100644
--- a/next-ui/src/App.vue
+++ b/next-ui/src/App.vue
@@ -3,8 +3,8 @@
     <router-view />
 
     <FragmentSnackQueue />
-    <FragmentDialogInstanceConfirmEdit />
-    <FragmentDialogInstanceConfirm />
+    <FragmentDialogConfirmEdit />
+    <FragmentDialogConfirm />
   </v-app>
 </template>
 
diff --git a/next-ui/src/components.d.ts b/next-ui/src/components.d.ts
index 0ac26853..fbae7f4b 100644
--- a/next-ui/src/components.d.ts
+++ b/next-ui/src/components.d.ts
@@ -19,6 +19,7 @@ declare module 'vue' {
     FragmentLocaleSelector: typeof import('./fragments/fragment/LocaleSelector.vue')['default']
     FragmentSnackQueue: typeof import('./fragments/fragment/SnackQueue.vue')['default']
     FragmentThemeSelector: typeof import('./fragments/fragment/ThemeSelector.vue')['default']
+    FragmentUserFormCreateEdit: typeof import('./fragments/fragment/user/form/CreateEdit.vue')['default']
     HelloWorld: typeof import('./components/HelloWorld.vue')['default']
     LayoutAppBar: typeof import('./fragments/layout/app/Bar.vue')['default']
     LayoutAppDrawer: typeof import('./fragments/layout/app/drawer/Drawer.vue')['default']
diff --git a/next-ui/src/components/user/form/ChangePassword.stories.ts b/next-ui/src/components/user/form/ChangePassword.stories.ts
new file mode 100644
index 00000000..4be89916
--- /dev/null
+++ b/next-ui/src/components/user/form/ChangePassword.stories.ts
@@ -0,0 +1,60 @@
+import type { Meta, StoryObj } from '@storybook/vue3-vite'
+
+import ChangePassword from './ChangePassword.vue'
+import { expect, waitFor } from 'storybook/test'
+
+const meta = {
+  component: ChangePassword,
+  render: (args: object) => ({
+    components: { ChangePassword },
+    setup() {
+      return { args }
+    },
+    template: '<ChangePassword />',
+  }),
+  parameters: {
+    // More on how to position stories at: https://storybook.js.org/docs/configure/story-layout
+  },
+  args: {},
+} satisfies Meta<typeof ChangePassword>
+
+export default meta
+type Story = StoryObj<typeof meta>
+
+export const Default: Story = {
+  args: {},
+}
+
+export const MatchingPasswords: Story = {
+  args: {},
+  play: async ({ canvas, userEvent }) => {
+    const password1 = canvas.getByLabelText(/new password/i, {
+      selector: 'input',
+    })
+    await userEvent.type(password1, 'abc')
+
+    const password2 = canvas.getByLabelText(/confirm password/i, {
+      selector: 'input',
+    })
+    await userEvent.type(password2, 'abc')
+
+    await waitFor(() => expect(canvas.getByText(/must be identical/i)).not.toBeVisible())
+  },
+}
+
+export const DifferentPasswords: Story = {
+  args: {},
+  play: async ({ canvas, userEvent }) => {
+    const password1 = canvas.getByLabelText(/new password/i, {
+      selector: 'input',
+    })
+    await userEvent.type(password1, 'abc')
+
+    const password2 = canvas.getByLabelText(/confirm password/i, {
+      selector: 'input',
+    })
+    await userEvent.type(password2, 'def')
+
+    await waitFor(() => expect(canvas.getByText(/must be identical/i)).toBeVisible())
+  },
+}
diff --git a/next-ui/src/components/user/form/ChangePassword.vue b/next-ui/src/components/user/form/ChangePassword.vue
index da6e85f7..e07f94e9 100644
--- a/next-ui/src/components/user/form/ChangePassword.vue
+++ b/next-ui/src/components/user/form/ChangePassword.vue
@@ -44,7 +44,7 @@
 </template>
 
 <script setup lang="ts">
-const newPassword = defineModel<string>({ required: true })
+const newPassword = defineModel<string>()
 
 const confirmPassword = ref<string>()
 const showPassword = ref<boolean>(false)
diff --git a/next-ui/src/fragments/fragment/user/form/CreateEdit.stories.ts b/next-ui/src/fragments/fragment/user/form/CreateEdit.stories.ts
new file mode 100644
index 00000000..1783085c
--- /dev/null
+++ b/next-ui/src/fragments/fragment/user/form/CreateEdit.stories.ts
@@ -0,0 +1,61 @@
+import type { Meta, StoryObj } from '@storybook/vue3-vite'
+
+import CreateEdit from './CreateEdit.vue'
+import { UserRoles } from '@/types/UserRoles'
+
+const meta = {
+  component: CreateEdit,
+  render: (args: object) => ({
+    components: { CreateEdit },
+    setup() {
+      return { args }
+    },
+    template: '<CreateEdit :model-value="args.modelValue" v-bind="args"/>',
+  }),
+  parameters: {
+    // More on how to position stories at: https://storybook.js.org/docs/configure/story-layout
+  },
+  args: {},
+} satisfies Meta<typeof CreateEdit>
+
+export default meta
+type Story = StoryObj<typeof meta>
+
+export const CreateUser: Story = {
+  args: {
+    modelValue: {
+      email: '',
+      password: '',
+      roles: [UserRoles.PAGE_STREAMING, UserRoles.FILE_DOWNLOAD],
+      sharedLibraries: {
+        all: true,
+        libraryIds: ['1', '2'],
+      },
+      ageRestriction: {
+        age: 0,
+        restriction: 'NONE',
+      },
+    },
+  },
+}
+
+export const UpdateUser: Story = {
+  args: {
+    modelValue: {
+      id: '123',
+      email: 'user@example.org',
+      password: 'masked',
+      roles: [UserRoles.KOBO_SYNC, UserRoles.FILE_DOWNLOAD],
+      sharedLibraries: {
+        all: false,
+        libraryIds: ['1'],
+      },
+      ageRestriction: {
+        age: 12,
+        restriction: 'ALLOW_ONLY',
+      },
+      labelsAllow: ['kids'],
+      labelsExclude: ['teens'],
+    },
+  },
+}
diff --git a/next-ui/src/components/user/form/CreateEdit.vue b/next-ui/src/fragments/fragment/user/form/CreateEdit.vue
similarity index 100%
rename from next-ui/src/components/user/form/CreateEdit.vue
rename to next-ui/src/fragments/fragment/user/form/CreateEdit.vue
diff --git a/next-ui/src/mocks/api/handlers.ts b/next-ui/src/mocks/api/handlers.ts
index fef75708..416e838f 100644
--- a/next-ui/src/mocks/api/handlers.ts
+++ b/next-ui/src/mocks/api/handlers.ts
@@ -2,8 +2,16 @@ import { actuatorHandlers } from '@/mocks/api/handlers/actuator'
 import { announcementHandlers } from '@/mocks/api/handlers/announcements'
 import { releasesHandlers } from '@/mocks/api/handlers/releases'
 import { HttpResponse } from 'msw'
+import { librariesHandlers } from '@/mocks/api/handlers/libraries'
+import { referentialHandlers } from '@/mocks/api/handlers/referential'
 
-export const handlers = [...actuatorHandlers, ...announcementHandlers, ...releasesHandlers]
+export const handlers = [
+  ...librariesHandlers,
+  ...referentialHandlers,
+  ...actuatorHandlers,
+  ...announcementHandlers,
+  ...releasesHandlers,
+]
 
 export const response401Unauthorized = () =>
   HttpResponse.json({ error: 'Unauthorized' }, { status: 401 })
diff --git a/next-ui/src/mocks/api/handlers/libraries.ts b/next-ui/src/mocks/api/handlers/libraries.ts
new file mode 100644
index 00000000..ddced265
--- /dev/null
+++ b/next-ui/src/mocks/api/handlers/libraries.ts
@@ -0,0 +1,72 @@
+import { httpTyped } from '@/mocks/api/httpTyped'
+
+export const libraries = [
+  {
+    id: '1',
+    name: 'eBooks',
+    root: '/ebooks',
+    importComicInfoBook: true,
+    importComicInfoSeries: true,
+    importComicInfoCollection: true,
+    importComicInfoReadList: true,
+    importComicInfoSeriesAppendVolume: true,
+    importEpubBook: true,
+    importEpubSeries: true,
+    importMylarSeries: true,
+    importLocalArtwork: true,
+    importBarcodeIsbn: false,
+    scanForceModifiedTime: false,
+    scanInterval: 'DISABLED',
+    scanOnStartup: false,
+    scanCbx: true,
+    scanPdf: true,
+    scanEpub: true,
+    scanDirectoryExclusions: ['#recycle', '@Recycle', '@eaDir'],
+    repairExtensions: false,
+    convertToCbz: false,
+    emptyTrashAfterScan: true,
+    seriesCover: 'FIRST',
+    hashFiles: true,
+    hashPages: false,
+    hashKoreader: false,
+    analyzeDimensions: false,
+    oneshotsDirectory: '_oneshots',
+    unavailable: false,
+  },
+  {
+    id: '2',
+    name: 'Comics',
+    root: '/books',
+    importComicInfoBook: true,
+    importComicInfoSeries: true,
+    importComicInfoCollection: true,
+    importComicInfoReadList: true,
+    importComicInfoSeriesAppendVolume: true,
+    importEpubBook: true,
+    importEpubSeries: true,
+    importMylarSeries: true,
+    importLocalArtwork: true,
+    importBarcodeIsbn: true,
+    scanForceModifiedTime: false,
+    scanInterval: 'DISABLED',
+    scanOnStartup: false,
+    scanCbx: true,
+    scanPdf: true,
+    scanEpub: true,
+    scanDirectoryExclusions: ['#recycle', '@Recycle', '@eaDir'],
+    repairExtensions: false,
+    convertToCbz: false,
+    emptyTrashAfterScan: true,
+    seriesCover: 'FIRST_UNREAD_OR_FIRST',
+    hashFiles: true,
+    hashPages: false,
+    hashKoreader: false,
+    analyzeDimensions: true,
+    oneshotsDirectory: null,
+    unavailable: false,
+  },
+]
+
+export const librariesHandlers = [
+  httpTyped.get('/api/v1/libraries', ({ response }) => response(200).json(libraries)),
+]
diff --git a/next-ui/src/mocks/api/handlers/referential.ts b/next-ui/src/mocks/api/handlers/referential.ts
new file mode 100644
index 00000000..5726cb16
--- /dev/null
+++ b/next-ui/src/mocks/api/handlers/referential.ts
@@ -0,0 +1,7 @@
+import { httpTyped } from '@/mocks/api/httpTyped'
+
+export const sharingLabels = ['kids', 'teens']
+
+export const referentialHandlers = [
+  httpTyped.get('/api/v1/sharing-labels', ({ response }) => response(200).json(sharingLabels)),
+]
diff --git a/next-ui/src/pages/server/users.vue b/next-ui/src/pages/server/users.vue
index 4512ad11..15d5c05c 100644
--- a/next-ui/src/pages/server/users.vue
+++ b/next-ui/src/pages/server/users.vue
@@ -99,7 +99,7 @@ import { useMessagesStore } from '@/stores/messages'
 import { useIntl } from 'vue-intl'
 import { useDisplay } from 'vuetify'
 import UserDeletionWarning from '@/components/user/DeletionWarning.vue'
-import UserFormCreateEdit from '@/components/user/form/CreateEdit.vue'
+import UserFormCreateEdit from '@/fragments/fragment/user/form/CreateEdit.vue'
 import UserFormChangePassword from '@/components/user/form/ChangePassword.vue'
 
 const intl = useIntl()