From 2962ece2ffb2171d18fd7aa8b16a2780dfdcbc73 Mon Sep 17 00:00:00 2001 From: Val Erastov Date: Sat, 28 Apr 2018 21:19:22 -0700 Subject: [PATCH] fix plane to expose correct surface --- web/app/cad/scene/wrappers/brepSceneObject.js | 1 - web/app/cad/scene/wrappers/planeSceneObject.js | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/web/app/cad/scene/wrappers/brepSceneObject.js b/web/app/cad/scene/wrappers/brepSceneObject.js index ecc8b074..67e2c9a2 100644 --- a/web/app/cad/scene/wrappers/brepSceneObject.js +++ b/web/app/cad/scene/wrappers/brepSceneObject.js @@ -69,7 +69,6 @@ class BREPSceneFace extends SceneFace { brepFace.data['scene.face'] = this; } - normal() { return this.brepFace.surface.normalInMiddle(); } diff --git a/web/app/cad/scene/wrappers/planeSceneObject.js b/web/app/cad/scene/wrappers/planeSceneObject.js index 31132301..69604c7b 100644 --- a/web/app/cad/scene/wrappers/planeSceneObject.js +++ b/web/app/cad/scene/wrappers/planeSceneObject.js @@ -1,7 +1,6 @@ import Vector from 'math/vector'; -import {STANDARD_BASES} from '../../../math/l3space' -import {Plane} from '../../../brep/geom/impl/plane' -import {SceneSolid, SceneFace} from './sceneObject' +import {SceneFace, SceneSolid} from './sceneObject'; +import {createBoundingSurfaceFrom2DPoints} from '../../../brep/brep-builder'; const INIT_WIDTH_H = 750 * 0.5; const INIT_HEIGHT_H = 750 * 0.5; @@ -22,6 +21,9 @@ export class PlaneSceneObject extends SceneSolid { opacity: 0.5 }, skin)); this.plane = plane; + this.surface = createBoundingSurfaceFrom2DPoints([ + new Vector(0,0,0), new Vector(0,100,0), new Vector(100,100,0), new Vector(100,0,0) + ], plane); this.sceneFace = new PlaneSceneFace(this); this.sceneFaces.push(this.sceneFace); // as part of the API this.updateBounds(INIT_BOUNDS); @@ -69,7 +71,7 @@ class PlaneSceneFace extends SceneFace { } surface() { - return this.solid.plane; + return this.solid.surface; } getBounds() {