we used to have the readonly attribute but somehow it's not supported by
all fields, eg: select. As such when something is read only we disable
the field
before this commit, the issue was:
1. whenever uploading a large folder, any upload would trigger the ls change, resulting in a lot of unecessary dom
changes which in case the user is browsing through a lot of picture would trigger some flickering in the thumbnail.
2. large upload would be slow as virtual.before would call change
detection and refresh the list of files within the folder constantly
now by avoiding mutations we effectively just rerender when something we
are interested changes: aka something change in the current folder the
user is in
instead of inventing a new protocol for chunked upload that can be
resumed, we might as well use something that already exists like TUS.
As such we removed our custom implementation to favor that standard
issue:
1. create a 2MB file: dd if=/dev/zero of=testfile bs=1024 count=2048
2. size chunk to 1MB
what we see: progress up to 50%, then stop and jump to 100%
when toggling off the settings for a shared links, the value wouldn't
be actually turned off. We're now ensuring that anything with an "enabled"
checkbox is turned on/off on demand
whenever uploading something with files and folders, the thumbnails
would flash on and off all the time. The commit
a0540eecae only address part of the issue,
this commit take care of the other bits
Before this, whenever the upload of a file within a folder occured, we
had some unwanted flicker on picture as the page would refresh itself.
We don't need to refresh the transcient stuff when the upload occur in a
different place