Backup_Repos/filestash
1
0
Fork 0
mirror of https://github.com/mickael-kerjean/filestash synced 2025-12-27 02:35:18 +01:00
Code Issues Projects Releases Wiki Activity

fix (symlink): evaluate symlinks before opening file

Browse source
This commit is contained in:
Mickael Kerjean 2022-08-29 20:10:14 +10:00
parent 28c2e5070d
commit 8bbd4a2f57
1 changed files with 12 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
server/common/files.go
View file

@ -1,6 +1,7 @@
package common
import (
"errors"
"os"
"path/filepath"
"strings"
@ -69,24 +70,20 @@ func SplitPath(path string) (root string, filename string) {
func SafeOsOpenFile(path string, flag int, perm os.FileMode) (*os.File, error) {
flag = flag | syscall.O_NOFOLLOW
if flag&os.O_CREATE != 0 {
return os.OpenFile(path, flag, perm)
p, err := filepath.EvalSymlinks(path)
if err != nil {
if errors.Is(err, os.ErrNotExist) && flag&os.O_CREATE != 0 {
return os.OpenFile(path, flag, perm)
}
Log.Warning("common::files SafeOsOpenFile err[%s] path[%s]", err.Error(), path)
return nil, ErrFilesystemError
}
fi, err := os.Lstat(filepath.Clean(path))
if err != nil {
Log.Warning("common::files os.Open err[%s] path[%s]", err.Error(), path)
return nil, ErrFilesystemError
}
switch mode := fi.Mode(); {
case mode.IsRegular():
case mode.IsDir():
case mode&os.ModeSymlink != 0:
Log.Warning("common::files blocked symlink path[%s]", path)
return nil, ErrFilesystemError
default:
Log.Warning("common::files mode[%b] path[%s]", mode, path)
if p != filepath.Clean(path) {
Log.Warning("common::files SafeOsOpenFile clean(path)[%s] p[%s]", filepath.Clean(path), p)
return nil, ErrFilesystemError
}
return os.OpenFile(path, flag, perm)
}