mirror of
https://github.com/beetbox/beets.git
synced 2025-12-11 02:53:58 +01:00
current metadata to be correct if it's complete Previously, we were using the Munkres algorithm (minimum bipartite matching) to order tracks intelligently only as a fallback if the current metadata was paradoxical or incomplete. This was because of a concern about the performance of the potentially-O(n^3) Munkres solver. However, it was found that (a) the performance is actually not bad, taking on the order of 0.02 to perform a matching, and (b) there was no recourse for the tagger to reorder tracks that were legitimately in the wrong order. Now, we get intelligent reordering of badly tagged music even when the metadata seems to be complete. To retain some of the functionality of the old orderer, the track distance metric was expanded to include a component reflecting the track index. In doing this, another bug was discovered in the UI that showed the track name differences based on an arbitrary ordering. Now, the tag_album function returns a reordered items list with every candidate.
163 lines
5.7 KiB
Python
163 lines
5.7 KiB
Python
# This file is part of beets.
|
|
# Copyright 2010, Adrian Sampson.
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining
|
|
# a copy of this software and associated documentation files (the
|
|
# "Software"), to deal in the Software without restriction, including
|
|
# without limitation the rights to use, copy, modify, merge, publish,
|
|
# distribute, sublicense, and/or sell copies of the Software, and to
|
|
# permit persons to whom the Software is furnished to do so, subject to
|
|
# the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be
|
|
# included in all copies or substantial portions of the Software.
|
|
|
|
"""Test file manipulation functionality of Item.
|
|
"""
|
|
|
|
import unittest, shutil, sys, os
|
|
sys.path.append('..')
|
|
import beets.library
|
|
from os.path import join
|
|
|
|
def mkfile(path):
|
|
open(path, 'w').close()
|
|
|
|
class MoveTest(unittest.TestCase):
|
|
def setUp(self):
|
|
# make a temporary file
|
|
self.path = join('rsrc', 'temp.mp3')
|
|
shutil.copy(join('rsrc', 'full.mp3'), self.path)
|
|
|
|
# add it to a temporary library
|
|
self.lib = beets.library.Library(':memory:')
|
|
self.i = beets.library.Item.from_path(self.path)
|
|
self.lib.add(self.i)
|
|
|
|
# set up the destination
|
|
self.libdir = join('rsrc', 'testlibdir')
|
|
self.lib.directory = self.libdir
|
|
self.lib.path_format = join('$artist', '$album', '$title')
|
|
self.i.artist = 'one'
|
|
self.i.album = 'two'
|
|
self.i.title = 'three'
|
|
self.dest = join(self.libdir, 'one', 'two', 'three.mp3')
|
|
|
|
def tearDown(self):
|
|
if os.path.exists(self.path):
|
|
os.remove(self.path)
|
|
if os.path.exists(self.libdir):
|
|
shutil.rmtree(self.libdir)
|
|
|
|
def test_move_arrives(self):
|
|
self.i.move(self.lib)
|
|
self.assertTrue(os.path.exists(self.dest))
|
|
|
|
def test_move_departs(self):
|
|
self.i.move(self.lib)
|
|
self.assertTrue(not os.path.exists(self.path))
|
|
|
|
def test_copy_arrives(self):
|
|
self.i.move(self.lib, copy=True)
|
|
self.assertTrue(os.path.exists(self.dest))
|
|
|
|
def test_copy_does_not_depart(self):
|
|
self.i.move(self.lib, copy=True)
|
|
self.assertTrue(os.path.exists(self.path))
|
|
|
|
def test_move_changes_path(self):
|
|
self.i.move(self.lib)
|
|
self.assertEqual(self.i.path, beets.library._normpath(self.dest))
|
|
|
|
class WalkTest(unittest.TestCase):
|
|
def setUp(self):
|
|
# create a directory structure for testing
|
|
self.base = join('rsrc', 'temp_walk')
|
|
os.mkdir(self.base)
|
|
mkfile(join(self.base, 'file'))
|
|
os.mkdir(join(self.base, 'dir1'))
|
|
mkfile(join(self.base, 'dir1', 'dir1f1'))
|
|
mkfile(join(self.base, 'dir1', 'dir1f2'))
|
|
os.mkdir(join(self.base, 'dir2'))
|
|
mkfile(join(self.base, 'dir2', 'dir2f'))
|
|
os.mkdir(join(self.base, 'dir2', 'dir2dir'))
|
|
mkfile(join(self.base, 'dir2', 'dir2dir', 'dir2dirf'))
|
|
def tearDown(self):
|
|
shutil.rmtree(self.base)
|
|
|
|
def test_walk_single_file(self):
|
|
path = join(self.base, 'file')
|
|
s = set(beets.library._walk_files(path))
|
|
self.assertTrue(path in s)
|
|
s.remove(path)
|
|
self.assertTrue(not s) # s is empty (i.e., contains nothing else)
|
|
|
|
def test_walk_flat_directory(self):
|
|
path = join(self.base, 'dir1')
|
|
s = set(beets.library._walk_files(path))
|
|
for f in (join(path, 'dir1f1'),
|
|
join(path, 'dir1f2')):
|
|
self.assertTrue(f in s)
|
|
s.remove(f)
|
|
self.assertTrue(not s)
|
|
|
|
def test_walk_hierarchy(self):
|
|
path = join(self.base, 'dir2')
|
|
s = set(beets.library._walk_files(path))
|
|
for f in (join(path, 'dir2f'),
|
|
join(path, 'dir2dir', 'dir2dirf')):
|
|
self.assertTrue(f in s)
|
|
s.remove(f)
|
|
self.assertTrue(not s)
|
|
|
|
class AddTest(unittest.TestCase):
|
|
def setUp(self):
|
|
self.dir = os.path.join('rsrc', 'test_lib')
|
|
self.lib = beets.library.Library(':memory:')
|
|
self.lib.directory = self.dir
|
|
self.lib.path_format = 'item'
|
|
def tearDown(self):
|
|
if os.path.exists(self.dir):
|
|
shutil.rmtree(self.dir)
|
|
|
|
def test_library_add_path_copies(self):
|
|
self.lib.add_path(os.path.join('rsrc', 'full.mp3'), copy=True)
|
|
self.assertTrue(os.path.isfile(os.path.join(self.dir, 'item.mp3')))
|
|
|
|
def test_add_path_enforces_unicode_pathnames(self):
|
|
self.lib.add_path(os.path.join('rsrc', 'full.mp3'))
|
|
item = self.lib.get().next()
|
|
self.assertTrue(isinstance(item.path, unicode))
|
|
|
|
class HelperTest(unittest.TestCase):
|
|
def test_ancestry_works_on_file(self):
|
|
p = '/a/b/c'
|
|
a = ['/','/a','/a/b']
|
|
self.assertEqual(beets.library._ancestry(p), a)
|
|
def test_ancestry_works_on_dir(self):
|
|
p = '/a/b/c/'
|
|
a = ['/', '/a', '/a/b', '/a/b/c']
|
|
self.assertEqual(beets.library._ancestry(p), a)
|
|
def test_ancestry_works_on_relative(self):
|
|
p = 'a/b/c'
|
|
a = ['a', 'a/b']
|
|
self.assertEqual(beets.library._ancestry(p), a)
|
|
|
|
def test_components_works_on_file(self):
|
|
p = '/a/b/c'
|
|
a = ['/', 'a', 'b', 'c']
|
|
self.assertEqual(beets.library._components(p), a)
|
|
def test_components_works_on_dir(self):
|
|
p = '/a/b/c/'
|
|
a = ['/', 'a', 'b', 'c']
|
|
self.assertEqual(beets.library._components(p), a)
|
|
def test_components_works_on_relative(self):
|
|
p = 'a/b/c'
|
|
a = ['a', 'b', 'c']
|
|
self.assertEqual(beets.library._components(p), a)
|
|
|
|
def suite():
|
|
return unittest.TestLoader().loadTestsFromName(__name__)
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main(defaultTest='suite')
|