mirror of
https://github.com/beetbox/beets.git
synced 2025-12-09 10:05:35 +01:00
a28f930c52
In an attempt to finally address the longstanding SQLite locking issues, I'm introducing a way to explicitly, lexically scope transactions. The Transaction class is a context manager that always fully fetches after SELECTs and automatically commits on exit. No direct access to the library is allowed, so all changes will eventually be committed and all queries will be completed. This will also provide a debugging mechanism to show where concurrent transactions are beginning and ending. To support composition (transaction reentrancy), an internal, per-Library stack of transactions is maintained. Commits only happen when the outermost transaction exits. This means that, while it's possible to introduce atomicity bugs by invoking Library methods outside of a transaction, you can conveniently call them *without* a currently-active transaction to get a single atomic action. Note that this "transaction stack" concepts assumes a single Library object per thread. Because we need to duplicate Library objects for concurrent access due to sqlite3 limitation already, this is fine for now. Later, the interface should provide one transaction stack per thread for shared Library objects.
43 lines
1.6 KiB
Python
43 lines
1.6 KiB
Python
# This file is part of beets.
|
|
# Copyright 2011, Adrian Sampson.
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining
|
|
# a copy of this software and associated documentation files (the
|
|
# "Software"), to deal in the Software without restriction, including
|
|
# without limitation the rights to use, copy, modify, merge, publish,
|
|
# distribute, sublicense, and/or sell copies of the Software, and to
|
|
# permit persons to whom the Software is furnished to do so, subject to
|
|
# the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be
|
|
# included in all copies or substantial portions of the Software.
|
|
|
|
"""Tests for the virtual filesystem builder.."""
|
|
import _common
|
|
from _common import unittest
|
|
from beets import library
|
|
from beets import vfs
|
|
|
|
class VFSTest(unittest.TestCase):
|
|
def setUp(self):
|
|
self.lib = library.Library(':memory:', path_formats=[
|
|
('default', 'albums/$album/$title'),
|
|
('singleton:true', 'tracks/$artist/$title'),
|
|
])
|
|
self.lib.add(_common.item())
|
|
self.lib.add_album([_common.item()])
|
|
self.tree = vfs.libtree(self.lib)
|
|
|
|
def test_singleton_item(self):
|
|
self.assertEqual(self.tree.dirs['tracks'].dirs['the artist'].
|
|
files['the title'], 1)
|
|
|
|
def test_album_item(self):
|
|
self.assertEqual(self.tree.dirs['albums'].dirs['the album'].
|
|
files['the title'], 2)
|
|
|
|
def suite():
|
|
return unittest.TestLoader().loadTestsFromName(__name__)
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main(defaultTest='suite')
|