Backup_Repos/beets
1
0
Fork 0
mirror of https://github.com/beetbox/beets.git synced 2026-01-30 20:13:37 +01:00
Code Issues Projects Releases Wiki Activity
beets/test/plugins
History
Šarūnas Nejus 334bbde826
Make album, duration required for LyricsPlugin.fetch 
Since at least one Backend requires album` and `duration` arguments
(`LRCLib`), the caller (`LyricsPlugin.fetch_item_lyrics`) must always
provide them.

Since they need to provided, we need to enforce this by defining them as
positional arguments.

Why is this important? I found that integrated `LRCLib` tests have been
passing, but they called `LRCLib.fetch` with values for `artist` and
`title` fields only, while the actual functionality *always* provides
values for `album` and `duration` fields too.

When I adjusted the test to provide values for the missing fields,
I found that it failed. This makes sense: Lib `album` and `duration`
filters are strict on LRCLib, so I was not surprised the lyrics could
not be found.

Thus I adjusted `LRCLib` backend implementation to only filter by each
of these fields when their values are truthy.
2025-01-19 01:48:04 +00:00
..
__init__.py Correctly refactor tests 2023-10-17 19:39:03 +10:00
test_acousticbrainz.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_advancedrewrite.py Update CI config, minimum ruff version, docs and add changelog note 2024-12-10 06:10:03 +00:00
test_albumtypes.py Update deprecated imports 2024-12-10 06:10:04 +00:00
test_art.py Remove some lint exclusions and fix the issues 2024-09-21 11:59:19 +01:00
test_aura.py Use PEP585 lowercase collections typing annotations 2024-12-10 06:10:03 +00:00
test_autobpm.py Skip autobpm tests if librosa isn't available 2024-11-30 09:32:08 -04:00
test_bareasc.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_beatport.py Use f-string syntax 2024-08-16 17:47:23 +01:00
test_bucket.py Future proof BucketPluginTest.test_year_single_year_last_folder 2024-12-27 16:28:38 -04:00
test_convert.py Fix lints 2024-10-30 12:13:30 +00:00
test_discogs.py Fixes TypeError in the Discogs plugin (#5415) 2024-09-19 21:27:16 +01:00
test_edit.py Remove some lint exclusions and fix the issues 2024-09-21 11:59:19 +01:00
test_embedart.py Fix lint issues 2024-09-21 11:59:18 +01:00
test_embyupdate.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_export.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_fetchart.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_filefilter.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_ftintitle.py Remove redundant unit tests for ftintitle plugin 2024-10-01 15:55:38 -05:00
test_hook.py Move imports required for typing under the TYPE_CHECKING block 2024-12-10 06:10:04 +00:00
test_ihate.py Replace assertFalse 2024-08-12 08:43:41 +01:00
test_importadded.py Remove some lint exclusions and fix the issues 2024-09-21 11:59:19 +01:00
test_importfeeds.py Replace assertIn 2024-08-12 08:43:42 +01:00
test_info.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_ipfs.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_keyfinder.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_lastgenre.py Replace assertNotEqual 2024-08-12 08:43:42 +01:00
test_limit.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_lyrics.py Make album, duration required for LyricsPlugin.fetch 2025-01-19 01:48:04 +00:00
test_mbsubmit.py Replace assertIn 2024-08-12 08:43:42 +01:00
test_mbsync.py Remove redundant generate_album_info and generate_track_info functions 2024-10-16 06:39:30 +01:00
test_mpdstats.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_parentwork.py Introduce integration_test marker and update testing docs 2024-09-21 13:26:05 +01:00
test_permissions.py Remove some lint exclusions and fix the issues 2024-09-21 11:59:19 +01:00
test_play.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_player.py Remove some lint exclusions and fix the issues 2024-09-21 11:59:19 +01:00
test_playlist.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_plexupdate.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_plugin_mediafield.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_random.py Reformat the codebase 2024-09-21 11:57:48 +01:00
test_replaygain.py Replace assertAlmostEqual 2024-08-12 08:49:30 +01:00
test_smartplaylist.py Replace assertRaises 2024-08-12 08:43:42 +01:00
test_spotify.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_subsonicupdate.py Remove def suite TestLoader definitions 2024-07-28 18:58:51 +01:00
test_substitute.py Apply substitute rules in sequence 2024-10-16 16:36:36 +02:00
test_the.py Replace assertEqual 2024-08-12 08:43:42 +01:00
test_thumbnails.py Fix lint issues 2024-09-21 11:59:18 +01:00
test_types_plugin.py Replace assertRaises 2024-08-12 08:43:42 +01:00
test_web.py Replace assertCountEqual 2024-08-12 08:43:43 +01:00
test_zero.py Update CI config, minimum ruff version, docs and add changelog note 2024-12-10 06:10:03 +00:00