Johann Klähn
ad2028ddf7
mpdstats: do not call item.write
...
The attributes used by this plugin are not 'writable'[^1] anyway so this
leads to needless file access. Also we do not need to check for
`item._lib` as this will always be populated by the call to
`lib.items(...)`.
[^1]: As per `ITEM_KEYS_WRITABLE` in `beets/library.py`
2013-12-12 08:23:33 +01:00
Adrian Sampson
1066c79b56
simplify path type coercion in MatchQuery ( #470 )
2013-12-11 16:03:29 -08:00
Adrian Sampson
69e6ef7633
Merge pull request #471 from kljohann/matchquery_path
...
fix MatchQuery('path', ...) for unicode value
2013-12-11 15:59:45 -08:00
Adrian Sampson
c6c3f7ea0b
Merge pull request #470 from kljohann/mpdstats_expand
...
expand '~' in host in mpdstats
2013-12-11 15:57:41 -08:00
Johann Klähn
c539c36886
fix MatchQuery('path', ...) for unicode value
2013-12-11 12:18:13 +01:00
Johann Klähn
97e4ccbbd9
expand '~' in host in mpdstats
2013-12-11 12:04:39 +01:00
Adrian Sampson
15b6433db0
echonest: docs pass
2013-11-29 19:21:59 -08:00
Adrian Sampson
4ea5ed9eed
echonest: always flatten results to dict
...
This avoids the need for two cases (song object or dict) in parts of the code.
2013-11-29 12:58:46 -08:00
Adrian Sampson
5e08c178e6
echonest: fix codegen/identify
...
I broke two things:
- forgot to return the fingerprint! oops
- need to handle raw Exception raised by pyechonest
2013-11-29 10:09:09 -08:00
Adrian Sampson
9bcd7aecae
echonest: clean up FFmpeg-based audio conversion
...
subprocess.check_call helps a lot here.
--HG--
extra : amend_source : 009a79de8f97407fc60b62aa6b7bd23856286082
2013-11-27 19:09:54 -08:00
Adrian Sampson
a0056afeaf
echonest: clean up analyze workflow
...
- handle the right exceptions
- add duration to from_track dict
2013-11-27 18:57:29 -08:00
Adrian Sampson
6b54514c65
echonest: simplify fingerprinting strategy
...
mostly expunging exception-based control flow
2013-11-27 18:35:21 -08:00
Adrian Sampson
d5dd68af24
echonest: sort analysis methods by priority
...
These are now ordered in the code in the same sequence that we try them:
- profile (ID)
- search (metadata)
- identify (fingerprint)
- analyze (upload)
2013-11-27 18:26:44 -08:00
Adrian Sampson
78688cc3f1
echonest: simplify ID-based lookup ("profile")
...
- don't use generic Exceptions for control flow
- extraneous .get() calls
2013-11-27 18:18:25 -08:00
Adrian Sampson
1ae2894a01
echonest: simplify method-aggregator loop
2013-11-26 18:20:25 -08:00
Adrian Sampson
4ad9635043
echonest: use pipeline stage
...
In addition to the performance benefit of running in our own thread, this also
obviates the need for the _songs dict to pass stuff between stages.
2013-11-26 18:11:14 -08:00
Adrian Sampson
d367bc31d4
echonest: don't needlessly write during import
...
On the import hook, the config['import']['write'] check (and writing at all)
is not necessary, since this will be taken care of later in the program.
2013-11-26 17:58:02 -08:00
Adrian Sampson
8fe254f086
echo nest: top-level code review pass
...
General Python/beets style changes:
- "x is None" can generally be replaced with "not x"
- prefer iteration over repetitive lines
- config[foo].get(bool) can be replaced with config[foo] in conditions
- removed extraneous "return None", which is what Python functions do
automatically if you don't return anything
- 79-column wrap
2013-11-26 15:20:18 -08:00
Adrian Sampson
8f54b2ef3d
sync docs with previous commit
2013-11-25 23:20:31 -08:00
Adrian Sampson
8483b67641
duplicates: only one type of deletion
2013-11-25 23:17:07 -08:00
Adrian Sampson
1966bc9bda
duplicates: some config handling simplification
2013-11-25 23:15:55 -08:00
Adrian Sampson
e475e40b41
docs proofreading
2013-11-25 23:02:01 -08:00
Adrian Sampson
1171f47e98
mpdstats: log with displayable_path, etc.
2013-11-25 22:58:43 -08:00
Adrian Sampson
0167f67a96
simplify MPD configuration
2013-11-25 22:45:42 -08:00
Adrian Sampson
0c32ad1dee
mpdstats: style fixes
2013-11-25 22:15:22 -08:00
Adrian Sampson
2c0c8494ba
mpdstats: clean up some unused code
2013-11-25 22:05:43 -08:00
Adrian Sampson
cf3af711da
replace: tolerate None replacements
...
Avoids confusion/traceback when you leave off the replacement string instead
of using ''.
2013-11-25 21:52:46 -08:00
Adrian Sampson
bc660ec47f
clutter option: permit whitespace-separated
2013-11-25 21:37:47 -08:00
Adrian Sampson
38ecb35718
lyrics -f ( #455 , closes #414 ): style, changelog
2013-11-25 15:58:53 -08:00
Adrian Sampson
2e46a6f067
opportunistic cleanup
2013-11-25 15:52:34 -08:00
Adrian Sampson
d7d1f1f78c
changelog/thanks for 887e02c fix
2013-11-25 15:51:57 -08:00
Adrian Sampson
f98dde1b7e
docs/changelog for write ( #328 , #448 )
2013-11-25 15:34:11 -08:00
Adrian Sampson
314438b8fa
slightly simpler "write" command ( #328 , #448 )
2013-11-25 15:26:11 -08:00
Adrian Sampson
dd9684470d
Merge pull request #448 from pprkut/write
...
#328 Add beet write command
2013-11-25 15:12:46 -08:00
Adrian Sampson
6ee8bb8505
changelog reorganization
2013-11-25 15:08:53 -08:00
Adrian Sampson
8d06820d9a
docs: flexattrs guide in "advanced" guide
2013-11-25 14:55:43 -08:00
Adrian Sampson
3a08b72eba
new file format? file a bug
...
(as opposed to emailing me directly)
2013-11-25 14:45:47 -08:00
Adrian Sampson
81fddad7c3
docs: note about possible lagging packaged version
...
It's surprising how many Debian users don't realize they're looking at the
wrong version of the docs.
2013-11-25 14:42:40 -08:00
Pedro Silva
e80a6b60bb
remove assertion fail caused by previous commit
2013-11-17 20:52:33 +01:00
Pedro Silva
9b75db8326
merge Bitdemon-master
...
- minor style changes
- synchronize with documentation
2013-11-17 12:34:53 +01:00
Pedro Silva
d00859e330
make 'callback' an optparse typed action
...
* this ensures metavars are shown with print_help
2013-11-16 19:58:49 +01:00
Bitdemon
f87606869c
Update lyrics.py
2013-11-10 23:18:53 +01:00
Bitdemon
de0f0792ef
Update lyrics.py
2013-11-10 23:13:35 +01:00
Bitdemon
f5f73be2b5
Update lyrics.py
2013-11-10 22:58:36 +01:00
Bitdemon
86d74f7d39
Update lyrics.py
...
added -f option to lyrics plugin
first draft
2013-11-10 22:44:37 +01:00
Pedro Silva
e8d6c94995
revert debug print left over from previous commit
2013-11-07 22:15:52 +01:00
Pedro Silva
27da05f9d3
stringify key values prior to hashing
2013-11-07 22:13:42 +01:00
Adrian Sampson
b266a2b182
changelog/thanks for #451
2013-11-07 10:39:06 -08:00
Adrian Sampson
8ab1fede55
Merge pull request #451 from dokterbob/ihate_singletons
...
Fix for #411 : iHate fails with singletons.
2013-11-07 10:37:26 -08:00
Mathijs de Bruin
2bab3135b3
Fix for #411 : iHate fails with singletons.
2013-11-07 13:57:25 +01:00
